Skip to content

Make developing flutter_tools nicer: Use fail instead of throw StateError. #163094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Feb 12, 2025
Merged

Make developing flutter_tools nicer: Use fail instead of throw StateError. #163094

auto-submit merged 2 commits into from
Feb 12, 2025

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Feb 12, 2025

Closes #163091.

@matanlurey matanlurey requested a review from bkonyi February 12, 2025 01:05
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 12, 2025
@matanlurey matanlurey added autosubmit Merge PR when tree becomes green via auto submit App emergency Jump the queue; land PR in front of all others; only use for emergencies labels Feb 12, 2025
@matanlurey matanlurey added this pull request to the merge queue Feb 12, 2025
@matanlurey matanlurey removed this pull request from the merge queue due to a manual request Feb 12, 2025
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025
@matanlurey matanlurey added autosubmit Merge PR when tree becomes green via auto submit App and removed emergency Jump the queue; land PR in front of all others; only use for emergencies labels Feb 12, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 12, 2025
Merged via the queue into flutter:master with commit 90a4323 Feb 12, 2025
143 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
da40ec0 
…`throw StateError`. (flutter/flutter#163094)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
641eb78 
…`throw StateError`. (flutter/flutter#163094)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
ea5e0be 
…`throw StateError`. (flutter/flutter#163094)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
e568dc1 
…`throw StateError`. (flutter/flutter#163094)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
e11a644 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
583c2f8 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
f10dc36 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
acf067d 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
5efcd8b 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
014be0c 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
442ff6f 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
6959848 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
9d7df0e 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
7f30afe 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
bcc4c01 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
161d93a 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
9cb3ce8 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
ee5678c 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
612edec 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
577df68 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
bc53283 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
24896fc 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
46fb579 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
7a973d1 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
23650cd 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
284510e 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
2c40ccc 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
770e144 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
0f3f932 
…`throw StateError`. (flutter/flutter#163094)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
90a4323 Make developing flutter_tools nicer: Use fail instead of …
e13bc02 
…`throw StateError`. (flutter/flutter#163094)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use fail instead of throw StateError for validating testUsingContext

2 participants

@matanlurey @bkonyi