CupertinoSliverNavigationBar.search fidelity updates #163089

victorsanni · 2025-02-11T23:38:15Z

Native iOS overlaid on Flutter view

Inactive search state	Active search state

Animation curve and duration values gotten from xcode.

Addresses some of the issues in #163020

flutter-dashboard · 2025-02-12T19:02:27Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #163089 at sha 01ad2bd

flutter-dashboard · 2025-02-12T20:34:15Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #163089 at sha cf50bb8

flutter-dashboard · 2025-02-12T22:28:27Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #163089 at sha d400121

…/flutter#163089)

Manual roll Flutter from 39b4951 to 911aa75 (56 revisions) Manual roll requested by [email protected] flutter/flutter@39b4951...911aa75 2025-02-21 [email protected] Remove legacy scenec stuff from flutter_tool (flutter/flutter#163569) 2025-02-21 [email protected] [fuchsia] reorder tests in test_suites.yaml and update the comment (flutter/flutter#163799) 2025-02-21 [email protected] Roll Dart SDK from 7ceb3be8ed0a to c5e582f15b6c (2 revisions) (flutter/flutter#163844) 2025-02-21 [email protected] Roll Packages from a9b9172 to 5a721da (2 revisions) (flutter/flutter#163848) 2025-02-21 [email protected] Roll Dart SDK from ad642ee6f94b to 7ceb3be8ed0a (2 revisions) (flutter/flutter#163832) 2025-02-21 [email protected] Update how to use VSCode with `clangd` after the monorepo merge (flutter/flutter#163671) 2025-02-21 [email protected] Reland #163711 after #163780 (flutter/flutter#163812) 2025-02-21 [email protected] Fix incorrect function name in FlutterEngineRun documentation (flutter/flutter#163696) 2025-02-21 [email protected] Roll Dart SDK from 557cbf2c7da6 to ad642ee6f94b (5 revisions) (flutter/flutter#163794) 2025-02-21 [email protected] [canvaskit] Use `visualViewport.scale` to determine device pixel ratio. (flutter/flutter#163688) 2025-02-21 [email protected] [DisplayList] Migrate rendering tests and benchmarks to DL geometry (flutter/flutter#163766) 2025-02-21 [email protected] Make `releaseMode` explicit, inform `determineDevDependencies` entirely on the flag (flutter/flutter#163780) 2025-02-21 [email protected] Ensure `exclude_dev_dependencies_test` runs if `flutter_tools` changes. (flutter/flutter#163768) 2025-02-21 [email protected] WebKit should respect TextCapitalization.words (flutter/flutter#161027) 2025-02-21 [email protected] CupertinoSliverNavigationBar.search fidelity updates (flutter/flutter#163089) 2025-02-21 [email protected] feat: Add selectionColor property to selectable text (flutter/flutter#162177) 2025-02-20 [email protected] Restore `linux_android_emulator_tests` to CI. (flutter/flutter#163747) 2025-02-20 [email protected] introduce system color palette (flutter/flutter#163335) 2025-02-20 [email protected] [web] DRY up access to headers required for multi-threaded WebAssembly (flutter/flutter#163555) 2025-02-20 [email protected] fix(CupertinoDatePicker): font is inconsistent (flutter/flutter#162932) 2025-02-20 [email protected] Create Android-API-And-Related-Versions.md (flutter/flutter#163556) 2025-02-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Avoid implicitly setting `determineDevDependencies: true` (it's not a safe operation) (#163711)" (flutter/flutter#163762) 2025-02-20 [email protected] Revert "Create g3_bug.yml" (flutter/flutter#163757) 2025-02-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make Flutter version information accessible at runtime (#140783)" (flutter/flutter#163753) 2025-02-20 [email protected] Skip Xcode install on mac_mokey Android tests (flutter/flutter#163685) 2025-02-20 [email protected] Roll Dart SDK from 2cecb16348e4 to 557cbf2c7da6 (3 revisions) (flutter/flutter#163705) 2025-02-20 [email protected] Add `FlutterVersion.engineCommitDate`, helps signal engine artifact SHA issues (flutter/flutter#163652) 2025-02-20 [email protected] Avoid implicitly setting `determineDevDependencies: true` (it's not a safe operation) (flutter/flutter#163711) 2025-02-20 [email protected] It is now safe to call `getBuildMode().release` (flutter/flutter#163712) 2025-02-20 [email protected] [iOS] remove Skia interfaces from iOS platform code. (flutter/flutter#163505) 2025-02-20 [email protected] Make Flutter version information accessible at runtime (flutter/flutter#140783) 2025-02-20 [email protected] [windows] Implement merged UI and platform thread (flutter/flutter#162935) 2025-02-20 [email protected] `CircularProgressIndicator` throws null exception (flutter/flutter#163356) 2025-02-20 [email protected] Fix the issue where DropdownMenu does not gain focus when tapped. (flutter/flutter#162874) 2025-02-20 [email protected] Check for tracked engine.version before overriding (flutter/flutter#163672) 2025-02-20 [email protected] showDialogs adds a `requestFocus` parameter. (flutter/flutter#162928) 2025-02-20 [email protected] Create helper method to dispatch object creation and disposal. (flutter/flutter#163637) 2025-02-20 [email protected] Redistribute iOS TESTOWNERS (flutter/flutter#163653) 2025-02-20 [email protected] enclosingElement -> enclosingElement3 (flutter/flutter#163681) 2025-02-19 [email protected] [ Widget Preview ] Move `preview_detector_test.dart` from `general.shard` to `commands.shard` (flutter/flutter#163619) 2025-02-19 [email protected] [iOS] always post new task during gesture dispatch. (flutter/flutter#163646) 2025-02-19 [email protected] Allow flutter tools to detach a running Chrome session (flutter/flutter#163349) 2025-02-19 [email protected] Reland "[Impeller] add support for rational bezier conics to Path (#63282)" (flutter/flutter#163645) 2025-02-19 [email protected] [web:a11y] wheel events switch to pointer mode (flutter/flutter#163582) ...

…/flutter#163089)

) Manual roll Flutter from 39b4951 to 911aa75 (56 revisions) Manual roll requested by [email protected] flutter/flutter@39b4951...911aa75 2025-02-21 [email protected] Remove legacy scenec stuff from flutter_tool (flutter/flutter#163569) 2025-02-21 [email protected] [fuchsia] reorder tests in test_suites.yaml and update the comment (flutter/flutter#163799) 2025-02-21 [email protected] Roll Dart SDK from 7ceb3be8ed0a to c5e582f15b6c (2 revisions) (flutter/flutter#163844) 2025-02-21 [email protected] Roll Packages from a9b9172 to 5a721da (2 revisions) (flutter/flutter#163848) 2025-02-21 [email protected] Roll Dart SDK from ad642ee6f94b to 7ceb3be8ed0a (2 revisions) (flutter/flutter#163832) 2025-02-21 [email protected] Update how to use VSCode with `clangd` after the monorepo merge (flutter/flutter#163671) 2025-02-21 [email protected] Reland #163711 after #163780 (flutter/flutter#163812) 2025-02-21 [email protected] Fix incorrect function name in FlutterEngineRun documentation (flutter/flutter#163696) 2025-02-21 [email protected] Roll Dart SDK from 557cbf2c7da6 to ad642ee6f94b (5 revisions) (flutter/flutter#163794) 2025-02-21 [email protected] [canvaskit] Use `visualViewport.scale` to determine device pixel ratio. (flutter/flutter#163688) 2025-02-21 [email protected] [DisplayList] Migrate rendering tests and benchmarks to DL geometry (flutter/flutter#163766) 2025-02-21 [email protected] Make `releaseMode` explicit, inform `determineDevDependencies` entirely on the flag (flutter/flutter#163780) 2025-02-21 [email protected] Ensure `exclude_dev_dependencies_test` runs if `flutter_tools` changes. (flutter/flutter#163768) 2025-02-21 [email protected] WebKit should respect TextCapitalization.words (flutter/flutter#161027) 2025-02-21 [email protected] CupertinoSliverNavigationBar.search fidelity updates (flutter/flutter#163089) 2025-02-21 [email protected] feat: Add selectionColor property to selectable text (flutter/flutter#162177) 2025-02-20 [email protected] Restore `linux_android_emulator_tests` to CI. (flutter/flutter#163747) 2025-02-20 [email protected] introduce system color palette (flutter/flutter#163335) 2025-02-20 [email protected] [web] DRY up access to headers required for multi-threaded WebAssembly (flutter/flutter#163555) 2025-02-20 [email protected] fix(CupertinoDatePicker): font is inconsistent (flutter/flutter#162932) 2025-02-20 [email protected] Create Android-API-And-Related-Versions.md (flutter/flutter#163556) 2025-02-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Avoid implicitly setting `determineDevDependencies: true` (it's not a safe operation) (#163711)" (flutter/flutter#163762) 2025-02-20 [email protected] Revert "Create g3_bug.yml" (flutter/flutter#163757) 2025-02-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make Flutter version information accessible at runtime (#140783)" (flutter/flutter#163753) 2025-02-20 [email protected] Skip Xcode install on mac_mokey Android tests (flutter/flutter#163685) 2025-02-20 [email protected] Roll Dart SDK from 2cecb16348e4 to 557cbf2c7da6 (3 revisions) (flutter/flutter#163705) 2025-02-20 [email protected] Add `FlutterVersion.engineCommitDate`, helps signal engine artifact SHA issues (flutter/flutter#163652) 2025-02-20 [email protected] Avoid implicitly setting `determineDevDependencies: true` (it's not a safe operation) (flutter/flutter#163711) 2025-02-20 [email protected] It is now safe to call `getBuildMode().release` (flutter/flutter#163712) 2025-02-20 [email protected] [iOS] remove Skia interfaces from iOS platform code. (flutter/flutter#163505) 2025-02-20 [email protected] Make Flutter version information accessible at runtime (flutter/flutter#140783) 2025-02-20 [email protected] [windows] Implement merged UI and platform thread (flutter/flutter#162935) 2025-02-20 [email protected] `CircularProgressIndicator` throws null exception (flutter/flutter#163356) 2025-02-20 [email protected] Fix the issue where DropdownMenu does not gain focus when tapped. (flutter/flutter#162874) 2025-02-20 [email protected] Check for tracked engine.version before overriding (flutter/flutter#163672) 2025-02-20 [email protected] showDialogs adds a `requestFocus` parameter. (flutter/flutter#162928) 2025-02-20 [email protected] Create helper method to dispatch object creation and disposal. (flutter/flutter#163637) 2025-02-20 [email protected] Redistribute iOS TESTOWNERS (flutter/flutter#163653) 2025-02-20 [email protected] enclosingElement -> enclosingElement3 (flutter/flutter#163681) 2025-02-19 [email protected] [ Widget Preview ] Move `preview_detector_test.dart` from `general.shard` to `commands.shard` (flutter/flutter#163619) 2025-02-19 [email protected] [iOS] always post new task during gesture dispatch. (flutter/flutter#163646) 2025-02-19 [email protected] Allow flutter tools to detach a running Chrome session (flutter/flutter#163349) 2025-02-19 [email protected] Reland "[Impeller] add support for rational bezier conics to Path (#63282)" (flutter/flutter#163645) 2025-02-19 [email protected] [web:a11y] wheel events switch to pointer mode (flutter/flutter#163582) ...

victorsanni added 5 commits February 11, 2025 10:36

Tweak prefix icon edge insets

8d4f0ef

Nav bar layout fidelity update

8e44cb0

Fix middle widget incorrectly showing mid search animation

31f9682

Fix layout + make prefix/suffix move up while scroll resize

aa83e43

Correct animation curve

38b5e90

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Feb 11, 2025

victorsanni added 3 commits February 11, 2025 15:42

Merge branch 'master' into search-fidelity

6c81aa8

Merge branch 'master' into search-fidelity

21e8e6d

Fix example tests

0c73cad

github-actions bot added f: scrolling Viewports, list views, slivers, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Feb 12, 2025

victorsanni added 3 commits February 11, 2025 17:26

Merge branch 'master' into search-fidelity

ffa822f

Add goldens

66746c2

Fix memory leaks

447f4ec

victorsanni marked this pull request as ready for review February 12, 2025 01:57

Merge branch 'master' into search-fidelity

01ad2bd

victorsanni requested a review from MitchellGoodwin February 12, 2025 18:16

flutter-dashboard bot added the will affect goldens Changes to golden files label Feb 12, 2025

victorsanni added 2 commits February 12, 2025 11:53

Docs changes

a4a8a5c

Merge branch 'master' into search-fidelity

cf50bb8

Merge branch 'master' into search-fidelity

d400121

victorsanni mentioned this pull request Feb 14, 2025

Improve fidelity of CupertinoSliverNavigationBar.search and CupertinoSearchTextField #163020

Closed

5 tasks

victorsanni added 2 commits February 18, 2025 14:39

Align suffix insets

0ebfe3b

Merge branch 'master' into search-fidelity

fd88f93

victorsanni requested a review from dkwingsmt February 18, 2025 22:45

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 21, 2025

2deb3b4 CupertinoSliverNavigationBar.search fidelity updates (flutter…

faa32da

…/flutter#163089)

Piinks mentioned this pull request Feb 21, 2025

Flutter Notable Commits - 2025 #161460

Open

engine-flutter-autoroll mentioned this pull request Feb 22, 2025

Roll Flutter from 39b4951f8f0b to 7f447ea98c1a (73 revisions) flutter/packages#8676

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025

2deb3b4 CupertinoSliverNavigationBar.search fidelity updates (flutter…

28be148

…/flutter#163089)

engine-flutter-autoroll mentioned this pull request Feb 22, 2025

Roll Flutter from 39b4951f8f0b to 7f447ea98c1a (73 revisions) flutter/packages#8677

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025

2deb3b4 CupertinoSliverNavigationBar.search fidelity updates (flutter…

be2fbe5

…/flutter#163089)

engine-flutter-autoroll mentioned this pull request Feb 22, 2025

Roll Flutter from 39b4951f8f0b to ff3b708e0fc8 (74 revisions) flutter/packages#8678

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025

2deb3b4 CupertinoSliverNavigationBar.search fidelity updates (flutter…

1af8919

…/flutter#163089)

engine-flutter-autoroll mentioned this pull request Feb 22, 2025

Manual roll Flutter from 39b4951f8f0b to ff3b708e0fc8 (74 revisions) flutter/packages#8679

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025

2deb3b4 CupertinoSliverNavigationBar.search fidelity updates (flutter…

8a4836e

…/flutter#163089)

engine-flutter-autoroll mentioned this pull request Feb 23, 2025

Roll Flutter from 39b4951f8f0b to 10644396b824 (76 revisions) flutter/packages#8680

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2025

2deb3b4 CupertinoSliverNavigationBar.search fidelity updates (flutter…

727ff96

…/flutter#163089)

engine-flutter-autoroll mentioned this pull request Feb 23, 2025

Roll Flutter from 39b4951f8f0b to 10644396b824 (76 revisions) flutter/packages#8681

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2025

2deb3b4 CupertinoSliverNavigationBar.search fidelity updates (flutter…

7dd13bb

…/flutter#163089)

engine-flutter-autoroll mentioned this pull request Feb 24, 2025

Roll Flutter from 39b4951f8f0b to 39dd5a0897cf (79 revisions) flutter/packages#8684

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025

2deb3b4 CupertinoSliverNavigationBar.search fidelity updates (flutter…

2300d35

…/flutter#163089)

engine-flutter-autoroll mentioned this pull request Feb 24, 2025

Roll Flutter from 39b4951f8f0b to 9a13fd785f2b (80 revisions) flutter/packages#8686

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025

2deb3b4 CupertinoSliverNavigationBar.search fidelity updates (flutter…

f42303c

…/flutter#163089)

engine-flutter-autoroll mentioned this pull request Feb 24, 2025

Manual roll Flutter from 39b4951f8f0b to 911aa7547ed7 (56 revisions) flutter/packages#8687

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025

2deb3b4 CupertinoSliverNavigationBar.search fidelity updates (flutter…

6c770ee

…/flutter#163089)

engine-flutter-autoroll mentioned this pull request Feb 24, 2025

Roll Flutter from 39b4951f8f0b to 0102da95cd20 (81 revisions) flutter/packages#8688

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025

2deb3b4 CupertinoSliverNavigationBar.search fidelity updates (flutter…

d3a707a

…/flutter#163089)

engine-flutter-autoroll mentioned this pull request Feb 24, 2025

Roll Flutter from 39b4951f8f0b to e2c4ba31b83e (82 revisions) flutter/packages#8689

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025

2deb3b4 CupertinoSliverNavigationBar.search fidelity updates (flutter…

75ea82a

…/flutter#163089)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

2deb3b4 CupertinoSliverNavigationBar.search fidelity updates (flutter…

d2a36bc

…/flutter#163089)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

2deb3b4 CupertinoSliverNavigationBar.search fidelity updates (flutter…

9ef1611

…/flutter#163089)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

2deb3b4 CupertinoSliverNavigationBar.search fidelity updates (flutter…

9c4c079

…/flutter#163089)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CupertinoSliverNavigationBar.search fidelity updates #163089

CupertinoSliverNavigationBar.search fidelity updates #163089

Uh oh!

victorsanni commented Feb 11, 2025 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Feb 12, 2025

Uh oh!

flutter-dashboard bot commented Feb 12, 2025

Uh oh!

flutter-dashboard bot commented Feb 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CupertinoSliverNavigationBar.search fidelity updates #163089

CupertinoSliverNavigationBar.search fidelity updates #163089

Uh oh!

Conversation

victorsanni commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native iOS overlaid on Flutter view

Uh oh!

flutter-dashboard bot commented Feb 12, 2025

Uh oh!

flutter-dashboard bot commented Feb 12, 2025

Uh oh!

flutter-dashboard bot commented Feb 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

victorsanni commented Feb 11, 2025 •

edited

Loading