Adds all semantics roles #163075

chunhtai · 2025-02-11T19:37:03Z

This pr adds all the roles enum in one go without actually wiring up to framework and engine.
It serves the following purposes

reduce pr conflict when multiple people working on adding new enum in the list
help with IDE and google test as these enum will be added in the latest engine binary after it merge.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2025-02-11T19:37:06Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

chunhtai · 2025-02-11T19:40:37Z

packages/flutter/lib/src/semantics/semantics.dart

    SemanticsRole.tabPanel => _noCheckRequired,
+    // TODO(chunhtai): add checks when the roles are used in framework.
+    // https://github.com/flutter/flutter/issues/159741.
+    SemanticsRole.searchBox => _unimplemented,


This is the test that if one remove the enum, this will throw compile time error

chunhtai · 2025-02-11T19:43:03Z

I can't think of a reasonable test besides the compile time error since this is just adding enum without actual change to behavior

stuartmorgan-g · 2025-02-11T19:54:35Z

test-exempt: the placeholders are compile-time checked, and the alignment between C and Dart can only be tested once functionality is added.

engine/src/flutter/lib/ui/semantics.dart

yjbanov · 2025-02-11T23:29:55Z

engine/src/flutter/lib/ui/semantics.dart

+
+  /// A control that controls the scrolling of content within a viewing
+  /// area.
+  scrollBar,


Do we publish scrollbars to the semantics? I'm not sure how this would be mapped onto the framework in a way that would actually integrate with screen readers 🤔

this is for custom scrollbar, not the native scroll bar.
https://api.flutter.dev/flutter/material/Scrollbar-class.html

Yeah, I just don't know what will happen if this gets into our semantics tree. Will we crash? :)

interestingly in native html, setting the scrollbar role will cause voiceover to ignore that element. our scrollbar doesn't seem to contribute to semantics it seem. I will remove this enum

yjbanov · 2025-02-11T23:31:54Z

engine/src/flutter/lib/ui/semantics.dart

+  /// e.g, a [CircularProgressIndicator].
+  loadingSpinner,
+
+  /// A graphic object that shows progress along a line.


Does it have to be "along a line"? This role could be used for a progress indicator designed like this:

This is specific for https://api.flutter.dev/flutter/material/LinearProgressIndicator-class.html

does this circular progress indicator consider a progress'bar'?

Good question. Do the visuals matter for screen reader purposes? If it represents some progress from 0% to 100%, it is some sort of progress bar-ish thing.

updated the doc to not restrict to linear bar

engine/src/flutter/lib/ui/semantics.dart

yjbanov

auto-submit · 2025-02-14T19:21:47Z

autosubmit label was removed for flutter/flutter/163075, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

Roll Flutter from e8f34a9 to 39b4951 (95 revisions) flutter/flutter@e8f34a9...39b4951 2025-02-18 [email protected] Marks Windows_arm64 plugin_test_windows to be flaky (flutter/flutter#163123) 2025-02-18 [email protected] [android] use macro definition to shrink repetitive JNI code size. (flutter/flutter#163395) 2025-02-18 [email protected] Roll pub packages (flutter/flutter#163474) 2025-02-18 [email protected] [web] Cleanup everything HTML from the engine (outside html/ folder) (flutter/flutter#162840) 2025-02-18 [email protected] [Impeller] add support for rational bezier conics to Path (flutter/flutter#163282) 2025-02-18 [email protected] Change `cardTheme`, `dialogTheme`, and `tabBarTheme` type to `xxxThemeData` (flutter/flutter#157292) 2025-02-18 [email protected] Update integration test and benchmark Android .gitignore files to match the current app template (flutter/flutter#163276) 2025-02-18 [email protected] [Impeller] Don't create a redundant typography context. (flutter/flutter#163513) 2025-02-18 [email protected] Roll Dart SDK from fcef25f18e4d to 023ac80cef14 (1 revision) (flutter/flutter#163110) 2025-02-18 [email protected] update module_host_with_custom_build_v2_embedding to target android 35 and to use the latest gradle and agp versions (flutter/flutter#163542) 2025-02-18 [email protected] [Impeller] when binding to READ_FRAMEBUFFER, treat multisampled textures as single sampled. (flutter/flutter#163345) 2025-02-18 [email protected] Add missing properties to _ArcPaintPredicate. (flutter/flutter#162572) 2025-02-18 [email protected] Roll Packages from 8542af3 to cb4fb13 (4 revisions) (flutter/flutter#163544) 2025-02-18 [email protected] Remove bringup for android_display_cutout (flutter/flutter#163312) 2025-02-18 [email protected] Create VersionUtils class and unit tests and extract logic out of flutter.groovy (flutter/flutter#163166) 2025-02-18 [email protected] Invalidate `pod install` output if `.flutter-plugins-dependencies` content changes. (flutter/flutter#163275) 2025-02-18 [email protected] Replace hard coded numbers with mouse button defines (flutter/flutter#163503) 2025-02-18 [email protected] Roll Skia from 9147a9654043 to 6da10829d017 (1 revision) (flutter/flutter#163531) 2025-02-18 [email protected] Roll Skia from 92aaa4e20ea7 to 9147a9654043 (2 revisions) (flutter/flutter#163512) 2025-02-17 [email protected] Roll Skia from 71a160edc9d9 to 92aaa4e20ea7 (1 revision) (flutter/flutter#163488) 2025-02-17 [email protected] Roll Packages from 625023a to 8542af3 (21 revisions) (flutter/flutter#163484) 2025-02-17 [email protected] Roll Skia from 7e3129d5db11 to 71a160edc9d9 (1 revision) (flutter/flutter#163459) 2025-02-17 [email protected] Roll Skia from 40ce5ef20d22 to 7e3129d5db11 (1 revision) (flutter/flutter#163451) 2025-02-16 [email protected] Roll Skia from bb166c85957b to 40ce5ef20d22 (1 revision) (flutter/flutter#163403) 2025-02-15 [email protected] Roll Skia from ff94581f1f8a to bb166c85957b (1 revision) (flutter/flutter#163381) 2025-02-15 [email protected] Move DWDS initialization into the onLoadEndCallback for the DDC library bundle format (flutter/flutter#163338) 2025-02-14 [email protected] [canvaskit] Handle MakeGrContext returning null (flutter/flutter#163332) 2025-02-14 [email protected] Roll Skia from 13a3b6f34ee8 to ff94581f1f8a (1 revision) (flutter/flutter#163347) 2025-02-14 [email protected] Fix failing chrome_dev_mode tests (flutter/flutter#163346) 2025-02-14 [email protected] Adds all semantics roles (flutter/flutter#163075) 2025-02-14 [email protected] Roll Skia from 20924303cc25 to 13a3b6f34ee8 (1 revision) (flutter/flutter#163336) 2025-02-14 [email protected] [ Widget Preview ] Add experimental support for web-based widget preview environment (flutter/flutter#163154) 2025-02-14 [email protected] [Impeller] don't use glFramebufferBlit for onscreen restore. (flutter/flutter#163327) 2025-02-14 [email protected] Align web terminal messages with the VM (flutter/flutter#163268) 2025-02-14 [email protected] Manually roll customer_testing to enable rfw tests (flutter/flutter#163030) 2025-02-14 [email protected] Refactor SliverMainAxisGroup for reverse mode. (flutter/flutter#161849) 2025-02-14 [email protected] Tweaked TextContents math to avoid floating point errors (flutter/flutter#162480) 2025-02-14 [email protected] [release] Update cherry-pick CHANGELOG requirements (flutter/flutter#163318) 2025-02-14 [email protected] Roll Skia from 85722a1db585 to 20924303cc25 (2 revisions) (flutter/flutter#163293) 2025-02-14 [email protected] Roll Skia from 5a38d23ee247 to 85722a1db585 (1 revision) (flutter/flutter#163286) 2025-02-14 [email protected] Add `.flutter-plugins-dependencies` to `FlutterBuildSystem`; update logic, add tests. (flutter/flutter#163278) 2025-02-14 [email protected] Add table related semantics role (flutter/flutter#162339) 2025-02-14 [email protected] [Impeller] Call glDebugMessageControlKHR only if the KHR_debug extension is available (flutter/flutter#163273) 2025-02-14 [email protected] Roll Skia from 748415976ad1 to 5a38d23ee247 (3 revisions) (flutter/flutter#163271) 2025-02-14 [email protected] [canvaskit] Use `transferToImageBitmap` instead of `createImageBitmap` (flutter/flutter#163175) 2025-02-14 [email protected] [skwasm] Use `transferToImageBitmap` instead of `createImageBitmap` (flutter/flutter#163251) ...

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-web Web applications specifically labels Feb 11, 2025

chunhtai commented Feb 11, 2025

View reviewed changes

yjbanov reviewed Feb 11, 2025

View reviewed changes

chunhtai force-pushed the roles branch from 8c191b7 to 9c3133e Compare February 13, 2025 19:03

chunhtai requested a review from yjbanov February 13, 2025 19:07

chunhtai force-pushed the roles branch from 5c5be98 to bd1d9ae Compare February 13, 2025 23:15

yjbanov approved these changes Feb 13, 2025

View reviewed changes

chunhtai added 3 commits February 14, 2025 10:06

Adds all semantics roles

15f2f4a

addressing comment

c85e873

update

49c8973

chunhtai force-pushed the roles branch from bd1d9ae to 49c8973 Compare February 14, 2025 18:09

update

0a2c2d2

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2025

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2025

auto-submit bot added this pull request to the merge queue Feb 14, 2025

Merged via the queue into flutter:master with commit 644e46a Feb 14, 2025
175 of 176 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2025

engine-flutter-autoroll mentioned this pull request Feb 15, 2025

Roll Flutter from 892f9c13a2bb to c5ba240021b5 (142 revisions) flutter/packages#8638

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

5c56282

engine-flutter-autoroll mentioned this pull request Feb 15, 2025

Roll Flutter from 892f9c13a2bb to c5ba240021b5 (142 revisions) flutter/packages#8639

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

0ab0cbe

engine-flutter-autoroll mentioned this pull request Feb 16, 2025

Roll Flutter from 892f9c13a2bb to c7047d33c4d2 (143 revisions) flutter/packages#8644

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

6fbfde5

engine-flutter-autoroll mentioned this pull request Feb 17, 2025

Roll Flutter from 892f9c13a2bb to d96f6212f4de (145 revisions) flutter/packages#8647

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

2b1c4fb

engine-flutter-autoroll mentioned this pull request Feb 17, 2025

Roll Flutter from 892f9c13a2bb to 22c78a0716da (146 revisions) flutter/packages#8648

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

bf18361

engine-flutter-autoroll mentioned this pull request Feb 17, 2025

Roll Flutter from 892f9c13a2bb to e3ea776da3f7 (147 revisions) flutter/packages#8649

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

4f74a42

engine-flutter-autoroll mentioned this pull request Feb 18, 2025

Roll Flutter from e8f34a9eea90 to ffd53ff16641 (78 revisions) flutter/packages#8651

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

2f67c22

engine-flutter-autoroll mentioned this pull request Feb 18, 2025

Roll Flutter from e8f34a9eea90 to 5365993ff52e (79 revisions) flutter/packages#8653

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

ee52c49

engine-flutter-autoroll mentioned this pull request Feb 18, 2025

Roll Flutter from e8f34a9eea90 to 5365993ff52e (79 revisions) flutter/packages#8655

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

8d30556

engine-flutter-autoroll mentioned this pull request Feb 19, 2025

Roll Flutter from e8f34a9eea90 to 7e155bc18e57 (90 revisions) flutter/packages#8660

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

45dc7a1

engine-flutter-autoroll mentioned this pull request Feb 19, 2025

Roll Flutter from e8f34a9eea90 to 7e155bc18e57 (90 revisions) flutter/packages#8662

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

34bcdb0

engine-flutter-autoroll mentioned this pull request Feb 19, 2025

Roll Flutter from e8f34a9eea90 to 39b4951f8f0b (95 revisions) flutter/packages#8663

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

0937a5c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

57b57d3

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

2887e9d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

bd1195f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

fbfca26

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

b559aa1

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

3187acb

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

644e46a Adds all semantics roles (flutter/flutter#163075)

41dcc39

Adds all semantics roles #163075

Adds all semantics roles #163075

Uh oh!

Conversation

chunhtai commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Feb 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai commented Feb 11, 2025

Uh oh!

stuartmorgan-g commented Feb 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yjbanov left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Feb 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chunhtai commented Feb 11, 2025 •

edited

Loading