Skip to content

Lower minimum java file count to 1. #162915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
Feb 8, 2025
Merged

Lower minimum java file count to 1. #162915

jonahwilliams merged 1 commit into from
Feb 8, 2025

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Feb 8, 2025

We removed enough java files that we're failing a "minimum number of java check".

@jonahwilliams jonahwilliams changed the title fix tree. Lower minimum java file count to 1. Feb 8, 2025
@jonahwilliams jonahwilliams added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Feb 8, 2025
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 8, 2025

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

jtmcdole
jtmcdole approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@jtmcdole jtmcdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams added this pull request to the merge queue Feb 8, 2025
Merged via the queue into flutter:master with commit 494c47c Feb 8, 2025
147 of 150 checks passed
@jonahwilliams jonahwilliams deleted the come_on_now branch February 8, 2025 00:47
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
3a94986
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
9546c54
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
964355f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
9d92b59
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
47f64d4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
a014137
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
b4ef5b8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
8fc3dc2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
d72c519
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
4dad2bc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
2d1f392
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
a5f8b6f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
8a937fa
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
fc3ca41
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
f89023e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
111a598
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
c5ecff1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
11b6943
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
01b1b28
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
e03a806
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
c40f1cd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
1e413c7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
36e9468
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
9dd6fe4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
38fc777
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
0b03282
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
370a29a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
1f235bd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
0faa019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
e8de343
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
a417ddf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
86edd50
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
fcd52b4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
a5dfa7f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
ee771bb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
494c47c Lower minimum java file count to 1. (flutter/flutter#162915)
13aa327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees

No one assigned

Labels

emergency Jump the queue; land PR in front of all others; only use for emergencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @jtmcdole