fix the issue that can't set app bar traversal order for flexible space by hannah-hyj · Pull Request #162910 · flutter/flutter

hannah-hyj · 2025-02-07T22:00:39Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Update app_bar.dart

chunhtai · 2025-02-12T20:36:33Z

+  ///
+  /// Defaults to false.
+  /// {@endtemplate}
+  final bool customizeSemanticsSortKeys;


This needs a better name. maybe called useDefaultSemanticsOrder and doc should also comment what the default semantics order and how they can change it (by assigning the sortkey in the input widget).

and also should add a See also that points to semanticsSortKey doc

chunhtai

LGTM

chunhtai · 2025-02-13T00:21:47Z

-  /// If this is set to false, the app bar will use the default sort key behavior,
-  /// which means the flexible space will appear after the main content in the semantics tree.
+  /// If this is set to true, the app bar will use the default semantic ordering,
+  /// which places the flexible space after the main content in the semantics tree.


some where in the doc should mention this is for accessibility traversal order.

…ible space (flutter/flutter#162910)

update

3aba2f0

Update app_bar.dart

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Feb 7, 2025

Update app_bar_test.dart

bc04eea

hannah-hyj requested a review from chunhtai February 7, 2025 22:01

chunhtai reviewed Feb 12, 2025

View reviewed changes

hannah-hyj added 2 commits February 12, 2025 14:57

resolve comments

039d9b4

Update app_bar.dart

2beaba6

hannah-hyj requested a review from chunhtai February 12, 2025 22:59

hannah-hyj added 2 commits February 12, 2025 15:00

Merge branch 'master' into appbar-a11y-order

8913479

lint

dfc4269

chunhtai approved these changes Feb 13, 2025

View reviewed changes

hannah-hyj added 2 commits February 12, 2025 16:35

update comments

aea2710

Merge branch 'master' into appbar-a11y-order

64223d8

hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2025

auto-submit Bot added this pull request to the merge queue Feb 13, 2025

Merged via the queue into flutter:master with commit 539c5b9 Feb 13, 2025

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2025

engine-flutter-autoroll mentioned this pull request Feb 14, 2025

Roll Flutter from 892f9c13a2bb to 990e837656ca (128 revisions) flutter/packages#8631

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

7eeaedd

…ible space (flutter/flutter#162910)

engine-flutter-autoroll mentioned this pull request Feb 14, 2025

Roll Flutter from 892f9c13a2bb to 990e837656ca (128 revisions) flutter/packages#8632

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

8fef4fc

…ible space (flutter/flutter#162910)

engine-flutter-autoroll mentioned this pull request Feb 14, 2025

Roll Flutter from 892f9c13a2bb to 3dc4e016707a (129 revisions) flutter/packages#8633

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

c97cee9

…ible space (flutter/flutter#162910)

engine-flutter-autoroll mentioned this pull request Feb 14, 2025

Roll Flutter from 892f9c13a2bb to f949d8eaedf3 (130 revisions) flutter/packages#8634

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

509cddc

…ible space (flutter/flutter#162910)

engine-flutter-autoroll mentioned this pull request Feb 14, 2025

Roll Flutter from 892f9c13a2bb to a43095296888 (131 revisions) flutter/packages#8635

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

12c124f

…ible space (flutter/flutter#162910)

Piinks mentioned this pull request Feb 14, 2025

Flutter Notable Commits - 2025 #161460

Closed

engine-flutter-autoroll mentioned this pull request Feb 15, 2025

Roll Flutter from 892f9c13a2bb to c5ba240021b5 (142 revisions) flutter/packages#8638

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

7c98920

…ible space (flutter/flutter#162910)

engine-flutter-autoroll mentioned this pull request Feb 15, 2025

Roll Flutter from 892f9c13a2bb to c5ba240021b5 (142 revisions) flutter/packages#8639

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

21c2127

…ible space (flutter/flutter#162910)

engine-flutter-autoroll mentioned this pull request Feb 16, 2025

Roll Flutter from 892f9c13a2bb to c7047d33c4d2 (143 revisions) flutter/packages#8643

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

9a02043

…ible space (flutter/flutter#162910)

engine-flutter-autoroll mentioned this pull request Feb 16, 2025

Roll Flutter from 892f9c13a2bb to c7047d33c4d2 (143 revisions) flutter/packages#8644

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

5438fe5

…ible space (flutter/flutter#162910)

engine-flutter-autoroll mentioned this pull request Feb 17, 2025

Roll Flutter from 892f9c13a2bb to d96f6212f4de (145 revisions) flutter/packages#8647

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

77b933e

…ible space (flutter/flutter#162910)

engine-flutter-autoroll mentioned this pull request Feb 17, 2025

Roll Flutter from 892f9c13a2bb to 22c78a0716da (146 revisions) flutter/packages#8648

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

f42c21e

…ible space (flutter/flutter#162910)

engine-flutter-autoroll mentioned this pull request Feb 17, 2025

Roll Flutter from 892f9c13a2bb to e3ea776da3f7 (147 revisions) flutter/packages#8649

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

4ce3e23

…ible space (flutter/flutter#162910)

engine-flutter-autoroll mentioned this pull request Feb 18, 2025

Roll Flutter from e8f34a9eea90 to ffd53ff16641 (78 revisions) flutter/packages#8651

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

ad8ea54

…ible space (flutter/flutter#162910)

engine-flutter-autoroll mentioned this pull request Feb 18, 2025

Roll Flutter from e8f34a9eea90 to 5365993ff52e (79 revisions) flutter/packages#8653

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

298430c

…ible space (flutter/flutter#162910)

engine-flutter-autoroll mentioned this pull request Feb 18, 2025

Roll Flutter from e8f34a9eea90 to 5365993ff52e (79 revisions) flutter/packages#8655

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

6c0e927

…ible space (flutter/flutter#162910)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

bf418ef

…ible space (flutter/flutter#162910)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

7bb3601

…ible space (flutter/flutter#162910)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

bb7704e

…ible space (flutter/flutter#162910)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

3941f6d

…ible space (flutter/flutter#162910)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

5d1e61c

…ible space (flutter/flutter#162910)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

0301ac7

…ible space (flutter/flutter#162910)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

f3d6d50

…ible space (flutter/flutter#162910)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

cde0de9

…ible space (flutter/flutter#162910)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

cd22db4

…ible space (flutter/flutter#162910)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

539c5b9 fix the issue that can't set app bar traversal order for flex…

2a880ea

…ible space (flutter/flutter#162910)

Navigation Menu

Repository navigation

fix the issue that can't set app bar traversal order for flexible space - #162910

fix the issue that can't set app bar traversal order for flexible space#162910
auto-submit[bot] merged 8 commits into
flutter:masterfrom
hannah-hyj:appbar-a11y-order

hannah-hyj commented Feb 7, 2025 •

edited

Loading

Uh oh!

chunhtai Feb 12, 2025

Uh oh!

chunhtai left a comment

Uh oh!

chunhtai Feb 13, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

hannah-hyj commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

chunhtai Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai Feb 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hannah-hyj commented Feb 7, 2025 •

edited

Loading