Skip to content

Roll engine to aa9ce7092801e7ed8f3f86df0d1067279d13784d #16289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cbracken merged 1 commit into from
Apr 6, 2018
Merged

Roll engine to aa9ce7092801e7ed8f3f86df0d1067279d13784d #16289

cbracken merged 1 commit into from
Apr 6, 2018

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Apr 5, 2018 •
edited
Loading

Includes:

@cbracken
Roll engine to aa9ce70
a687fb4 
Includes:
* Add armv7 support to create_ios_framework script (flutter#4942)
* Roll Dart to version 09e1766e6caa537e1271fbce04ebcbf8212b6569 (flutter#4941)
@cbracken cbracken merged commit 2134adc into flutter:master Apr 6, 2018
@cbracken cbracken deleted the roll-engine branch April 6, 2018 00:33
@tvolkert
Copy link
Contributor

tvolkert commented Apr 9, 2018

This has been implicated in #16357 (significant binary size increase in iOS framework). The engine commits contained herein are:

flutter/engine@adf5ddf -- Roll Dart to version 09e1766e6caa537e1271fbce04ebcbf8212b6569
flutter/engine@aa9ce70 -- Add armv7 support to create_ios_framework script

@cbracken is Flutter.framework/Flutter always a fat binary that includes armv7 now? If so, is this working as intended, and we're counting on thinning when it gets uploaded to app store?

/cc @mehmetf

@tvolkert tvolkert mentioned this pull request Apr 9, 2018
Closed
@cbracken
Copy link
Member Author

cbracken commented Apr 9, 2018

Yes this is expected. We can temporarily enable armv7 stripping in xcode_backend.sh bit the goal is to ship universal armv7 + arm64 binaries.

@tvolkert
Copy link
Contributor

tvolkert commented Apr 9, 2018

It sounds like the better answer is just to re-baseline, and internally, we can either strip the binary when we build, or just re-baseline there as well and rely on the app store to thin the binary

DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@cbracken
Roll engine to aa9ce70 (flutter#16289)
6835956 
Includes:
* Add armv7 support to create_ios_framework script (flutter#4942)
* Roll Dart to version 09e1766e6caa537e1271fbce04ebcbf8212b6569 (flutter#4941)
teriyakijack added a commit to teriyakijack/flutter that referenced this pull request Jul 17, 2018
@teriyakijack
Merge branch 'master' of https://github.com/flutter/flutter
e009183 
* 'master' of https://github.com/flutter/flutter:
  Roll engine to aa9ce70 (flutter#16289)
  Rename chip's border attribute to shape for consistency. (flutter#16276)
  Added BeveledRectangleBorder ShapeBorder (flutter#16279)
  Roll engine to version be07059 (flutter#16264)
  Make Podfiles work with Cocoapods 1.5.0 (flutter#16273)
  Updated appearance of filled TextFields - added UnderlineInputBorder.borderRadius (flutter#16272)
  Handle whitespace in entry values in the AAPT badging parser (flutter#16245)
  a11y adjustments for the Bottom app bar demo (flutter#16238)
  Play butterfly video from asset instead of network (flutter#16269)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cbracken @tvolkert @jason-simmons @googlebot