Skip to content

Fix typos in CHANGELOG.md #162851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
camsim99 wants to merge 2 commits into from
Closed

Fix typos in CHANGELOG.md #162851

camsim99 wants to merge 2 commits into from

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Feb 7, 2025 •
edited
Loading

Fixes typos I noticed when creating #162761.

Pre-launch Checklist

@camsim99
Fix typos in CHANGELOG.md
60f86fb 
Fixes typos I noticed when creating #162761.
christopherfujino
christopherfujino approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 7, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 7, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 7, 2025

autosubmit label was removed for flutter/flutter/162851, because - The status or check suite Analyze (python) has failed. Please fix the issues identified (or deflake) before re-applying this label.

@camsim99
Copy link
Contributor Author

camsim99 commented Feb 7, 2025

Hmm @christopherfujino can we land this anyway? The error seems unrelated. https://github.com/flutter/flutter/actions/runs/13190580774/job/36863247888?pr=162851

@camsim99 camsim99 mentioned this pull request Feb 7, 2025
Merged
9 tasks
@camsim99
Update CHANGELOG.md
9c8cb4e 
Add period added to master in #162887.
@christopherfujino
Copy link
Contributor

christopherfujino commented Feb 7, 2025

Hmm @christopherfujino can we land this anyway? The error seems unrelated. https://github.com/flutter/flutter/actions/runs/13190580774/job/36863247888?pr=162851

I agree. However, since I have to land a follow-up commit to the changelog anyway, I think I'm gonna combine this change into that one.

@camsim99
Copy link
Contributor Author

camsim99 commented Feb 7, 2025 •
edited
Loading

I agree. However, since I have to land a follow-up commit to the changelog anyway, I think I'm gonna combine this change into that one.

Sounds good! Thank you!

@camsim99 camsim99 closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camsim99 @christopherfujino