Skip to content

Revert the preview-device feature, tests, and code that only existed for it. #162835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 7 commits into from
Feb 8, 2025
Merged

Revert the preview-device feature, tests, and code that only existed for it. #162835

auto-submit merged 7 commits into from
Feb 8, 2025

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Feb 6, 2025

Closes #162693.

Fortunately due to the power of git, it will live forever 🫡

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 6, 2025
jonahwilliams
jonahwilliams reviewed Feb 6, 2025
View reviewed changes
packages/flutter_tools/lib/src/flutter_device_manager.dart
platform: platform,
artifacts: artifacts,
fileSystem: fileSystem,
logger: logger,
Copy link
Contributor

@jonahwilliams jonahwilliams Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow wow wee wow

jonahwilliams
jonahwilliams approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow wow wee wow

@matanlurey matanlurey marked this pull request as ready for review February 7, 2025 20:32
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 7, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 7, 2025

autosubmit label was removed for flutter/flutter/162835, because - The status or check suite CI Caught Failure has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 7, 2025
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 7, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 8, 2025
Merged via the queue into flutter:master with commit 6cca066 Feb 8, 2025
179 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 8, 2025
@zanderso
Copy link
Member

zanderso commented Feb 8, 2025

Shedding a tear for this one. In a kinder world, it would've been a star.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
7411789 
…y existed for it. (flutter/flutter#162835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
7ef6094 
…y existed for it. (flutter/flutter#162835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
c4feb4b 
…y existed for it. (flutter/flutter#162835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
6722f28 
…y existed for it. (flutter/flutter#162835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
81fe196 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
ac49ba1 
…y existed for it. (flutter/flutter#162835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
041a541 
…y existed for it. (flutter/flutter#162835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
7a1c386 
…y existed for it. (flutter/flutter#162835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
36c7498 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
f8cc18a 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
c22673f 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
dd4f9a0 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
e7840c9 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
bc8a552 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
c905ecf 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
6effeff 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
2d58708 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
a4d4440 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
9d63195 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
9d91884 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
aab674d 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
f6f598f 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
581efee 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
cd1e37e 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
cf2ba55 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
f3cbf73 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
381ef04 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
74e0d7f 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
6d88037 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
f869c0e 
…y existed for it. (flutter/flutter#162835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
6cca066 Revert the preview-device feature, tests, and code that onl…
a363e3f 
…y existed for it. (flutter/flutter#162835)
@JSUYA JSUYA mentioned this pull request May 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should we revert PreviewDevice (and associated code)?

3 participants

@matanlurey @zanderso @jonahwilliams