-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[raw_menu_anchor.0.dart] Remove misdrawn emojis. #162807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
bleroux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
piedcipher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for fixing! My bad. Not sure what the last failing test is but looks like infra? |
Cool.. I've tried re-running the failing check. |
|
Looks like infra, still failing. |
|
I think another merge was not needed, all tests were passed except tree-status which becomes green on its own. |

This PR removes the leading emojis displayed on the RawMenuAnchor example. I knew emojis usually showed up monochrome on web, but code samples also appear to incorrectly display the emoji source.
Because this change doesn't affect the menu's functionality, I didn't include additional tests, but I'd be happy to add tests if needed. One test was modified to account for menu items no longer having a leading icon.
Fixes #162806
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.