[fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead #162780

gbbosak · 2025-02-06T00:38:53Z

This is a Fuchsia change to prepare for future changes to the SDK. LogSink and InspectSink will soon be routed through dictionaries, rather than explicitly. For RealmBuilders, we need to route both the dictionary and the protocol (to preserve compatibility). For CML files, we need to use the shards in the SDK instead of using explicit routes. Once the SDK shard is updated, then all SDK consumers should receive new routes. However, not everyone will necessarily be updated at the same time, which is the reason for keeping compatibility routes in RealmBuilder (to prepare for the soft transition).

b/394681733

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[(Google employee)] I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
[X (exempt, SDK mechanical change only)] I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
[X (unable to test on Fuchsia, I believe it has to be merged to be tested)] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gbbosak · 2025-02-06T00:40:07Z

Ah neat, it looks like tests run automatically on GitHub.

gbbosak · 2025-02-06T02:09:15Z

This is blocked on the f26 roll into Flutter.

chinmaygarde · 2025-02-24T18:55:33Z

Is this still blocked?

gbbosak · 2025-02-24T18:58:24Z

I'm not sure -- I'll run your CI again to see if it is.

gbbosak · 2025-02-26T17:15:31Z

Looks like it's still blocked on an API level version update.

chinmaygarde · 2025-03-10T18:09:42Z

How do I follow where that version update is happeneing?

gbbosak · 2025-03-10T18:12:13Z

I don't know, that's why I keep retrying the dry runs to see if it's been done yet. It's something that the Flutter team has to do (uprev to the latest Fuchsia SDK version).

The closest bug seems to be b/392657486, but that seems fairly generic and not specific to Flutter.

gbbosak · 2025-03-26T20:48:05Z

I think this is ready for review now, although it looks like the tests are very flaky, but the flakiness appears to be unrelated to this pull request.

gbbosak · 2025-03-28T19:05:15Z

It looks like this is failing due to formatting issues. Can a Flutter developer run the formatter on this change, or tell me how I can run it (if I can run it without being on the Flutter team)?

zijiehe-google-com · 2025-03-28T19:11:55Z

To fix, run `et format` or:
git apply <<DONE
diff --git a/engine/src/flutter/shell/platform/fuchsia/dart_runner/tests/startup_integration_test/dart_aot_runner/dart-aot-runner-integration-test.cc b/engine/src/flutter/shell/platform/fuchsia/dart_runner/tests/startup_integration_test/dart_aot_runner/dart-aot-runner-integration-test.cc
index db9fa42f2e..0000000000 100644
--- a/engine/src/flutter/shell/platform/fuchsia/dart_runner/tests/startup_integration_test/dart_aot_runner/dart-aot-runner-integration-test.cc
+++ b/engine/src/flutter/shell/platform/fuchsia/dart_runner/tests/startup_integration_test/dart_aot_runner/dart-aot-runner-integration-test.cc
@@ -17,13 +17,13 @@ namespace {
// Types imported for the realm_builder library
using component_testing::ChildOptions;
using component_testing::ChildRef;
+using component_testing::Dictionary;
using component_testing::Directory;
using component_testing::ParentRef;
using component_testing::Protocol;
using component_testing::RealmBuilder;
using component_testing::RealmRoot;
using component_testing::Route;
-using component_testing::Dictionary;
constexpr auto kDartRunnerEnvironment = "dart_runner_env";
diff --git a/engine/src/flutter/shell/platform/fuchsia/dart_runner/tests/startup_integration_test/dart_jit_runner/dart-jit-runner-integration-test.cc b/engine/src/flutter/shell/platform/fuchsia/dart_runner/tests/startup_integration_test/dart_jit_runner/dart-jit-runner-integration-test.cc
index 107555fb3e..0000000000 100644
--- a/engine/src/flutter/shell/platform/fuchsia/dart_runner/tests/startup_integration_test/dart_jit_runner/dart-jit-runner-integration-test.cc
+++ b/engine/src/flutter/shell/platform/fuchsia/dart_runner/tests/startup_integration_test/dart_jit_runner/dart-jit-runner-integration-test.cc
@@ -17,14 +17,13 @@ namespace {
// Types imported for the realm_builder library
using component_testing::ChildOptions;
using component_testing::ChildRef;
+using component_testing::Dictionary;
using component_testing::Directory;
using component_testing::ParentRef;
using component_testing::Protocol;
using component_testing::RealmBuilder;
using component_testing::RealmRoot;
using component_testing::Route;
-using component_testing::Dictionary;
-
constexpr auto kDartRunnerEnvironment = "dart_runner_env";

gbbosak · 2025-03-28T19:15:05Z

Hmm, unfortunately the patch is corrupted and doesn't apply.

gbbosak · 2025-03-28T19:15:28Z

How can I install et?

...rt_runner/tests/startup_integration_test/dart_jit_runner/dart-jit-runner-integration-test.cc

...rt_runner/tests/startup_integration_test/dart_aot_runner/dart-aot-runner-integration-test.cc

…instead

engine/src/flutter/shell/platform/fuchsia/dart_runner/meta/common.shard.cml

…builder

…der so must use the shards

gbbosak · 2025-03-29T21:27:59Z

Tests failed -- once all tests complete I think someone with permissions needs to hit retry on the failed tests and merge it (I have no merge or retry permission, and I think updating the branch to retry gets rid of the review state).

chinmaygarde · 2025-03-31T17:51:17Z

updating the branch to retry

Updating the branch should be fine with a rebase or merge commit should be fine FYI. I just did it and will submit this patch is there are no issues. Thanks!

gbbosak · 2025-03-31T19:18:34Z

Can you re-run the Google Testing check? I believe you should be able to re-run just that one test through the "checks" tab, but I can't do it as I'm not on the Flutter team.

auto-submit · 2025-03-31T19:21:11Z

autosubmit label was removed for flutter/flutter/162780, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

gbbosak · 2025-03-31T19:22:38Z

I can't merge this, I think you have to merge it because I'm not on the team.

…nd use dictionaries instead (flutter/flutter#162780)

Roll Flutter from 05b5e7910544 to a0b1b3253416 (37 revisions) flutter/flutter@05b5e79...a0b1b32 2025-04-01 [email protected] Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342) 2025-04-01 [email protected] Trim any text before osascript JSON response (flutter/flutter#166296) 2025-04-01 [email protected] [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654) 2025-04-01 [email protected] Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437) 2025-04-01 [email protected] Update TESTOWNERS username (flutter/flutter#166191) 2025-04-01 [email protected] Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329) 2025-04-01 [email protected] Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321) 2025-04-01 [email protected] [tool] Improve using project files in build targets (flutter/flutter#166211) 2025-04-01 [email protected] Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037) 2025-04-01 [email protected] [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156) 2025-04-01 [email protected] Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301) 2025-04-01 [email protected] [Impeller] small cpu perf for text contents. (flutter/flutter#166199) 2025-04-01 [email protected] [android_engine_test] disable old HC mode tests. (flutter/flutter#166293) 2025-04-01 [email protected] [impeller] fixes diagonal antialiased lines (flutter/flutter#166298) 2025-04-01 [email protected] Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299) 2025-03-31 [email protected] [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165) 2025-03-31 [email protected] [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164) 2025-03-31 [email protected] Move `.cxx` directory out of `android/app` (flutter/flutter#166277) 2025-03-31 [email protected] Fix typo in carousel.dart (flutter/flutter#164727) 2025-03-31 [email protected] Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283) 2025-03-31 [email protected] Public nodes needing paint or layout (flutter/flutter#166148) 2025-03-31 [email protected] [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690) 2025-03-31 [email protected] [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884) 2025-03-31 [email protected] [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780) 2025-03-31 [email protected] Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926) 2025-03-31 [email protected] Feat: Add brightnessOf method for theme (flutter/flutter#163733) 2025-03-31 [email protected] Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964) 2025-03-31 [email protected] [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260) 2025-03-31 [email protected] [Impeller] remove validation warning ignores. (flutter/flutter#166205) 2025-03-31 [email protected] [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937) 2025-03-31 [email protected] Fix CODEOWNERS for the iOS review team (flutter/flutter#166178) 2025-03-31 [email protected] Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252) 2025-03-31 [email protected] Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251) 2025-03-31 [email protected] Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244) 2025-03-31 [email protected] Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236) 2025-03-31 [email protected] [Impeller] fix min filter for GL external textures. (flutter/flutter#166224) 2025-03-31 [email protected] Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

…r#8985) Roll Flutter from 05b5e7910544 to a0b1b3253416 (37 revisions) flutter/flutter@05b5e79...a0b1b32 2025-04-01 [email protected] Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342) 2025-04-01 [email protected] Trim any text before osascript JSON response (flutter/flutter#166296) 2025-04-01 [email protected] [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654) 2025-04-01 [email protected] Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437) 2025-04-01 [email protected] Update TESTOWNERS username (flutter/flutter#166191) 2025-04-01 [email protected] Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329) 2025-04-01 [email protected] Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321) 2025-04-01 [email protected] [tool] Improve using project files in build targets (flutter/flutter#166211) 2025-04-01 [email protected] Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037) 2025-04-01 [email protected] [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156) 2025-04-01 [email protected] Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301) 2025-04-01 [email protected] [Impeller] small cpu perf for text contents. (flutter/flutter#166199) 2025-04-01 [email protected] [android_engine_test] disable old HC mode tests. (flutter/flutter#166293) 2025-04-01 [email protected] [impeller] fixes diagonal antialiased lines (flutter/flutter#166298) 2025-04-01 [email protected] Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299) 2025-03-31 [email protected] [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165) 2025-03-31 [email protected] [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164) 2025-03-31 [email protected] Move `.cxx` directory out of `android/app` (flutter/flutter#166277) 2025-03-31 [email protected] Fix typo in carousel.dart (flutter/flutter#164727) 2025-03-31 [email protected] Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283) 2025-03-31 [email protected] Public nodes needing paint or layout (flutter/flutter#166148) 2025-03-31 [email protected] [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690) 2025-03-31 [email protected] [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884) 2025-03-31 [email protected] [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780) 2025-03-31 [email protected] Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926) 2025-03-31 [email protected] Feat: Add brightnessOf method for theme (flutter/flutter#163733) 2025-03-31 [email protected] Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964) 2025-03-31 [email protected] [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260) 2025-03-31 [email protected] [Impeller] remove validation warning ignores. (flutter/flutter#166205) 2025-03-31 [email protected] [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937) 2025-03-31 [email protected] Fix CODEOWNERS for the iOS review team (flutter/flutter#166178) 2025-03-31 [email protected] Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252) 2025-03-31 [email protected] Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251) 2025-03-31 [email protected] Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244) 2025-03-31 [email protected] Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236) 2025-03-31 [email protected] [Impeller] fix min filter for GL external textures. (flutter/flutter#166224) 2025-03-31 [email protected] Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine repository. See also e: labels. platform-fuchsia Fuchsia code specifically labels Feb 6, 2025

miguelfrde self-requested a review March 26, 2025 20:41

gbbosak force-pushed the master branch from 35865eb to 7416121 Compare March 26, 2025 20:47

gbbosak force-pushed the master branch from 7416121 to 3c456a8 Compare March 28, 2025 16:44

zijiehe-google-com reviewed Mar 28, 2025

View reviewed changes

...rt_runner/tests/startup_integration_test/dart_jit_runner/dart-jit-runner-integration-test.cc Outdated Show resolved Hide resolved

...rt_runner/tests/startup_integration_test/dart_aot_runner/dart-aot-runner-integration-test.cc Outdated Show resolved Hide resolved

zijiehe-google-com reviewed Mar 28, 2025

View reviewed changes

...rt_runner/tests/startup_integration_test/dart_aot_runner/dart-aot-runner-integration-test.cc Outdated Show resolved Hide resolved

Remove explicit LogSink and InspectSink routing and use dictionaries …

4c6bf61

…instead

gbbosak force-pushed the master branch from 3c456a8 to 4c6bf61 Compare March 28, 2025 19:34

zijiehe-google-com enabled auto-merge March 28, 2025 19:39

miguelfrde requested changes Mar 29, 2025

View reviewed changes

engine/src/flutter/shell/platform/fuchsia/dart_runner/meta/common.shard.cml Show resolved Hide resolved

Use explicit routes where possible, otherwise add TODOs due to realm_…

9c77c91

…builder

auto-merge was automatically disabled March 29, 2025 20:24
Head branch was pushed to by a user without write access

Can't update this unfortunately, everything in Flutter uses RealmBuil…

3240f9c

…der so must use the shards

miguelfrde approved these changes Mar 29, 2025

View reviewed changes

Merge branch 'master' into master

c8d2186

chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2025

chinmaygarde approved these changes Mar 31, 2025

View reviewed changes

zanderso approved these changes Mar 31, 2025

View reviewed changes

zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2025

auto-submit bot added this pull request to the merge queue Mar 31, 2025

Merged via the queue into flutter:master with commit 8e3fee8 Mar 31, 2025
172 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2025

engine-flutter-autoroll mentioned this pull request Apr 1, 2025

Roll Flutter from 1d954f4e96bd to 70cd54c3fd13 (259 revisions) flutter/packages#8973

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

8e3fee85a [fuchsia] Remove explicit LogSink and InspectSink routing a…

ff4a0bc

…nd use dictionaries instead (flutter/flutter#162780)

engine-flutter-autoroll mentioned this pull request Apr 1, 2025

Roll Flutter from 1d954f4e96bd to 0befaaafc952 (260 revisions) flutter/packages#8974

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

8e3fee85a [fuchsia] Remove explicit LogSink and InspectSink routing a…

89ed44a

…nd use dictionaries instead (flutter/flutter#162780)

engine-flutter-autoroll mentioned this pull request Apr 1, 2025

Roll Flutter from 1d954f4e96bd to dbef1314b186 (261 revisions) flutter/packages#8976

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

8e3fee85a [fuchsia] Remove explicit LogSink and InspectSink routing a…

9225249

…nd use dictionaries instead (flutter/flutter#162780)

engine-flutter-autoroll mentioned this pull request Apr 1, 2025

Roll Flutter from 1d954f4e96bd to a0b1b3253416 (262 revisions) flutter/packages#8977

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

8e3fee85a [fuchsia] Remove explicit LogSink and InspectSink routing a…

b90935f

…nd use dictionaries instead (flutter/flutter#162780)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 2, 2025

8e3fee85a [fuchsia] Remove explicit LogSink and InspectSink routing a…

c55af62

…nd use dictionaries instead (flutter/flutter#162780)

engine-flutter-autoroll mentioned this pull request Apr 2, 2025

Roll Flutter from 05b5e7910544 to a0b1b3253416 (37 revisions) flutter/packages#8983

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 2, 2025

8e3fee85a [fuchsia] Remove explicit LogSink and InspectSink routing a…

9ffd628

…nd use dictionaries instead (flutter/flutter#162780)

engine-flutter-autoroll mentioned this pull request Apr 2, 2025

Roll Flutter from 05b5e7910544 to a0b1b3253416 (37 revisions) flutter/packages#8985

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead #162780

[fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead #162780

gbbosak commented Feb 6, 2025 •

edited

Loading

gbbosak commented Feb 6, 2025

gbbosak commented Feb 6, 2025

chinmaygarde commented Feb 24, 2025

gbbosak commented Feb 24, 2025

gbbosak commented Feb 26, 2025

chinmaygarde commented Mar 10, 2025

gbbosak commented Mar 10, 2025

gbbosak commented Mar 26, 2025

gbbosak commented Mar 28, 2025

zijiehe-google-com commented Mar 28, 2025

gbbosak commented Mar 28, 2025

gbbosak commented Mar 28, 2025

gbbosak commented Mar 29, 2025

chinmaygarde commented Mar 31, 2025

gbbosak commented Mar 31, 2025

auto-submit bot commented Mar 31, 2025

gbbosak commented Mar 31, 2025

[fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead #162780

[fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead #162780

Conversation

gbbosak commented Feb 6, 2025 • edited Loading

Pre-launch Checklist

gbbosak commented Feb 6, 2025

gbbosak commented Feb 6, 2025

chinmaygarde commented Feb 24, 2025

gbbosak commented Feb 24, 2025

gbbosak commented Feb 26, 2025

chinmaygarde commented Mar 10, 2025

gbbosak commented Mar 10, 2025

gbbosak commented Mar 26, 2025

gbbosak commented Mar 28, 2025

zijiehe-google-com commented Mar 28, 2025

gbbosak commented Mar 28, 2025

gbbosak commented Mar 28, 2025

gbbosak commented Mar 29, 2025

chinmaygarde commented Mar 31, 2025

gbbosak commented Mar 31, 2025

auto-submit bot commented Mar 31, 2025

gbbosak commented Mar 31, 2025

gbbosak commented Feb 6, 2025 •

edited

Loading