Skip to content

Remove outdated ignores #162773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Feb 6, 2025
Merged

Remove outdated ignores #162773

auto-submit merged 4 commits into from
Feb 6, 2025

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Feb 5, 2025 •
edited
Loading

Powered by the new and amazing unnecessary_ignore lint.

We're not enabling this lint by default because being able to temporarily use ignores that don't ignore anything is a powerful tool to enable migrations. We should turn this lint on locally periodically, though, and clean up all outdated ignores.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository f: routes Navigator, Router, and related APIs. platform-web Web applications specifically labels Feb 5, 2025
@goderbauer
Copy link
Member Author

goderbauer commented Feb 5, 2025

@pq The new lint and its auto fix work great. Thank you! There were four instances of the lint that the auto fix refused to fix (see commit "manual fixes"). They were of course easy to fix manually.

@pq
Copy link
Contributor

pq commented Feb 5, 2025

Amazing. So great to see this in use!

@Piinks Piinks added the c: tech-debt Technical debt, code quality, testing, etc. label Feb 6, 2025
Piinks
Piinks approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the smell of tech debt clean ups in the morning. 😆
LGTM!

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 6, 2025
Merged via the queue into flutter:master with commit c783ce2 Feb 6, 2025
177 of 178 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
cad379d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
cc3117e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
de3bea4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
7cb2bc0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
af96f4f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
a3d82ba
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
1346fb2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
90b74f8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
9b95f47
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
a148a3a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
4fafa7e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
81efcd4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
5bba0ee
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
3e1e0e5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
eae2854
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
2d4e2b5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
7cfb0a8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
c68a696
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
9acdb8a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
c783ce2 Remove outdated ignores (flutter/flutter#162773)
edd3b69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@yjbanov yjbanov Awaiting requested review from yjbanov

@justinmc justinmc Awaiting requested review from justinmc

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: tech-debt Technical debt, code quality, testing, etc. engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goderbauer @pq @Piinks