-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Roll customer_testing from b4cc09721 to 6a6d0963c (3 commits) #162763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like this is the first roll since this pin was introduced in flutter#162041 / flutter#162048. For fun and the possible convenience of the next person doing one of these, here's the command I used to generate the log below: $ git log --oneline --no-decorate --format='%cs %aE %s' b4cc097.. \ | perl -pe 's,#,flutter/tests#,g' flutter/tests@b4cc097...6a6d096 2025-02-05 [email protected] Re-land "Update Zulip tests and re-enable (flutter/tests#441)" (flutter/tests#446) 2025-01-30 [email protected] Update contact for pkg:animations (flutter/tests#447) 2025-01-24 [email protected] Add a PR template that explains updating `tests.version` (flutter/tests#445)
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
This pulls in the 4 commits below: flutter/tests@8be7209...c9cbc60 2025-04-24 [email protected] Bump Zulip pin to update sliver z-order tests (flutter/tests#456) 2025-04-17 [email protected] Revert "Disable flutter_devtools.test" (flutter/tests#455) 2025-04-15 [email protected] Update zulip hash to pick up version that can be analyzed cleanly. (flutter/tests#453) 2025-04-15 [email protected] Disable flutter_devtools.test (flutter/tests#452) (using the command from 5ce5251 / flutter#162763 to make the log). The two changes from 2025-04-15 had been here since db68c95 (flutter#16721), but then it looks like they were accidentally reverted earlier today by 417f47f (flutter#165596). The change from 04-17 doesn't appear to have made it here to flutter/flutter yet. The latest change just went into flutter/tests today and is why I'm making this PR.
This pulls in the 4 commits below: flutter/tests@8be7209...c9cbc60 2025-04-24 [email protected] Bump Zulip pin to update sliver z-order tests (flutter/tests#456) 2025-04-17 [email protected] Revert "Disable flutter_devtools.test" (flutter/tests#455) 2025-04-15 [email protected] Update zulip hash to pick up version that can be analyzed cleanly. (flutter/tests#453) 2025-04-15 [email protected] Disable flutter_devtools.test (flutter/tests#452) (using the command from 5ce5251 / #162763 to make the log). The two changes from 2025-04-15 had been here since db68c95 (#16721), but then it looks like they were accidentally reverted earlier today by 417f47f (#165596). The change from 04-17 doesn't appear to have made it here to flutter/flutter yet. The latest change just went into flutter/tests today and is why I'm making this PR. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This pulls in the 3 commits below: flutter/tests@7f55026...9a7ff44 2025-06-11 [email protected] Bump Zulip pin to update some tests that hard-code route animation duration (flutter/tests#460) 2025-06-10 [email protected] Bump patrol tests to b8bcebf96ff13e37fdc5474804d68e2352e472a4 (flutter/tests#451) 2025-06-02 [email protected] Re-enable DevTools tests (flutter/tests#459) (using the command from 5ce5251 / flutter#162763 to make the log). The latest change just went into flutter/tests yesterday and is why I'm making this PR.
…7754) This pulls in the 4 commits below: flutter/tests@8be7209...c9cbc60 2025-04-24 [email protected] Bump Zulip pin to update sliver z-order tests (flutter/tests#456) 2025-04-17 [email protected] Revert "Disable flutter_devtools.test" (flutter/tests#455) 2025-04-15 [email protected] Update zulip hash to pick up version that can be analyzed cleanly. (flutter/tests#453) 2025-04-15 [email protected] Disable flutter_devtools.test (flutter/tests#452) (using the command from 5ce5251 / flutter#162763 to make the log). The two changes from 2025-04-15 had been here since db68c95 (flutter#16721), but then it looks like they were accidentally reverted earlier today by 417f47f (flutter#165596). The change from 04-17 doesn't appear to have made it here to flutter/flutter yet. The latest change just went into flutter/tests today and is why I'm making this PR. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Looks like this is the first roll since this pin was introduced in #162041 / #162048.
For fun and the possible convenience of the next person doing one of these, here's the command I used to generate the log below:
flutter/tests@b4cc097...6a6d096
2025-02-05 [email protected] Re-land "Update Zulip tests and re-enable (flutter/tests#441)" (flutter/tests#446)
2025-01-30 [email protected] Update contact for pkg:animations (flutter/tests#447)
2025-01-24 [email protected] Add a PR template that explains updating
tests.version(flutter/tests#445)Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.