Skip to content

Revert web_benchmarks back to default optimization level (-O4) #162762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Feb 5, 2025
Merged

Revert web_benchmarks back to default optimization level (-O4) #162762

auto-submit merged 1 commit into from
Feb 5, 2025

Conversation

@eyebrowsoffire
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire commented Feb 5, 2025

As per #162620.

We got the data we were looking for with the experiment. Return the benchmarks to the default optimization level.

yjbanov
yjbanov approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 5, 2025
@eyebrowsoffire eyebrowsoffire mentioned this pull request Feb 5, 2025
Closed
3 tasks
Merged via the queue into flutter:master with commit 093485d Feb 5, 2025
148 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
9041403 
…4`) (flutter/flutter#162762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
a39b2bc 
…4`) (flutter/flutter#162762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
a62ca48 
…4`) (flutter/flutter#162762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
80b75a6 
…4`) (flutter/flutter#162762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
5306b37 
…4`) (flutter/flutter#162762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
dc8076f 
…4`) (flutter/flutter#162762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
8bfeaad 
…4`) (flutter/flutter#162762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
da7a828 
…4`) (flutter/flutter#162762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
5da0ad8 
…4`) (flutter/flutter#162762)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
1c1c018 
…4`) (flutter/flutter#162762)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
7547617 
…4`) (flutter/flutter#162762)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
7d95c0a 
…4`) (flutter/flutter#162762)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
0642dfb 
…4`) (flutter/flutter#162762)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
fcf10bc 
…4`) (flutter/flutter#162762)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
836e697 
…4`) (flutter/flutter#162762)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
ecfd444 
…4`) (flutter/flutter#162762)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
7bced80 
…4`) (flutter/flutter#162762)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
b05ac71 
…4`) (flutter/flutter#162762)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
074abc1 
…4`) (flutter/flutter#162762)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
515e606 
…4`) (flutter/flutter#162762)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
ee67500 
…4`) (flutter/flutter#162762)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
27efc3f 
…4`) (flutter/flutter#162762)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
f553054 
…4`) (flutter/flutter#162762)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
093485d Revert web_benchmarks back to default optimization level (`-O…
0ce8a99 
…4`) (flutter/flutter#162762)
@eyebrowsoffire eyebrowsoffire deleted the web_benchmarks_O4 branch December 12, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eyebrowsoffire @yjbanov