Rename chip's border attribute to shape for consistency. #16276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Apr 5, 2018
Contributor
|
|
gspencergoog
force-pushed
the
rename_border
branch
from
bf3573e to
9e8280a
Compare
gspencergoog
force-pushed
the
rename_border
branch
from
9e8280a to
dbf6ea6
Compare
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
This renames the chip's border attribute to 'shape' so that it is consistent with the other places where we supply a ShapeBorder. This is a breaking change, but a very small one: the border attribute was introduced only a few months ago, and is not widely used.
teriyakijack
added a commit
to teriyakijack/flutter
that referenced
this pull request
Jul 17, 2018
* 'master' of https://github.com/flutter/flutter: Roll engine to aa9ce70 (flutter#16289) Rename chip's border attribute to shape for consistency. (flutter#16276) Added BeveledRectangleBorder ShapeBorder (flutter#16279) Roll engine to version be07059 (flutter#16264) Make Podfiles work with Cocoapods 1.5.0 (flutter#16273) Updated appearance of filled TextFields - added UnderlineInputBorder.borderRadius (flutter#16272) Handle whitespace in entry values in the AAPT badging parser (flutter#16245) a11y adjustments for the Bottom app bar demo (flutter#16238) Play butterfly video from asset instead of network (flutter#16269)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the chip's border attribute to 'shape' so that it is consistent with the other places where we supply a ShapeBorder.
This is a breaking change, but a very small one: the border attribute was introduced only a few months ago, and is not widely used.