Skip to content

Wait until all scripts are loaded in the page before running main for the DDC library bundle format #162707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
srujzs merged 4 commits into from
Feb 5, 2025
Merged

Wait until all scripts are loaded in the page before running main for the DDC library bundle format #162707

srujzs merged 4 commits into from
Feb 5, 2025

Conversation

@srujzs
Copy link
Contributor

@srujzs srujzs commented Feb 5, 2025 •
edited
Loading

#162567

  • Uses the bootstrapScript field in loadConfig to run a script after all scripts have loaded.
  • This script just calls a callback that is set up beforehand and calls main.
  • Modifies the callback that calls dartDevEmbedder.runMain to wait until both DWDS called main and all scripts have loaded.
  • Unskips hot reload tests now that the race condition should no longer exist.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@srujzs srujzs requested a review from nshahan February 5, 2025 00:13
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 5, 2025
@srujzs
Copy link
Contributor Author

srujzs commented Feb 5, 2025

cc @Markzipan (looks like I can't add you as a reviewer directly)

@srujzs srujzs enabled auto-merge February 5, 2025 00:41
@srujzs srujzs added this pull request to the merge queue Feb 5, 2025
Merged via the queue into flutter:master with commit d3c96c6 Feb 5, 2025
137 of 138 checks passed
@srujzs srujzs deleted the onloadend branch February 5, 2025 02:06
@matanlurey matanlurey mentioned this pull request Feb 5, 2025
Open
@srujzs srujzs mentioned this pull request Feb 5, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
cd534cb 
…main for the DDC library bundle format (flutter/flutter#162707)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
39b1286 
…main for the DDC library bundle format (flutter/flutter#162707)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
4a0481f 
…main for the DDC library bundle format (flutter/flutter#162707)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
a30a78a 
…main for the DDC library bundle format (flutter/flutter#162707)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
03ecfce 
…main for the DDC library bundle format (flutter/flutter#162707)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
2aa1d8e 
…main for the DDC library bundle format (flutter/flutter#162707)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
5796291 
…main for the DDC library bundle format (flutter/flutter#162707)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
ccadab3 
…main for the DDC library bundle format (flutter/flutter#162707)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
15e7396 
…main for the DDC library bundle format (flutter/flutter#162707)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
e232df4 
…main for the DDC library bundle format (flutter/flutter#162707)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
7889fcc 
…main for the DDC library bundle format (flutter/flutter#162707)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
fc005b3 
…main for the DDC library bundle format (flutter/flutter#162707)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
0da42c7 
…main for the DDC library bundle format (flutter/flutter#162707)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
0ea3c8c 
…main for the DDC library bundle format (flutter/flutter#162707)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
d7e88d8 
…main for the DDC library bundle format (flutter/flutter#162707)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
e963c9a 
…main for the DDC library bundle format (flutter/flutter#162707)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
7389677 
…main for the DDC library bundle format (flutter/flutter#162707)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
60b30d7 
…main for the DDC library bundle format (flutter/flutter#162707)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
237521b 
…main for the DDC library bundle format (flutter/flutter#162707)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
d48cd9e 
…main for the DDC library bundle format (flutter/flutter#162707)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
f0c8bd0 
…main for the DDC library bundle format (flutter/flutter#162707)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
0b7f0d6 
…main for the DDC library bundle format (flutter/flutter#162707)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
4545bf2 
…main for the DDC library bundle format (flutter/flutter#162707)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
172065c 
…main for the DDC library bundle format (flutter/flutter#162707)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
3c512f1 
…main for the DDC library bundle format (flutter/flutter#162707)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
1bf2541 
…main for the DDC library bundle format (flutter/flutter#162707)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
d3c96c6 Wait until all scripts are loaded in the page before running …
f586608 
…main for the DDC library bundle format (flutter/flutter#162707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nshahan nshahan nshahan approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@srujzs @nshahan