Skip to content

Skip web hot reload tests that test execution for all platforms for now #162682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
srujzs merged 1 commit into from
Feb 4, 2025
Merged

Skip web hot reload tests that test execution for all platforms for now #162682

srujzs merged 1 commit into from
Feb 4, 2025

Conversation

@srujzs
Copy link
Contributor

@srujzs srujzs commented Feb 4, 2025

#162567

There's a general timing error that may occur when loading scripts, where main might be run before the scripts are done loading, leading to a crash. These tests test that output is being printed to stdout, and wait forever for that, leading to timeouts. This is flaky, so the race condition may or may not occur.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

Example of a timeout: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_tool_tests/50762/overview

@srujzs
Skip web hot reload tests that test execution for all platforms for now
9c4bf35 
flutter#162567

There's a general timing error that may occur when loading scripts,
where main might be run before the scripts are done loading, leading
to a crash. These tests test that output is being printed to stdout,
and wait forever for that, leading to timeouts. This is flaky, so the
race condition may or may not occur.
@srujzs srujzs requested a review from nshahan February 4, 2025 18:19
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 4, 2025
nshahan
nshahan approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'm somewhat happy that this is a problem across all operating systems. That helps support our theory and should be easier to solve correctly.

@srujzs srujzs enabled auto-merge February 4, 2025 19:03
@srujzs srujzs added this pull request to the merge queue Feb 4, 2025
auto-merge was automatically disabled February 4, 2025 19:35

Pull Request is not mergeable

@srujzs srujzs removed this pull request from the merge queue due to a manual request Feb 4, 2025
@srujzs srujzs added this pull request to the merge queue Feb 4, 2025
Merged via the queue into flutter:master with commit f5e8fc3 Feb 4, 2025
138 checks passed
@srujzs srujzs deleted the skiptests branch February 4, 2025 20:43
@matanlurey matanlurey mentioned this pull request Feb 5, 2025
Open
@srujzs srujzs mentioned this pull request Feb 5, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
85a4327 
…ms for now (flutter/flutter#162682)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
41d53d1 
…ms for now (flutter/flutter#162682)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
12351d0 
…ms for now (flutter/flutter#162682)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
c79f3e6 
…ms for now (flutter/flutter#162682)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
64c8653 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
e62f9ca 
…ms for now (flutter/flutter#162682)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
c71f4e9 
…ms for now (flutter/flutter#162682)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
ba716ec 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
3d22b44 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
60f280f 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
5f67d53 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
c92f3ce 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
669d775 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
9b52231 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
041ff4d 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
4d9bfd3 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
1d8288c 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
0074114 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
7d96ec1 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
d6ec59e 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
7aba6b7 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
5ad98ec 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
588a1ac 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
8f75c51 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
5169852 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
4b71952 
…ms for now (flutter/flutter#162682)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
f5e8fc3 Skip web hot reload tests that test execution for all platfor…
8ad4a9f 
…ms for now (flutter/flutter#162682)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nshahan nshahan nshahan approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@srujzs @nshahan