Skip to content

delete references to Usage in config_test.dart #162648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Feb 4, 2025
Merged

delete references to Usage in config_test.dart #162648

auto-submit merged 1 commit into from
Feb 4, 2025

Conversation

@andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented Feb 4, 2025

Fixes #162413. Toward #150575

Pre-launch checklist

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 4, 2025
@andrewkolos andrewkolos marked this pull request as ready for review February 4, 2025 00:29
@andrewkolos andrewkolos requested a review from bkonyi February 4, 2025 00:29
andrewkolos
andrewkolos commented Feb 4, 2025
View reviewed changes
packages/flutter_tools/test/commands.shard/hermetic/config_test.dart
'${allFeatures.where((Feature e) => e.configSetting != null).map((Feature e) => ' ${e.configSetting}: (Not set)').join('\n')}'
'\n\n',
);
}, overrides: <Type, Generator>{Usage: () => testUsage});
Copy link
Contributor Author

@andrewkolos andrewkolos Feb 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this override was ever necessary since we don't make assertions against testUsage in this test (testUsingContext already inserts a null/no-op implementation for Usage and Analytics). TL;DR: we don't need to replace this with an Analytics override.

@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 4, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 4, 2025
Merged via the queue into flutter:master with commit 53a2171 Feb 4, 2025
139 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 4, 2025
@andrewkolos andrewkolos mentioned this pull request Feb 5, 2025
Open
3 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
871836c 
…tter#162648)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
6f42564 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
a619159 
…tter#162648)
This was referenced Feb 5, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
2eb818c 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
5165d3f 
…tter#162648)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
de706a7 
…tter#162648)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
e01ff69 
…tter#162648)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
44b4efc 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
f594ea3 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
620400d 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
0611023 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
2e05519 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
3b03365 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
fd6cf17 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
85f0e5d 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
9107117 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
942e86f 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
68c2b95 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
ca301f3 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
05fffa1 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
6f84938 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
9c2f02b 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
74ab4cd 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
94ad8dc 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
e9bd83d 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
017b362 
…tter#162648)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
53a2171 delete references to Usage in config_test.dart (flutter/flu…
71b8763 
…tter#162648)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests in test/commands.shard/hermetic/config_test.dart make assertions against globals.analytics without actually injecting a value

2 participants

@andrewkolos @bkonyi