Skip to content

delete Usage in doctor tests #162646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Feb 4, 2025
Merged

delete Usage in doctor tests #162646

auto-submit merged 1 commit into from
Feb 4, 2025

Conversation

@andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented Feb 4, 2025 •
edited
Loading

Tiny delete op. Toward #150575

Pre-launch checklist

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 4, 2025
andrewkolos
andrewkolos commented Feb 4, 2025
View reviewed changes
packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart
);
});

group('doctor usage params', () {
Copy link
Contributor Author

@andrewkolos andrewkolos Feb 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These deleted scenarios are covered in the GA4 world later on in the file:

flutter/packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart

Lines 812 to 813 in c3b92f7

group('Doctor events with unified_analytics', () {
late FakeAnalytics fakeAnalytics;

@andrewkolos andrewkolos marked this pull request as ready for review February 4, 2025 00:25
@andrewkolos andrewkolos requested a review from bkonyi February 4, 2025 00:25
andrewkolos
andrewkolos commented Feb 4, 2025
View reviewed changes
packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart
Comment on lines +490 to +496
testUsingContext('without PII has same text and PII-stripped text', () async {
final Doctor fakeDoctor = FakePassingDoctor(logger);
final DoctorText doctorText = DoctorText(logger, doctor: fakeDoctor);
final String piiText = await doctorText.text;
expect(piiText, isNotEmpty);
expect(piiText, await doctorText.piiStrippedText);
});
Copy link
Contributor Author

@andrewkolos andrewkolos Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just removing the Usage override and reformatting.

@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 4, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 4, 2025
Merged via the queue into flutter:master with commit db9591c Feb 4, 2025
139 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 4, 2025
@andrewkolos andrewkolos mentioned this pull request Feb 5, 2025
Open
3 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
2dbfa50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
b19d2a9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
621a0da
This was referenced Feb 5, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
3c80c0e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
d3e1c71
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
51d2de5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
752a743
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
03f1e0b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
0636ad7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
83e9978
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
a49749c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
229bc53
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
fba5fef
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
6244f3d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
fd1dfad
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
4bf989d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
7e58478
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
3b823b9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
401615e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
6908a80
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
2d7f420
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
b1c2bca
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
ecc843f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
bad99af
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
8298ac5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
4ca1b16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
db9591c delete Usage in doctor tests (flutter/flutter#162646)
d5fc3c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewkolos @bkonyi