-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Remove --verbose from devicelab task executions.
#162644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove --verbose from devicelab task executions.
#162644
Conversation
|
Looks like it's "green", though who knows for post-submit. |
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
do you remember logs?
| section('Build release AAR'); | ||
|
|
||
| await inDirectory(projectDir, () async { | ||
| await flutter('build', options: <String>['aar', '--verbose']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might consider keeping this one. If an aar fails to build then I think verbose logs might be required to know why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect if it's important we can add it back 🤷🏼
reidbaker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider getting an ios approval.
cbracken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
reason for revert: At least one post-submit test depends on the output of |
This reverts commit fdeb7b9.
#162853) <!-- start_original_pr_link --> Reverts: #162644 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: matanlurey <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: At least one post-submit test depends on the output of `--verbose`. <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: matanlurey <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {cbracken, reidbaker, jonahwilliams} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: These can be useful, but were probably left in past the point where they are always useful: - #58018 - #56342 - #74080 ... compared to the cost of reading these logs with 1000s of lines of `stdout: ` output. Will ask the CI gods if any of this was load-bearing before sending out for review. <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
…lutter#162644)" (flutter#162853)" This reverts commit 7569fbf.

These can be useful, but were probably left in past the point where they are always useful:
... compared to the cost of reading these logs with 1000s of lines of
stdout:output.Will ask the CI gods if any of this was load-bearing before sending out for review.