-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Trigger display_cutout_rotation flutter driver test in ci. #162641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger display_cutout_rotation flutter driver test in ci. #162641
Conversation
|
FWIW I didnt "know/Think" it would work. I just thought it was safe to try that that set of flags was the best to match my intent. |
…match simplier emulator integration test
6368826 to
b7608fc
Compare
|
Cant reference adb, have asked in an internal chat and am considering just working on the recipies part first. |
dev/integration_tests/display_cutout_rotation/test_driver/display_cutout_test_test.dart
Outdated
Show resolved
Hide resolved
dev/integration_tests/display_cutout_rotation/test_driver/display_cutout_test_test.dart
Outdated
Show resolved
Hide resolved
|
Current state of the world. Test is running, driver is connected, first test fails to find the cutout. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8723559222876015297/+/u/run_android_defines_test/stdout |

Fixes #162615
Can test 2 different ways.
On a mac (or linux machine) with adb on the path (or android sdk set in ANDROID_HOME) and an emulator running (or physical device attached) that is api 30 or higher.
OR
Proof the test ran successfully
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8723125792202374961/+/u/run_android_defines_test/stdout
All checks passed https://github.com/flutter/flutter/pull/162641/checks?check_run_id=36991537539
Pre-launch Checklist
///).