[CP][Beta] Unblock drag gestures in CupertinoSheetRoute content #162629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchellGoodwin
added
framework
MitchellGoodwin
force-pushed
the
sheet-nested-scroll
branch
from
29eed4b to
07d2844
Compare
justinmc
approved these changes
Feb 3, 2025
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
CP LGTM 👍
I think this is an important one to cherry pick for "first impressions", since as mentioned above CupertinoSheet is highly requested and the bug fixed here is pretty visible. Cherry picking this will help us score a win.
Also, the code change is super minimal.
christopherfujino
added
the
autosubmit
auto-submit
bot
merged commit 8a61a07
into
flutter:flutter-3.29-candidate.0
159 checks passed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CupertinoSheetRoute is a new widget added in 3.29 as a part of #157568. #161696 fixes #161623, which was an issue where you could not put scrollable content in the sheet, which is expected behavior. CupertinoSheetRoute has been a highly requested widget so is expected to get a lot of use.
Impacted users: anyone using the CupertinoSheetRoute with scrollable content, which should be a common use case.
Impact description: not being able to scroll within the sheet would create a very bad first impression and leave the sheet unusable for a lot of apps.
Workaround: None.
Risk: This is a brand new widget, so none.
Test Coverage (Are you confident that your fix is well-tested by automated tests?): Yes, the fix has regression tests.
Validation Steps (What are the steps to validate that this fix works?): Create a CupertinoSheetRoute with scrollable content that expands past the size of the sheet. #161623 has a code sample.