Skip to content

Added opacity note to withValues docstring #162612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Feb 5, 2025
Merged

Added opacity note to withValues docstring #162612

auto-submit merged 4 commits into from
Feb 5, 2025

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Feb 3, 2025

issue: #162069

This expands the docstring for withValues() to help people who are migrating from the old nomenclature.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke requested a review from sethladd February 3, 2025 18:13
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Feb 3, 2025
@gaaclarke gaaclarke requested a review from Piinks February 3, 2025 18:14
@gaaclarke gaaclarke changed the title Added opacity note to withValues Added opacity note to withValues docstring Feb 3, 2025
sethladd
sethladd approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@sethladd sethladd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! lgtm

Piinks
Piinks approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 3, 2025

autosubmit label was removed for flutter/flutter/162612, because - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gaaclarke
Copy link
Member Author

gaaclarke commented Feb 3, 2025

Sorry, updated it a couple of times to pass analyzer. I got cocky and thought I had the 1 line of code right using the analyzer in my head. This version I actually double checked against the real analyzer.

@sethladd
Copy link
Contributor

sethladd commented Feb 3, 2025

That's amazing that we have analysis rules for code in dartdocs!

@gaaclarke
Copy link
Member Author

gaaclarke commented Feb 4, 2025

I'm going to submit this to the merge queue despite the infra failure to schedule tool_integration_tests. This change is only a comment so the only important check was the docstring analyzer when happens in "Linux Analyze" which passed.

I've reported the failure to the current gardener.

@gaaclarke gaaclarke enabled auto-merge February 4, 2025 22:37
@gaaclarke
Copy link
Member Author

gaaclarke commented Feb 4, 2025

That doesn't work now that we have the merge queue. I'll try merging master to flush out the failures. There doesn't look like a good alternative.

@gaaclarke gaaclarke disabled auto-merge February 4, 2025 22:38
@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 4, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 4, 2025
Merged via the queue into flutter:master with commit dea13f8 Feb 5, 2025
175 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
36595bb 
…#162612)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
c39d153 
…#162612)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
83405a6 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
66db7fa 
…#162612)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
12740a3 
…#162612)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
0587627 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
88ec38d 
…#162612)
This was referenced Feb 6, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
fe33e14 
…#162612)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
f28117d 
…#162612)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
45b9d9b 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
6236cb0 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
6a71993 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
109ac3b 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
9dd5414 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
3ecda27 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
d42008d 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
bcb3ba2 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
661560a 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
947bc16 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
d9b881b 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
474f47c 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
6a765eb 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
71febd0 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
fea66b3 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
4fe7b08 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
a5eee72 
…#162612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
dea13f8 Added opacity note to withValues docstring (flutter/flutter…
1eab4fb 
…#162612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethladd sethladd sethladd approved these changes

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaaclarke @sethladd @Piinks