Add remaining dart fixes for Color deprecations when importing painting.dart #162609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
Contributor
Author
|
FYI @bwilkerson for this somewhat workaround we found. :) |
gaaclarke
requested changes
Feb 3, 2025
guidezpl
reviewed
Feb 3, 2025
| - kind: 'rename' | ||
| newName: 'a' | ||
|
|
||
| - title: "Rename from 'red' to 'r'" |
Member
There was a problem hiding this comment.
beware of #161598, I introduced subtle bugs in a downstream library due to this
Member
There was a problem hiding this comment.
Yea, i don't think these should be rename fixes. Instead it should do something like this to avoid the introduction of bugs.
foo.red;
(foo.r * 255.0).round() & 0xff;
gaaclarke
previously requested changes
Feb 3, 2025
| - kind: 'rename' | ||
| newName: 'a' | ||
|
|
||
| - title: "Rename from 'red' to 'r'" |
Member
There was a problem hiding this comment.
Yea, i don't think these should be rename fixes. Instead it should do something like this to avoid the introduction of bugs.
foo.red;
(foo.r * 255.0).round() & 0xff;
Contributor
Author
|
So I think this is as close as I can get it.. There will be a missing parenthesis, but the analyzer will help with that. myColor.blue; // before
myColor.b * 255.0).round() & 0xff; // afterWe have several 'partial' fixes like this, since it gets folks most of the way there. Might double check with @bwilkerson though. I don't think any other data driven fix rules will get me that extra opening parenthesis. |
gaaclarke
reviewed
Feb 3, 2025
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
This is unfortunate, I'm interested in what @bwilkerson has to say. Maybe there is a better alternative.
@Piinks can you link to prior art here so I can see what we are doing elsewhere. As this PR is written it generates broken syntax. This is going to freak out formatters and leave people counting parenthesis.
I wonder if we should have proper dart syntax, but broken semantics. Something like:
color.blue;
// becomes
color._((color.b * 255.0).round() & 0xff);Both options are bad but at least this is valid syntax. People just have to delete the method call (color._). I honestly think no dart fix is better than a broken dart fix.
If we can't get it to fix the code correctly, maybe we can just get a custom message in the linter failure that tells people exactly what they need to write?
Contributor
|
Sorry for the long delay. I'm just catching up after a 3 day team training session. @gaaclarke is right that this is not how Also, for the change from But the real problem here is that data-driven fixes don't yet support the ability to change the return type. We should add that capability, but I don't know what your timeframe for this is so I don't know whether we can get it done in time. I added an issue to track the work and discuss the requirements: dart-lang/sdk#60079. Also, I'm interested to know what other cases people have run into where |
Contributor
Author
|
Reviving this PR that I clearly let fall through a crack... From @gaaclarke
I know we have done this several times, but we have several hundred fixes now. I have not been able to dig through them to find an example for you.
This would be nice, but dart fix can't do this. I can't grab the
I still think the partial fix is more helpful to the user trying to navigate this change. That being said, I've removed the partial fixes, and instead updated the deprecation lint to provide the correct code. I think this was the main friction point developers were sharing with us anyways, red != r, so folks trying to migrate based on the lint message were still broken and confused. From @bwilkerson
Done. Thanks for the feedback all. PTAL |
bwilkerson
approved these changes
Mar 13, 2025
gaaclarke
requested changes
Mar 13, 2025
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
The lint message changes look great, the value rename fix looks good. I'm not sure we want the alpha rename though. It has similar problems as the red, green, blue renames.
Comment on lines
130
to
138
| - title: "Rename from 'alpha' to 'a'" | ||
| date: 2024-09-10 | ||
| element: | ||
| uris: [ 'painting.dart' ] | ||
| method: 'alpha' | ||
| inClass: 'Color' | ||
| changes: | ||
| - kind: 'rename' | ||
| newName: 'a' |
Member
There was a problem hiding this comment.
I don't know if we want this change since it can lead to subtle bugs.
double foo = color.alpha / 255.0 becoming double foo = color.a / 255.0 will give very different results.
Contributor
Author
There was a problem hiding this comment.
Similar to r, g, b, I think the subtleties like this are what folks are really hurting over with this migration.
Should the alpha deprecation instead also have a better lint message?
Contributor
Author
There was a problem hiding this comment.
With a != alpha, what is the conversion then? The migration guide doesn't mention it.
Member
There was a problem hiding this comment.
The math is the same as the one for the [red, green, blue] color components. We mention it in this section of the migration guide: https://docs.flutter.dev/release/breaking-changes/wide-gamut-framework#access-color-components
gaaclarke
requested changes
Mar 14, 2025
| /// A value of 0.0 means this color is fully transparent. A value of 1.0 means | ||
| /// this color is fully opaque. | ||
| @Deprecated('Use .a.') | ||
| @Deprecated('Use (*.a * 255.0).round() & 0xff') |
Member
There was a problem hiding this comment.
You accidentally added this to opacity not alpha =)
Contributor
Author
There was a problem hiding this comment.
Whoops, must be Friday. 😅
gaaclarke
approved these changes
Mar 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2025
stuartmorgan-g
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 28, 2025
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) Manual roll requested by [email protected] flutter/flutter@b16430b...1d954f4 2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutter#165350) 2025-03-17 [email protected] Roll Skia from fa669e2e6d12 to 52130e5c3b34 (4 revisions) (flutter/flutter#165348) 2025-03-17 [email protected] `OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal` rebuilds. (flutter/flutter#165331) 2025-03-17 [email protected] [web][a11y]Delete _childContainerElement (flutter/flutter#163662) 2025-03-17 [email protected] Roll Skia from e45207898e60 to fa669e2e6d12 (8 revisions) (flutter/flutter#165342) 2025-03-17 [email protected] Add documentation for Java test filtering to plugins test document (flutter/flutter#165314) 2025-03-17 [email protected] Roll Fuchsia Linux SDK from SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313) 2025-03-17 [email protected] Roll Dart SDK from 9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310) 2025-03-17 [email protected] feat(Tooltip): replace the height parameter with constraints (flutter/flutter#163314) 2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation between states (flutter/flutter#165178) 2025-03-17 [email protected] Removes assumption that basis scalar and rounded_scalar match (flutter/flutter#165166) 2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8 to e45207898e60 (1 revision) (flutter/flutter#165300) 2025-03-17 [email protected] Refactor: Move sliders value indicator shape to seperate file (flutter/flutter#162858) 2025-03-17 [email protected] Roll Skia from 3931c31032c7 to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288) 2025-03-17 [email protected] Delete `docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258) 2025-03-16 [email protected] Roll Skia from 3413a02d6fc8 to 3931c31032c7 (1 revision) (flutter/flutter#165277) 2025-03-16 [email protected] Roll Fuchsia Linux SDK from LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275) 2025-03-16 [email protected] Roll Dart SDK from 067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269) 2025-03-16 [email protected] Roll Skia from f124daeb564d to 3413a02d6fc8 (1 revision) (flutter/flutter#165263) 2025-03-15 [email protected] Roll Dart SDK from 40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262) 2025-03-15 [email protected] Roll Fuchsia Linux SDK from efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252) 2025-03-15 [email protected] Roll Dart SDK from f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250) 2025-03-15 [email protected] Roll Dart SDK from 8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246) 2025-03-15 [email protected] Roll Skia from 4568e766ed0a to f124daeb564d (1 revision) (flutter/flutter#165245) 2025-03-15 [email protected] Revert "Prevent explicit roles from merging (#164732)" (flutter/flutter#165222) 2025-03-15 [email protected] Roll Skia from bac6e76abfc7 to 4568e766ed0a (5 revisions) (flutter/flutter#165241) 2025-03-14 [email protected] Roll Dart SDK from a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227) 2025-03-14 [email protected] Roll Skia from 98b6922deecf to bac6e76abfc7 (5 revisions) (flutter/flutter#165225) 2025-03-14 [email protected] Point ktlint AS docs to the `.editorconfig` that is actually used by ci, instead of making a copy in the README (flutter/flutter#165213) 2025-03-14 [email protected] Add remaining dart fixes for Color deprecations when importing painting.dart (flutter/flutter#162609) 2025-03-14 [email protected] [Accessibility] Add required semantics flags (flutter/flutter#164585) 2025-03-14 [email protected] Roll Skia from f4467ff38f1f to 98b6922deecf (5 revisions) (flutter/flutter#165215) 2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy to Kotlin (flutter/flutter#163148) 2025-03-14 [email protected] `OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034) 2025-03-14 [email protected] Remove redundant `useMaterial3: true` (flutter/flutter#163376) 2025-03-14 [email protected] Roll Packages from 9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197) 2025-03-14 [email protected] Changelog updates from 3.29.2 (flutter/flutter#165194) 2025-03-14 [email protected] Roll Dart SDK from 576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191) 2025-03-14 [email protected] Roll Dart SDK from ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180) 2025-03-14 [email protected] Roll Fuchsia Linux SDK from qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175) 2025-03-14 [email protected] [Impeller] Enable mediatek on API 34+. (flutter/flutter#165156) 2025-03-14 [email protected] Roll Dart SDK from cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159) 2025-03-13 [email protected] [FGP conversion] Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143) 2025-03-13 [email protected] Prevent explicit roles from merging (flutter/flutter#164732) ...
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Mar 31, 2025
…8922) Manual roll Flutter from b16430b to 1d954f4 (114 revisions) Manual roll requested by [email protected] flutter/flutter@b16430b...1d954f4 2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutter#165350) 2025-03-17 [email protected] Roll Skia from fa669e2e6d12 to 52130e5c3b34 (4 revisions) (flutter/flutter#165348) 2025-03-17 [email protected] `OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal` rebuilds. (flutter/flutter#165331) 2025-03-17 [email protected] [web][a11y]Delete _childContainerElement (flutter/flutter#163662) 2025-03-17 [email protected] Roll Skia from e45207898e60 to fa669e2e6d12 (8 revisions) (flutter/flutter#165342) 2025-03-17 [email protected] Add documentation for Java test filtering to plugins test document (flutter/flutter#165314) 2025-03-17 [email protected] Roll Fuchsia Linux SDK from SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313) 2025-03-17 [email protected] Roll Dart SDK from 9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310) 2025-03-17 [email protected] feat(Tooltip): replace the height parameter with constraints (flutter/flutter#163314) 2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation between states (flutter/flutter#165178) 2025-03-17 [email protected] Removes assumption that basis scalar and rounded_scalar match (flutter/flutter#165166) 2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8 to e45207898e60 (1 revision) (flutter/flutter#165300) 2025-03-17 [email protected] Refactor: Move sliders value indicator shape to seperate file (flutter/flutter#162858) 2025-03-17 [email protected] Roll Skia from 3931c31032c7 to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288) 2025-03-17 [email protected] Delete `docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258) 2025-03-16 [email protected] Roll Skia from 3413a02d6fc8 to 3931c31032c7 (1 revision) (flutter/flutter#165277) 2025-03-16 [email protected] Roll Fuchsia Linux SDK from LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275) 2025-03-16 [email protected] Roll Dart SDK from 067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269) 2025-03-16 [email protected] Roll Skia from f124daeb564d to 3413a02d6fc8 (1 revision) (flutter/flutter#165263) 2025-03-15 [email protected] Roll Dart SDK from 40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262) 2025-03-15 [email protected] Roll Fuchsia Linux SDK from efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252) 2025-03-15 [email protected] Roll Dart SDK from f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250) 2025-03-15 [email protected] Roll Dart SDK from 8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246) 2025-03-15 [email protected] Roll Skia from 4568e766ed0a to f124daeb564d (1 revision) (flutter/flutter#165245) 2025-03-15 [email protected] Revert "Prevent explicit roles from merging (#164732)" (flutter/flutter#165222) 2025-03-15 [email protected] Roll Skia from bac6e76abfc7 to 4568e766ed0a (5 revisions) (flutter/flutter#165241) 2025-03-14 [email protected] Roll Dart SDK from a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227) 2025-03-14 [email protected] Roll Skia from 98b6922deecf to bac6e76abfc7 (5 revisions) (flutter/flutter#165225) 2025-03-14 [email protected] Point ktlint AS docs to the `.editorconfig` that is actually used by ci, instead of making a copy in the README (flutter/flutter#165213) 2025-03-14 [email protected] Add remaining dart fixes for Color deprecations when importing painting.dart (flutter/flutter#162609) 2025-03-14 [email protected] [Accessibility] Add required semantics flags (flutter/flutter#164585) 2025-03-14 [email protected] Roll Skia from f4467ff38f1f to 98b6922deecf (5 revisions) (flutter/flutter#165215) 2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy to Kotlin (flutter/flutter#163148) 2025-03-14 [email protected] `OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034) 2025-03-14 [email protected] Remove redundant `useMaterial3: true` (flutter/flutter#163376) 2025-03-14 [email protected] Roll Packages from 9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197) 2025-03-14 [email protected] Changelog updates from 3.29.2 (flutter/flutter#165194) 2025-03-14 [email protected] Roll Dart SDK from 576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191) 2025-03-14 [email protected] Roll Dart SDK from ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180) 2025-03-14 [email protected] Roll Fuchsia Linux SDK from qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175) 2025-03-14 [email protected] [Impeller] Enable mediatek on API 34+. (flutter/flutter#165156) 2025-03-14 [email protected] Roll Dart SDK from cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159) 2025-03-13 [email protected] [FGP conversion] Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143) 2025-03-13 [email protected] Prevent explicit roles from merging (flutter/flutter#164732) ...
CodixNinja
pushed a commit
to CodixNinja/packages
that referenced
this pull request
May 15, 2025
… (#8922) Manual roll Flutter from b16430b2fd57 to 1d954f4e96bd (114 revisions) Manual roll requested by [email protected] flutter/flutter@b16430b...1d954f4 2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutter#165350) 2025-03-17 [email protected] Roll Skia from fa669e2e6d12 to 52130e5c3b34 (4 revisions) (flutter/flutter#165348) 2025-03-17 [email protected] `OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal` rebuilds. (flutter/flutter#165331) 2025-03-17 [email protected] [web][a11y]Delete _childContainerElement (flutter/flutter#163662) 2025-03-17 [email protected] Roll Skia from e45207898e60 to fa669e2e6d12 (8 revisions) (flutter/flutter#165342) 2025-03-17 [email protected] Add documentation for Java test filtering to plugins test document (flutter/flutter#165314) 2025-03-17 [email protected] Roll Fuchsia Linux SDK from SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313) 2025-03-17 [email protected] Roll Dart SDK from 9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310) 2025-03-17 [email protected] feat(Tooltip): replace the height parameter with constraints (flutter/flutter#163314) 2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation between states (flutter/flutter#165178) 2025-03-17 [email protected] Removes assumption that basis scalar and rounded_scalar match (flutter/flutter#165166) 2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8 to e45207898e60 (1 revision) (flutter/flutter#165300) 2025-03-17 [email protected] Refactor: Move sliders value indicator shape to seperate file (flutter/flutter#162858) 2025-03-17 [email protected] Roll Skia from 3931c31032c7 to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288) 2025-03-17 [email protected] Delete `docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258) 2025-03-16 [email protected] Roll Skia from 3413a02d6fc8 to 3931c31032c7 (1 revision) (flutter/flutter#165277) 2025-03-16 [email protected] Roll Fuchsia Linux SDK from LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275) 2025-03-16 [email protected] Roll Dart SDK from 067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269) 2025-03-16 [email protected] Roll Skia from f124daeb564d to 3413a02d6fc8 (1 revision) (flutter/flutter#165263) 2025-03-15 [email protected] Roll Dart SDK from 40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262) 2025-03-15 [email protected] Roll Fuchsia Linux SDK from efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252) 2025-03-15 [email protected] Roll Dart SDK from f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250) 2025-03-15 [email protected] Roll Dart SDK from 8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246) 2025-03-15 [email protected] Roll Skia from 4568e766ed0a to f124daeb564d (1 revision) (flutter/flutter#165245) 2025-03-15 [email protected] Revert "Prevent explicit roles from merging (#164732)" (flutter/flutter#165222) 2025-03-15 [email protected] Roll Skia from bac6e76abfc7 to 4568e766ed0a (5 revisions) (flutter/flutter#165241) 2025-03-14 [email protected] Roll Dart SDK from a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227) 2025-03-14 [email protected] Roll Skia from 98b6922deecf to bac6e76abfc7 (5 revisions) (flutter/flutter#165225) 2025-03-14 [email protected] Point ktlint AS docs to the `.editorconfig` that is actually used by ci, instead of making a copy in the README (flutter/flutter#165213) 2025-03-14 [email protected] Add remaining dart fixes for Color deprecations when importing painting.dart (flutter/flutter#162609) 2025-03-14 [email protected] [Accessibility] Add required semantics flags (flutter/flutter#164585) 2025-03-14 [email protected] Roll Skia from f4467ff38f1f to 98b6922deecf (5 revisions) (flutter/flutter#165215) 2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy to Kotlin (flutter/flutter#163148) 2025-03-14 [email protected] `OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034) 2025-03-14 [email protected] Remove redundant `useMaterial3: true` (flutter/flutter#163376) 2025-03-14 [email protected] Roll Packages from bdb9c96 to d632936 (1 revision) (flutter/flutter#165197) 2025-03-14 [email protected] Changelog updates from 3.29.2 (flutter/flutter#165194) 2025-03-14 [email protected] Roll Dart SDK from 576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191) 2025-03-14 [email protected] Roll Dart SDK from ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180) 2025-03-14 [email protected] Roll Fuchsia Linux SDK from qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175) 2025-03-14 [email protected] [Impeller] Enable mediatek on API 34+. (flutter/flutter#165156) 2025-03-14 [email protected] Roll Dart SDK from cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159) 2025-03-13 [email protected] [FGP conversion] Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143) 2025-03-13 [email protected] Prevent explicit roles from merging (flutter/flutter#164732) ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…8922) Manual roll Flutter from b16430b to 1d954f4 (114 revisions) Manual roll requested by [email protected] flutter/flutter@b16430b...1d954f4 2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutter#165350) 2025-03-17 [email protected] Roll Skia from fa669e2e6d12 to 52130e5c3b34 (4 revisions) (flutter/flutter#165348) 2025-03-17 [email protected] `OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal` rebuilds. (flutter/flutter#165331) 2025-03-17 [email protected] [web][a11y]Delete _childContainerElement (flutter/flutter#163662) 2025-03-17 [email protected] Roll Skia from e45207898e60 to fa669e2e6d12 (8 revisions) (flutter/flutter#165342) 2025-03-17 [email protected] Add documentation for Java test filtering to plugins test document (flutter/flutter#165314) 2025-03-17 [email protected] Roll Fuchsia Linux SDK from SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313) 2025-03-17 [email protected] Roll Dart SDK from 9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310) 2025-03-17 [email protected] feat(Tooltip): replace the height parameter with constraints (flutter/flutter#163314) 2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation between states (flutter/flutter#165178) 2025-03-17 [email protected] Removes assumption that basis scalar and rounded_scalar match (flutter/flutter#165166) 2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8 to e45207898e60 (1 revision) (flutter/flutter#165300) 2025-03-17 [email protected] Refactor: Move sliders value indicator shape to seperate file (flutter/flutter#162858) 2025-03-17 [email protected] Roll Skia from 3931c31032c7 to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288) 2025-03-17 [email protected] Delete `docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258) 2025-03-16 [email protected] Roll Skia from 3413a02d6fc8 to 3931c31032c7 (1 revision) (flutter/flutter#165277) 2025-03-16 [email protected] Roll Fuchsia Linux SDK from LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275) 2025-03-16 [email protected] Roll Dart SDK from 067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269) 2025-03-16 [email protected] Roll Skia from f124daeb564d to 3413a02d6fc8 (1 revision) (flutter/flutter#165263) 2025-03-15 [email protected] Roll Dart SDK from 40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262) 2025-03-15 [email protected] Roll Fuchsia Linux SDK from efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252) 2025-03-15 [email protected] Roll Dart SDK from f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250) 2025-03-15 [email protected] Roll Dart SDK from 8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246) 2025-03-15 [email protected] Roll Skia from 4568e766ed0a to f124daeb564d (1 revision) (flutter/flutter#165245) 2025-03-15 [email protected] Revert "Prevent explicit roles from merging (#164732)" (flutter/flutter#165222) 2025-03-15 [email protected] Roll Skia from bac6e76abfc7 to 4568e766ed0a (5 revisions) (flutter/flutter#165241) 2025-03-14 [email protected] Roll Dart SDK from a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227) 2025-03-14 [email protected] Roll Skia from 98b6922deecf to bac6e76abfc7 (5 revisions) (flutter/flutter#165225) 2025-03-14 [email protected] Point ktlint AS docs to the `.editorconfig` that is actually used by ci, instead of making a copy in the README (flutter/flutter#165213) 2025-03-14 [email protected] Add remaining dart fixes for Color deprecations when importing painting.dart (flutter/flutter#162609) 2025-03-14 [email protected] [Accessibility] Add required semantics flags (flutter/flutter#164585) 2025-03-14 [email protected] Roll Skia from f4467ff38f1f to 98b6922deecf (5 revisions) (flutter/flutter#165215) 2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy to Kotlin (flutter/flutter#163148) 2025-03-14 [email protected] `OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034) 2025-03-14 [email protected] Remove redundant `useMaterial3: true` (flutter/flutter#163376) 2025-03-14 [email protected] Roll Packages from 9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197) 2025-03-14 [email protected] Changelog updates from 3.29.2 (flutter/flutter#165194) 2025-03-14 [email protected] Roll Dart SDK from 576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191) 2025-03-14 [email protected] Roll Dart SDK from ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180) 2025-03-14 [email protected] Roll Fuchsia Linux SDK from qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175) 2025-03-14 [email protected] [Impeller] Enable mediatek on API 34+. (flutter/flutter#165156) 2025-03-14 [email protected] Roll Dart SDK from cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159) 2025-03-13 [email protected] [FGP conversion] Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143) 2025-03-13 [email protected] Prevent explicit roles from merging (flutter/flutter#164732) ...
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…8922) Manual roll Flutter from b16430b to 1d954f4 (114 revisions) Manual roll requested by [email protected] flutter/flutter@b16430b...1d954f4 2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutter#165350) 2025-03-17 [email protected] Roll Skia from fa669e2e6d12 to 52130e5c3b34 (4 revisions) (flutter/flutter#165348) 2025-03-17 [email protected] `OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal` rebuilds. (flutter/flutter#165331) 2025-03-17 [email protected] [web][a11y]Delete _childContainerElement (flutter/flutter#163662) 2025-03-17 [email protected] Roll Skia from e45207898e60 to fa669e2e6d12 (8 revisions) (flutter/flutter#165342) 2025-03-17 [email protected] Add documentation for Java test filtering to plugins test document (flutter/flutter#165314) 2025-03-17 [email protected] Roll Fuchsia Linux SDK from SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313) 2025-03-17 [email protected] Roll Dart SDK from 9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310) 2025-03-17 [email protected] feat(Tooltip): replace the height parameter with constraints (flutter/flutter#163314) 2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation between states (flutter/flutter#165178) 2025-03-17 [email protected] Removes assumption that basis scalar and rounded_scalar match (flutter/flutter#165166) 2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8 to e45207898e60 (1 revision) (flutter/flutter#165300) 2025-03-17 [email protected] Refactor: Move sliders value indicator shape to seperate file (flutter/flutter#162858) 2025-03-17 [email protected] Roll Skia from 3931c31032c7 to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288) 2025-03-17 [email protected] Delete `docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258) 2025-03-16 [email protected] Roll Skia from 3413a02d6fc8 to 3931c31032c7 (1 revision) (flutter/flutter#165277) 2025-03-16 [email protected] Roll Fuchsia Linux SDK from LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275) 2025-03-16 [email protected] Roll Dart SDK from 067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269) 2025-03-16 [email protected] Roll Skia from f124daeb564d to 3413a02d6fc8 (1 revision) (flutter/flutter#165263) 2025-03-15 [email protected] Roll Dart SDK from 40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262) 2025-03-15 [email protected] Roll Fuchsia Linux SDK from efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252) 2025-03-15 [email protected] Roll Dart SDK from f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250) 2025-03-15 [email protected] Roll Dart SDK from 8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246) 2025-03-15 [email protected] Roll Skia from 4568e766ed0a to f124daeb564d (1 revision) (flutter/flutter#165245) 2025-03-15 [email protected] Revert "Prevent explicit roles from merging (#164732)" (flutter/flutter#165222) 2025-03-15 [email protected] Roll Skia from bac6e76abfc7 to 4568e766ed0a (5 revisions) (flutter/flutter#165241) 2025-03-14 [email protected] Roll Dart SDK from a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227) 2025-03-14 [email protected] Roll Skia from 98b6922deecf to bac6e76abfc7 (5 revisions) (flutter/flutter#165225) 2025-03-14 [email protected] Point ktlint AS docs to the `.editorconfig` that is actually used by ci, instead of making a copy in the README (flutter/flutter#165213) 2025-03-14 [email protected] Add remaining dart fixes for Color deprecations when importing painting.dart (flutter/flutter#162609) 2025-03-14 [email protected] [Accessibility] Add required semantics flags (flutter/flutter#164585) 2025-03-14 [email protected] Roll Skia from f4467ff38f1f to 98b6922deecf (5 revisions) (flutter/flutter#165215) 2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy to Kotlin (flutter/flutter#163148) 2025-03-14 [email protected] `OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034) 2025-03-14 [email protected] Remove redundant `useMaterial3: true` (flutter/flutter#163376) 2025-03-14 [email protected] Roll Packages from 9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197) 2025-03-14 [email protected] Changelog updates from 3.29.2 (flutter/flutter#165194) 2025-03-14 [email protected] Roll Dart SDK from 576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191) 2025-03-14 [email protected] Roll Dart SDK from ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180) 2025-03-14 [email protected] Roll Fuchsia Linux SDK from qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175) 2025-03-14 [email protected] [Impeller] Enable mediatek on API 34+. (flutter/flutter#165156) 2025-03-14 [email protected] Roll Dart SDK from cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159) 2025-03-13 [email protected] [FGP conversion] Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143) 2025-03-13 [email protected] Prevent explicit roles from merging (flutter/flutter#164732) ...
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
…ng.dart (flutter#162609) Towards flutter#160617 Noticed the `opacity` and `withOpacity` deprecations were supported by dart fix, but not the others. Adding them here. But strange too given `dart:ui` does not support dart fix (dart-lang/sdk#59764).. --- We think since `painting.dart` exports `dart:ui`, this is somewhat of a workaround. If a user has this atop their file: ```dart import 'package:flutter/painting.dart'; // 👍 dart fix will work here ``` If instead ```dart import 'dart:ui'; // ❌ dart fix will not work here ``` Will continue to follow up on dart fix support for `dart:X` libraries, for now hopefully this will help! ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #160617
Noticed the
opacityandwithOpacitydeprecations were supported by dart fix, but not the others. Adding them here.But strange too given
dart:uidoes not support dart fix (dart-lang/sdk#59764)..We think since
painting.dartexportsdart:ui, this is somewhat of a workaround.If a user has this atop their file:
If instead
Will continue to follow up on dart fix support for
dart:Xlibraries, for now hopefully this will help!Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.