-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Update code comments for navigation_bar.dart #162596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TahaTesser WDYT is this a bug or a doc issue?
|
A doc issue. Because this is already explained in class |
Seems like a doc issue. Thanks for the fix! @gaspardruan. |
|
@gaspardruan Additionally, please file a quick issue that this PR fixes. It's best practice, as it makes it easier to understand the proposal and track issues that are fixed. |
Update code doc of navigation_bar.dart Co-authored-by: Taha Tesser <[email protected]>
|
The PR fixes issue #162592. |
TahaTesser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bleroux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #162592
Comments error:
If this are null, the default text style would use [TextTheme.labelSmall]is wrong. Actually, This is right in material2, but wrong in material3. I have dived into_NavigationBarDefaultsM3, I found this:The default text style would use [TextTheme.labelMedium] in Material3.
Changes
Just clarify the doc comments above.test-exempt
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.