Skip to content

Conversation

@mosuem
Copy link
Contributor

@mosuem mosuem commented Feb 3, 2025

Run flutter update-packages --cherry-pick-package intl --cherry-pick-version 0.20.2

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Feb 3, 2025
@mosuem
Copy link
Contributor Author

mosuem commented Feb 3, 2025

@goderbauer This is ready to land now!

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 3, 2025

autosubmit label was removed for flutter/flutter/162591, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 3, 2025
Merged via the queue into flutter:master with commit 264bef3 Feb 3, 2025
148 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2025
@goderbauer goderbauer mentioned this pull request Feb 3, 2025
9 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@JanzTam
Copy link

JanzTam commented Mar 12, 2025

It is solved in which sdk version? The lastest Flutter version 3.29.1 is still depends 0.19.0.

@mosuem
Copy link
Contributor Author

mosuem commented Mar 12, 2025

Good question - @goderbauer is there a way of seeing which (stable) release a commit will be in?

@goderbauer
Copy link
Member

If you go to the commit page (for this one it's 264bef3) and look at the version tags it can give you a rough idea. Looks like this one may make it into the next release.

@bambinoua
Copy link
Contributor

Hi, @mosuem

Run flutter update-packages --cherry-pick-package intl --cherry-pick-version 0.20.2

I did so but it does not help.

@mosuem
Copy link
Contributor Author

mosuem commented Mar 21, 2025

I did so but it does not help.

You don't need to do that - this command is for updating the intl package in Flutter itself. If you only plan on using another version of intl, wait for this PR to land in a release, or use dependency overrides in you pubspec.

@tran-huy-phuc
Copy link

I'm still seeing this issue with Flutter v3.29.2. Waiting...

@alexlovar
Copy link

I'm still seeing this issue with Flutter v3.29.2.

@smoak
Copy link

smoak commented Apr 21, 2025

Still seeing the issue with v3.29.3

Made a simple repro with the following pubspec.yaml:

name: sample
environment:
  sdk: '>=3.2.1 <4.0.0'

dependencies:
  flutter:
    sdk: flutter
  flutter_localizations:
    sdk: flutter
  intl: 0.20.2
$ flutter --version
Flutter 3.29.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision ea121f8859 (9 days ago) • 2025-04-11 19:10:07 +0000
Engine • revision cf56914b32
Tools • Dart 3.7.2 • DevTools 2.42.3

$ flutter pub get
Resolving dependencies...
Note: intl is pinned to version 0.19.0 by flutter_localizations from the flutter SDK.
See https://dart.dev/go/sdk-version-pinning for details.


Because sample depends on flutter_localizations from sdk which depends on intl 0.19.0, intl 0.19.0 is required.
So, because sample depends on intl 0.20.2, version solving failed.


You can try the following suggestion to make the pubspec resolve:
* Consider downgrading your constraint on intl: flutter pub add intl:^0.19.0
Failed to update packages.

@JanzTam
Copy link

JanzTam commented Apr 23, 2025

It solved in beta v3.30.0. I guess it will be the same for the stable version. So, let's keep waiting. @tran-huy-phuc @alexlovar @smoak

@large
Copy link

large commented May 13, 2025

This fix has taken WAY to long... Is this suppose to be in the next stable release of Flutter or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants