-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Upgrade package:intl to 0.20.2
#162591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade package:intl to 0.20.2
#162591
Conversation
|
@goderbauer This is ready to land now! |
goderbauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
autosubmit label was removed for flutter/flutter/162591, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
It is solved in which sdk version? The lastest Flutter version 3.29.1 is still depends 0.19.0. |
|
Good question - @goderbauer is there a way of seeing which (stable) release a commit will be in? |
|
If you go to the commit page (for this one it's 264bef3) and look at the version tags it can give you a rough idea. Looks like this one may make it into the next release. |
|
Hi, @mosuem
I did so but it does not help. |
You don't need to do that - this command is for updating the intl package in Flutter itself. If you only plan on using another version of intl, wait for this PR to land in a release, or use dependency overrides in you pubspec. |
|
I'm still seeing this issue with Flutter v3.29.2. Waiting... |
|
I'm still seeing this issue with Flutter v3.29.2. |
|
Still seeing the issue with v3.29.3 Made a simple repro with the following name: sample
environment:
sdk: '>=3.2.1 <4.0.0'
dependencies:
flutter:
sdk: flutter
flutter_localizations:
sdk: flutter
intl: 0.20.2
|
|
It solved in beta v3.30.0. I guess it will be the same for the stable version. So, let's keep waiting. @tran-huy-phuc @alexlovar @smoak |
|
This fix has taken WAY to long... Is this suppose to be in the next stable release of Flutter or not? |
Run
flutter update-packages --cherry-pick-package intl --cherry-pick-version 0.20.2Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.