Fix `Linux docs_publish` running at head #162557

jtmcdole · 2025-02-01T01:41:54Z

This target was using release_build: true as a way to skip release branches. This flag is used to signal engine artifacts are built - they need to be skipped:

in release branches because artifacts are produced through other paths.
in postsubmits of monorepo since the engine artifacts are produced in the merge queue.

This target was the only one in the framework defining it this way. It should have been using enabled_branches.

tested: locally, using CiYaml directly with a copy of flutter's ci.yaml:

  final YamlMap configYaml = loadYaml(await File(args.command!['file']).readAsString()) as YamlMap;
  final pb.SchedulerConfig schedulerConfig = pb.SchedulerConfig()..mergeFromProto3Json(configYaml);
  final masterYaml = CiYamlSet(
    yamls: {
      CiType.any: schedulerConfig,
    },
    slug: RepositorySlug.full('flutter/flutter'),
    branch: 'master',
    validate: false,
    isFusion: false,
  );
  final masterNames = {...masterYaml.postsubmitTargets().map((t) => t.value.name)};
  final releaseYaml = CiYamlSet(
    yamls: {
      CiType.any: schedulerConfig,
    },
    slug: RepositorySlug.full('flutter/flutter'),
    branch: 'flutter-3.27-candidate.0',
    validate: false,
    isFusion: false,
  );
  final releaseNames = {...releaseYaml.postsubmitTargets().map((t) => t.value.name)};

  print("********************************");
  print(releaseNames.contains('Linux docs_publish'));  // false
  print(masterNames.contains('Linux docs_publish')); // true - generate docs in postsubmit
  print("********************************");

Fixes #162552

This target was using `release_build: true` as a way to skip release branches. This flag is used to signal engine artifacts are built - they need to be skipped: - in release branches because artifacts are produced through other paths. - in postsubmits of monorepo since the engine artifacts are produced in the merge queue. This target was the only one in the framework defining it this way. It should have been using `enabled_branches`.

.ci.yaml

auto-submit · 2025-02-01T01:51:25Z

autosubmit label was removed for flutter/flutter/162557, because This PR has not met approval requirements for merging. Changes were requested by {matanlurey}, please make the needed changes and resubmit this PR.
The PR author is a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

matanlurey

Wow that's not what I would have expected, but thanks for explaining. LGTM!

auto-submit · 2025-02-01T04:22:40Z

autosubmit label was removed for flutter/flutter/162557, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

)

Roll Flutter from b007899 to 8e2a6fc (61 revisions) flutter/flutter@b007899...8e2a6fc 2025-02-03 [email protected] Implement hot reload using the DDC library bundle format (flutter/flutter#162498) 2025-02-01 [email protected] [Android] add lint ignores to Flutter JNI. (flutter/flutter#162527) 2025-02-01 [email protected] Fix `Linux docs_publish` running at head (flutter/flutter#162557) 2025-02-01 [email protected] [Flutter GPU] Breaking: Use exceptions for resource creation errors. (flutter/flutter#162104) 2025-02-01 [email protected] [Impeller] Increase conical gradient precision. (flutter/flutter#162543) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162542) 2025-01-31 [email protected] [web] Gracefully handle empty ui.Vertices (flutter/flutter#162461) 2025-01-31 [email protected] [web] Remove HTML build artifacts (flutter/flutter#162528) 2025-01-31 [email protected] [ Tool ] Remove use of globals from widget-preview commands (flutter/flutter#162522) 2025-01-31 [email protected] Add a special case for the Fuchsia SDK ftl.fidl file in the license script (flutter/flutter#162423) 2025-01-31 [email protected] [Impeller] Remove some unused methods from EntityPassClipStack (flutter/flutter#162478) 2025-01-31 [email protected] Reenable linux_web_engine mac tests on Mac-14 (flutter/flutter#162409) 2025-01-31 [email protected] Fix NavigationRail examples overflow alignment (flutter/flutter#159937) 2025-01-31 [email protected] Roll Skia from c1dc5033e7c9 to 4bdf90faf708 (1 revision) (flutter/flutter#162511) 2025-01-31 [email protected] Roll Skia from e0941791b86e to c1dc5033e7c9 (1 revision) (flutter/flutter#162504) 2025-01-31 [email protected] [Reland] Fix `Tab` linear and elastic animation blink (#162315) (flutter/flutter#162450) 2025-01-31 [email protected] fix syntax error in comment pseudocode (flutter/flutter#162453) 2025-01-31 [email protected] Roll Skia from ec8c632b8c7f to e0941791b86e (1 revision) (flutter/flutter#162502) 2025-01-31 [email protected] Roll Skia from a9af2a74c5ab to ec8c632b8c7f (2 revisions) (flutter/flutter#162496) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162476) 2025-01-31 [email protected] Document flutter/package deps version policy (flutter/flutter#162492) 2025-01-31 [email protected] Add iOS tool codeowner (flutter/flutter#162167) 2025-01-31 [email protected] Fixed the text aspect ratio (flutter/flutter#162415) 2025-01-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete `FlutterCommand.usageValues` (#162468)" (flutter/flutter#162494) 2025-01-31 [email protected] Add new web contributors to web triage doc. (flutter/flutter#162420) 2025-01-30 [email protected] Fix the build borked in flutter/flutter#162475. (flutter/flutter#162484) 2025-01-30 [email protected] Roll Skia from e6daf687b558 to a9af2a74c5ab (5 revisions) (flutter/flutter#162474) 2025-01-30 [email protected] Bump `Linux mac_clang_tidy" to 120m timeout (flutter/flutter#162475) 2025-01-30 [email protected] Delete `FlutterCommand.usageValues` (flutter/flutter#162468) 2025-01-30 [email protected] Fixed some floating point inaccuracies in TextContents (flutter/flutter#162351) 2025-01-30 [email protected] Limit number of retries when downloading the Dart SDK on Windows (flutter/flutter#162411) 2025-01-30 [email protected] Add FormField.errorBuilder (flutter/flutter#162255) 2025-01-30 [email protected] Fix `Checkbox` default visual density to meet Material 3 guidelines (flutter/flutter#159081) 2025-01-30 [email protected] [Android] add HC++ platform view class. (flutter/flutter#161829) 2025-01-30 [email protected] Add tests to confirm CupertinoSliverNavigationBar snaps when partially scrolled in .always bottom mode (flutter/flutter#162425) 2025-01-30 [email protected] [Impeller] Disable Vulkan on Emulators. (flutter/flutter#162454) 2025-01-30 [email protected] [FGP Kotlin conversion] Convert `Deeplink` and `IntentFilterCheck` (flutter/flutter#161835) 2025-01-30 [email protected] fix slider semantic label (flutter/flutter#162304) 2025-01-30 [email protected] Roll Skia from f22419dbed05 to e6daf687b558 (37 revisions) (flutter/flutter#162447) 2025-01-30 [email protected] Fix `flutter doctor` instructions displayed when `cmdline-tools` (Android SDK) cannot be found (flutter/flutter#162281) 2025-01-30 [email protected] remove more (simple) usage of package:usage (flutter/flutter#162354) 2025-01-30 [email protected] [Android] HC++ plumbing. (flutter/flutter#162407) 2025-01-30 [email protected] Removes dev dependencies from generated plugin registrant for non-Android platforms (flutter/flutter#161828) 2025-01-30 [email protected] Fix unexpected shown of Scrollbar (flutter/flutter#159386) 2025-01-30 [email protected] Roll package:vm_service to 15.0.0 and package:leak_tracker to 10.0.9 (flutter/flutter#162325) 2025-01-30 [email protected] Roll Fuchsia Test Scripts from r9Dc5VRF6sE3pJH20... to g6IlaYL1_wNmk3zNj... (flutter/flutter#162427) ...

…#168824) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? Closes #168709. ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples N/A (CI Infra Change) ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Not user facing - this fixes API doc generation for release candidate branches, which was accidentally broken in #162557. ### Workaround: Is there a workaround for this issue? N/A ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Merge a commit to `flutter-3.32-candidate.0` and observe the post-submits.

)

Roll Flutter from b007899 to 8e2a6fc (61 revisions) flutter/flutter@b007899...8e2a6fc 2025-02-03 [email protected] Implement hot reload using the DDC library bundle format (flutter/flutter#162498) 2025-02-01 [email protected] [Android] add lint ignores to Flutter JNI. (flutter/flutter#162527) 2025-02-01 [email protected] Fix `Linux docs_publish` running at head (flutter/flutter#162557) 2025-02-01 [email protected] [Flutter GPU] Breaking: Use exceptions for resource creation errors. (flutter/flutter#162104) 2025-02-01 [email protected] [Impeller] Increase conical gradient precision. (flutter/flutter#162543) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162542) 2025-01-31 [email protected] [web] Gracefully handle empty ui.Vertices (flutter/flutter#162461) 2025-01-31 [email protected] [web] Remove HTML build artifacts (flutter/flutter#162528) 2025-01-31 [email protected] [ Tool ] Remove use of globals from widget-preview commands (flutter/flutter#162522) 2025-01-31 [email protected] Add a special case for the Fuchsia SDK ftl.fidl file in the license script (flutter/flutter#162423) 2025-01-31 [email protected] [Impeller] Remove some unused methods from EntityPassClipStack (flutter/flutter#162478) 2025-01-31 [email protected] Reenable linux_web_engine mac tests on Mac-14 (flutter/flutter#162409) 2025-01-31 [email protected] Fix NavigationRail examples overflow alignment (flutter/flutter#159937) 2025-01-31 [email protected] Roll Skia from c1dc5033e7c9 to 4bdf90faf708 (1 revision) (flutter/flutter#162511) 2025-01-31 [email protected] Roll Skia from e0941791b86e to c1dc5033e7c9 (1 revision) (flutter/flutter#162504) 2025-01-31 [email protected] [Reland] Fix `Tab` linear and elastic animation blink (#162315) (flutter/flutter#162450) 2025-01-31 [email protected] fix syntax error in comment pseudocode (flutter/flutter#162453) 2025-01-31 [email protected] Roll Skia from ec8c632b8c7f to e0941791b86e (1 revision) (flutter/flutter#162502) 2025-01-31 [email protected] Roll Skia from a9af2a74c5ab to ec8c632b8c7f (2 revisions) (flutter/flutter#162496) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162476) 2025-01-31 [email protected] Document flutter/package deps version policy (flutter/flutter#162492) 2025-01-31 [email protected] Add iOS tool codeowner (flutter/flutter#162167) 2025-01-31 [email protected] Fixed the text aspect ratio (flutter/flutter#162415) 2025-01-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete `FlutterCommand.usageValues` (#162468)" (flutter/flutter#162494) 2025-01-31 [email protected] Add new web contributors to web triage doc. (flutter/flutter#162420) 2025-01-30 [email protected] Fix the build borked in flutter/flutter#162475. (flutter/flutter#162484) 2025-01-30 [email protected] Roll Skia from e6daf687b558 to a9af2a74c5ab (5 revisions) (flutter/flutter#162474) 2025-01-30 [email protected] Bump `Linux mac_clang_tidy" to 120m timeout (flutter/flutter#162475) 2025-01-30 [email protected] Delete `FlutterCommand.usageValues` (flutter/flutter#162468) 2025-01-30 [email protected] Fixed some floating point inaccuracies in TextContents (flutter/flutter#162351) 2025-01-30 [email protected] Limit number of retries when downloading the Dart SDK on Windows (flutter/flutter#162411) 2025-01-30 [email protected] Add FormField.errorBuilder (flutter/flutter#162255) 2025-01-30 [email protected] Fix `Checkbox` default visual density to meet Material 3 guidelines (flutter/flutter#159081) 2025-01-30 [email protected] [Android] add HC++ platform view class. (flutter/flutter#161829) 2025-01-30 [email protected] Add tests to confirm CupertinoSliverNavigationBar snaps when partially scrolled in .always bottom mode (flutter/flutter#162425) 2025-01-30 [email protected] [Impeller] Disable Vulkan on Emulators. (flutter/flutter#162454) 2025-01-30 [email protected] [FGP Kotlin conversion] Convert `Deeplink` and `IntentFilterCheck` (flutter/flutter#161835) 2025-01-30 [email protected] fix slider semantic label (flutter/flutter#162304) 2025-01-30 [email protected] Roll Skia from f22419dbed05 to e6daf687b558 (37 revisions) (flutter/flutter#162447) 2025-01-30 [email protected] Fix `flutter doctor` instructions displayed when `cmdline-tools` (Android SDK) cannot be found (flutter/flutter#162281) 2025-01-30 [email protected] remove more (simple) usage of package:usage (flutter/flutter#162354) 2025-01-30 [email protected] [Android] HC++ plumbing. (flutter/flutter#162407) 2025-01-30 [email protected] Removes dev dependencies from generated plugin registrant for non-Android platforms (flutter/flutter#161828) 2025-01-30 [email protected] Fix unexpected shown of Scrollbar (flutter/flutter#159386) 2025-01-30 [email protected] Roll package:vm_service to 15.0.0 and package:leak_tracker to 10.0.9 (flutter/flutter#162325) 2025-01-30 [email protected] Roll Fuchsia Test Scripts from r9Dc5VRF6sE3pJH20... to g6IlaYL1_wNmk3zNj... (flutter/flutter#162427) ...

jtmcdole requested review from matanlurey and zanderso February 1, 2025 01:42

jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 1, 2025

matanlurey requested changes Feb 1, 2025

View reviewed changes

.ci.yaml Outdated Show resolved Hide resolved

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 1, 2025

jtmcdole added 2 commits January 31, 2025 18:31

whitespace

f577074

Notes

8cc2983

jtmcdole requested a review from matanlurey February 1, 2025 03:04

matanlurey approved these changes Feb 1, 2025

View reviewed changes

jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 1, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 1, 2025

jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 1, 2025

auto-submit bot added this pull request to the merge queue Feb 1, 2025

Merged via the queue into master with commit f56d5a9 Feb 1, 2025
157 checks passed

auto-submit bot deleted the grrrArrrrrrrrg branch February 1, 2025 05:17

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 1, 2025

engine-flutter-autoroll mentioned this pull request Feb 1, 2025

Roll Flutter from b007899d3a7a to f56d5a98c1da (59 revisions) flutter/packages#8547

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025

f56d5a9 Fix Linux docs_publish running at head (flutter/flutter#162557

63c1afb

)

engine-flutter-autoroll mentioned this pull request Feb 1, 2025

Roll Flutter from b007899d3a7a to f56d5a98c1da (59 revisions) flutter/packages#8548

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025

f56d5a9 Fix Linux docs_publish running at head (flutter/flutter#162557

efe1c27

)

engine-flutter-autoroll mentioned this pull request Feb 2, 2025

Roll Flutter from b007899d3a7a to 4d08217f8dca (60 revisions) flutter/packages#8549

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025

f56d5a9 Fix Linux docs_publish running at head (flutter/flutter#162557

11d9b40

)

engine-flutter-autoroll mentioned this pull request Feb 2, 2025

Roll Flutter from b007899d3a7a to 4d08217f8dca (60 revisions) flutter/packages#8550

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025

f56d5a9 Fix Linux docs_publish running at head (flutter/flutter#162557

54a4e80

)

engine-flutter-autoroll mentioned this pull request Feb 3, 2025

Roll Flutter from b007899d3a7a to 8e2a6fc3fd2c (61 revisions) flutter/packages#8554

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025

f56d5a9 Fix Linux docs_publish running at head (flutter/flutter#162557

95f04c2

)

engine-flutter-autoroll mentioned this pull request Feb 3, 2025

Roll Flutter from b007899d3a7a to 8e2a6fc3fd2c (61 revisions) flutter/packages#8556

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025

f56d5a9 Fix Linux docs_publish running at head (flutter/flutter#162557

d494b2c

)

This was referenced May 13, 2025

API docs generation for releases ^3.32-candidate.0 is broken #168709

Closed

[CP-beta]Remove docs_deploy_beta, fix docs_publish, add comments. #168824

Merged

matanlurey mentioned this pull request May 15, 2025

Remove schedule_during_release_override: true and use two targets instead #168913

Closed

4 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

f56d5a9 Fix Linux docs_publish running at head (flutter/flutter#162557

d6f8690

)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

f56d5a9 Fix Linux docs_publish running at head (flutter/flutter#162557

6e68b93

)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

f56d5a9 Fix Linux docs_publish running at head (flutter/flutter#162557

667d132

)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix `Linux docs_publish` running at head #162557

Fix `Linux docs_publish` running at head #162557

Uh oh!

jtmcdole commented Feb 1, 2025

Uh oh!

Uh oh!

auto-submit bot commented Feb 1, 2025

Uh oh!

matanlurey left a comment

Uh oh!

auto-submit bot commented Feb 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix Linux docs_publish running at head #162557

Fix Linux docs_publish running at head #162557

Uh oh!

Conversation

jtmcdole commented Feb 1, 2025

Uh oh!

Uh oh!

auto-submit bot commented Feb 1, 2025

Uh oh!

matanlurey left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Feb 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix `Linux docs_publish` running at head #162557

Fix `Linux docs_publish` running at head #162557