Skip to content

[reland] delete FlutterCommand.usageValues #162550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrewkolos merged 3 commits into from
Feb 3, 2025
Merged

[reland] delete FlutterCommand.usageValues #162550

andrewkolos merged 3 commits into from
Feb 3, 2025

Conversation

@andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented Jan 31, 2025 •
edited
Loading

Relands #162468

The original PR broke the module_test_ios post submit tests.

The original PR also broke g3 postsubmit, because there was an override of FlutterCommand.usageValues. This was since deleted.

Original PR description

toward #150575. More simple deletes.

Pre-launch checklist

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 31, 2025
@andrewkolos andrewkolos marked this pull request as ready for review January 31, 2025 22:43
@andrewkolos andrewkolos marked this pull request as draft January 31, 2025 23:16
@andrewkolos
remove module_test_ios check against analytics logs
1fd1653 
package:unified_analytics doesn't provide such a feature. We should probably keep analytics 100% disabled anyway for tests. This is adequately covered by unit tests.
@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2025
@andrewkolos andrewkolos marked this pull request as ready for review February 3, 2025 20:07
@andrewkolos andrewkolos added this pull request to the merge queue Feb 3, 2025
Merged via the queue into flutter:master with commit 2f2bda3 Feb 3, 2025
147 of 150 checks passed
@andrewkolos andrewkolos deleted the remove-usage-values-in-flutter-command branch February 3, 2025 21:13
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
79f8dc7 
…#162550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
5274a16 
…#162550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
0b02ae6 
…#162550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
44f28dd 
…#162550)
@andrewkolos andrewkolos mentioned this pull request Feb 5, 2025
Open
3 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
5ae6ce6 
…#162550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
50d3058 
…#162550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
9147228 
…#162550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
76b35e6 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
5c239d8 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
9fecc94 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
d0c2050 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
ccd5946 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
b15c15b 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
aac8ac3 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
386d338 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
31459ca 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
13b71b9 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
c32b7f7 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
a6cbba9 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
88f86b7 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
1665ad2 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
7c3cd5c 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
1b43a43 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
892a8f0 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
49c0971 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
e3376a0 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
68a8b57 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
ef11857 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
85fe124 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
bcec193 
…#162550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
2f2bda3 [reland] delete FlutterCommand.usageValues (flutter/flutter…
566cbe5 
…#162550)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewkolos @cbracken