[CP][Impeller] Disable Vulkan on Emulators. (#162454) #162536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forces known android emulators to use OpenGLES. This is a very conservative check that could be expanded over time if need be. For testing emulators can still use the debug flags. Fixes flutter#160442 Fixes flutter#160439 Fixes flutter#155973
jonahwilliams
added
the
cp: beta
github-actions
bot
added
platform-android
jtmcdole
reviewed
Jan 31, 2025
|
|
||
| // static | ||
| bool FlutterMain::IsDeviceEmulator(std::string_view product_model) { | ||
| return std::string(product_model).find("gphone") != std::string::npos; |
Member
There was a problem hiding this comment.
Is there ever a case this could also just be "emulator"?
Contributor
Author
There was a problem hiding this comment.
probably, but I decided to play it conservative since all my emulators said gphone. (We only have to worry about very new emulators as old ones have no vulkan support regardless of API level)
jtmcdole
approved these changes
Jan 31, 2025
Member
|
I also realize this is a cherrypick, so ignore :) |
christopherfujino
added
the
autosubmit
auto-submit
bot
merged commit 1d03bf2
into
flutter:flutter-3.29-candidate.0
159 checks passed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forces known android emulators to use OpenGLES. This is a very conservative check that could be expanded over time if need be. For testing emulators can still use the debug flags.
Fixes #160442
Fixes #160439
Fixes #155973