-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[Windows] Allow apps to prefer low power GPUs #162490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ake ANGLE backend to choose low-power GPU when this flag is provided.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
engine/src/flutter/shell/platform/windows/public/flutter_windows.h
Outdated
Show resolved
Hide resolved
engine/src/flutter/shell/platform/windows/client_wrapper/include/flutter/dart_project.h
Outdated
Show resolved
Hide resolved
engine/src/flutter/shell/platform/windows/flutter_project_bundle.h
Outdated
Show resolved
Hide resolved
|
For a test, maybe we could copy this one but with the low power mode flag set? flutter/engine/src/flutter/shell/platform/windows/flutter_windows_unittests.cc Lines 411 to 423 in 4d8585d
You'll need to add the low power mode flag to |
Are those unittests actually running DXGI calls? Is this mocked or really returning underlying DXGI devices? |
…and make ANGLE backend to choose low-power GPU when this flag is provided.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.