Handle whitespace in entry values in the AAPT badging parser #16245
Conversation
There was a problem hiding this comment.
you can also just remove the show line, we usually import this file unconditionally.
There was a problem hiding this comment.
this used to support foo=bar and foo='bar', but not only supports foo='bar', is that intentional?
There was a problem hiding this comment.
also this handles foo='bar baz=quux' differently than what we did before, and will find a=b in zz="xx a='b' yy"
we should add tests for these cases to make sure they do what we want, in case someone "fixes" the code to be like it was before.
There was a problem hiding this comment.
yes, this is WAI - the Android tool always surrounds the attributes that we care about with quotes
There was a problem hiding this comment.
(specifically single quotes - it will not use double quotes as in the zz="xx a='b' yy" case)
There was a problem hiding this comment.
Use UnmodifiableMapView just to be safe.
|
Hey we are getting the same error pointed out in 16200. However going by the feed, the solution is not clear for the same. Can anyone help? |
* 'master' of https://github.com/flutter/flutter: Roll engine to aa9ce70 (flutter#16289) Rename chip's border attribute to shape for consistency. (flutter#16276) Added BeveledRectangleBorder ShapeBorder (flutter#16279) Roll engine to version be07059 (flutter#16264) Make Podfiles work with Cocoapods 1.5.0 (flutter#16273) Updated appearance of filled TextFields - added UnderlineInputBorder.borderRadius (flutter#16272) Handle whitespace in entry values in the AAPT badging parser (flutter#16245) a11y adjustments for the Bottom app bar demo (flutter#16238) Play butterfly video from asset instead of network (flutter#16269)
5 participants
Fixes #16200