Skip to content

Update SnackBar.onVisible documentation #162448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Feb 4, 2025
Merged

Update SnackBar.onVisible documentation #162448

auto-submit merged 1 commit into from
Feb 4, 2025

Conversation

@bleroux
Copy link
Contributor

@bleroux bleroux commented Jan 30, 2025

Description

This PR updated SnackBar.onVisible documentation to explain why it can be call several times.

Related Issue

Fixes Snackbar onVisible is called twice

Tests

Documentation only

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jan 30, 2025
@bleroux bleroux requested review from Piinks and TahaTesser January 30, 2025 17:33
TahaTesser
TahaTesser approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bleroux bleroux force-pushed the update_SnackBar_onVisible_documentation branch from e787e1c to 12bd50d Compare February 3, 2025 13:08
@bleroux bleroux force-pushed the update_SnackBar_onVisible_documentation branch from 12bd50d to 9863cb7 Compare February 4, 2025 06:33
@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 4, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 4, 2025
Merged via the queue into flutter:master with commit 5b29db9 Feb 4, 2025
77 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 4, 2025
@bleroux bleroux deleted the update_SnackBar_onVisible_documentation branch February 4, 2025 14:31
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
4bbb97a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
63c7689
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
de6fe9d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
2e743e9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
89eb95a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
49a97e0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
e76e843
This was referenced Feb 5, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
c950e36
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
391c5f7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
4a545b8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
fb5bfd0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
bb74391
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
1783ae8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
b5e0fb1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
3f96716
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
5c5e09a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
54d2d03
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
2b1ae5d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
2e70a84
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
2e5fd61
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
fe7c1fa
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
9a9981e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
12baf95
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
2635402
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
27f7846
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
4bf7f60
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
218604a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
797a375
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
a664563
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
82851b9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
5b29db9 Update SnackBar.onVisible documentation (flutter/flutter#162448)
2e41e49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

@Piinks Piinks Awaiting requested review from Piinks

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Snackbar onVisible is called twice

2 participants

@bleroux @TahaTesser