Skip to content

Improved error message when PageController is not attached to PageView #162422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Feb 10, 2025
Merged

Improved error message when PageController is not attached to PageView #162422

auto-submit merged 1 commit into from
Feb 10, 2025

Conversation

@Paulik8
Copy link
Contributor

@Paulik8 Paulik8 commented Jan 30, 2025 •
edited by Piinks
Loading

Fixes #138945

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 30, 2025
@goderbauer goderbauer requested a review from Piinks February 4, 2025 23:07
@Piinks Piinks added the f: scrolling Viewports, list views, slivers, etc. label Feb 10, 2025
Piinks
Piinks approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Paulik8 thank you for contributing! This change LGTM!

goderbauer
goderbauer approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 10, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 10, 2025
Merged via the queue into flutter:master with commit 78e5d79 Feb 10, 2025
76 of 77 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 10, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
46bf232 
… PageView (flutter/flutter#162422)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
13c50cf 
… PageView (flutter/flutter#162422)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
316e41c 
… PageView (flutter/flutter#162422)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
3f9a69b 
… PageView (flutter/flutter#162422)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
79eb545 
… PageView (flutter/flutter#162422)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
fa5fa09 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
5157dcf 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
1239ca3 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
06edcd2 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
69303ea 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
95da7b8 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
80d3196 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
2f122b8 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
b9ee9b4 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
c985e3b 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
52186dd 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
35716ce 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
0b9fde2 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
4e42e4e 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
81e6065 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
b89872c 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
41541f1 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
c8bd95a 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
1ece044 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
d8599bb 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
77de9a4 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
568db22 
… PageView (flutter/flutter#162422)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
78e5d79 Improved error message when PageController is not attached to…
504d865 
… PageView (flutter/flutter#162422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve error message when PageController is not attached to PageView

3 participants

@Paulik8 @goderbauer @Piinks