Adds urlspan to support link semantics in Android #162419

chunhtai · 2025-01-30T00:05:58Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

chunhtai · 2025-01-30T18:49:51Z

engine/src/flutter/shell/platform/android/io/flutter/view/AccessibilityBridge.java

      result.addAction(AccessibilityNodeInfo.ACTION_SET_TEXT);
    }

-    if (semanticsNode.hasFlag(Flag.IS_BUTTON) || semanticsNode.hasFlag(Flag.IS_LINK)) {


adding this was a workaround so that people get a hint that this ANI is clickable. Since now the talkback will pronounce the urlspan, this is no longer needed

gmackall

LGTM, just a question about magic numbers

gmackall · 2025-02-04T18:29:10Z

.../platform/android/platform_view_android_delegate/platform_view_android_delegate_unittests.cc

  update.insert(std::make_pair(0, node0));

-  std::vector<uint8_t> expected_buffer(192);
+  std::vector<uint8_t> expected_buffer(196);


I haven't had a chance to review much c++ in the engine (nor the chance to write much in a long time), so sorry if this is a dumb question, but is this a standard practice in our tests?

Is there a reason we don't make kBytesPerNode extern and make this test 4 * delegate->kBytesPerNode? Can you at least leave a comment here describing the magic number if we don't want to do that?

…utter#162419)

github-actions bot added platform-android Android applications specifically framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Jan 30, 2025

Adds urlspan to support link semantics in Android

3ac3558

chunhtai force-pushed the issues/102535 branch from ff82452 to 3ac3558 Compare January 30, 2025 17:12

Update

bf47b09

github-actions bot removed framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Jan 30, 2025

chunhtai marked this pull request as ready for review January 30, 2025 18:47

chunhtai requested a review from reidbaker January 30, 2025 18:48

chunhtai commented Jan 30, 2025

View reviewed changes

update

677d660

reidbaker requested a review from gmackall February 3, 2025 17:52

reidbaker approved these changes Feb 3, 2025

View reviewed changes

gmackall approved these changes Feb 4, 2025

View reviewed changes

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 4, 2025

auto-submit bot added this pull request to the merge queue Feb 4, 2025

Merged via the queue into flutter:master with commit 0e1df62 Feb 4, 2025
177 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 4, 2025

engine-flutter-autoroll mentioned this pull request Feb 5, 2025

Roll Flutter from 8e2a6fc3fd2c to dfb36f032e6d (46 revisions) flutter/packages#8568

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

590337b

…utter#162419)

engine-flutter-autoroll mentioned this pull request Feb 5, 2025

Roll Flutter from 8e2a6fc3fd2c to dfb36f032e6d (46 revisions) flutter/packages#8569

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

8f0045c

…utter#162419)

engine-flutter-autoroll mentioned this pull request Feb 5, 2025

Roll Flutter from 8e2a6fc3fd2c to 3b3936a703db (47 revisions) flutter/packages#8571

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

6e3f6b1

…utter#162419)

engine-flutter-autoroll mentioned this pull request Feb 6, 2025

Roll Flutter from 8e2a6fc3fd2c to f219bbac5514 (67 revisions) flutter/packages#8576

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

814daf8

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

b84eee7

…utter#162419)

engine-flutter-autoroll mentioned this pull request Feb 6, 2025

Roll Flutter from 8e2a6fc3fd2c to f219bbac5514 (67 revisions) flutter/packages#8577

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

a2860bb

…utter#162419)

engine-flutter-autoroll mentioned this pull request Feb 6, 2025

Roll Flutter from 8e2a6fc3fd2c to 0e59f0f64c6a (68 revisions) flutter/packages#8579

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

be4128f

…utter#162419)

engine-flutter-autoroll mentioned this pull request Feb 6, 2025

Roll Flutter from 8e2a6fc3fd2c to 5944d992ac40 (69 revisions) flutter/packages#8581

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

ee0b594

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

5ec4288

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

221c79a

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

45c7898

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

1284a01

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

26ee1cc

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

36af950

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

b26125d

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

673ba79

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

014388f

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

9c48fa9

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

abd0906

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

04ae226

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

23d9411

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

1da74fe

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

7fc0fab

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

718fa54

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

79187dc

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

5daf955

…utter#162419)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

0e1df62 Adds urlspan to support link semantics in Android (flutter/fl…

ab6f0ed

…utter#162419)

math1man mentioned this pull request Jul 30, 2025

[Android][a11y] Widgets that set Semantics.link but not Semantics.linkUrl are not described as anything #172982

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adds urlspan to support link semantics in Android #162419

Adds urlspan to support link semantics in Android #162419

Uh oh!

chunhtai commented Jan 30, 2025

Uh oh!

chunhtai Jan 30, 2025

Uh oh!

gmackall left a comment

Uh oh!

gmackall Feb 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Adds urlspan to support link semantics in Android #162419

Adds urlspan to support link semantics in Android #162419

Uh oh!

Conversation

chunhtai commented Jan 30, 2025

Pre-launch Checklist

Uh oh!

chunhtai Jan 30, 2025

Choose a reason for hiding this comment

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

gmackall Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants