Fixed the text aspect ratio #162415

gaaclarke · 2025-01-29T22:51:00Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gaaclarke · 2025-01-29T23:05:03Z

This seems to affect #162394 positively in the defined case, it doesn't completely eliminate it though.

gaaclarke · 2025-01-29T23:20:49Z

Here is animating 0.444x to 0.445x (on a branch that has the adjust uv change). It's hard to compare with other gifs since the glyphs seem to actually be growing at this boundary after the change. That's not incorrect considering we are scaling them up.

gaaclarke · 2025-01-29T23:39:34Z

Putting this into review. I'd like to see golden results but my day will probably end before we get them.

jonahwilliams · 2025-01-29T23:42:33Z

engine/src/flutter/impeller/entity/contents/text_contents_unittests.cc

+      GetContext()->GetResourceAllocator(), GetContext()->GetIdleWaiter());
+  ASSERT_TRUE(context && context->IsValid());
+  for (int i = 0; i <= 1000; ++i) {
+    Scalar font_scale = 0.440 + (i / 1000.0);


I wouldn't expect the font to maintain the same aspect ratio across larger scales, but across small values like you have here 0.5 -> 0.51 this test seems reasonable to me.

Are the results unstable on non mac platforms?

Are the results unstable on non mac platforms?

I tested it and it works fine on linux, removing the skip.

I wouldn't expect the font to maintain the same aspect ratio across larger scales, but across small values like you have here 0.5 -> 0.51 this test seems reasonable to me.

Why wouldn't you expect them to maintain the aspect ratio between positions and uvs?

oh, right. I was thinking about between uvs across scales. This makes more sense 🤦

jonahwilliams

LGTM w/ question

jonahwilliams

Still LGTM

auto-submit · 2025-01-30T18:23:53Z

autosubmit label was removed for flutter/flutter/162415, because - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-01-30T21:03:43Z

autosubmit label was removed for flutter/flutter/162415, because - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

gaaclarke · 2025-01-30T21:38:28Z

I can reproduce that flutter_tester failure locally. There is one pixel difference when generating the textures for some reason (these images were scaled 3x and given a grey background):

roboto

ahem

gaaclarke · 2025-01-30T22:07:35Z

@jonahwilliams we had 2 options to fix this, remove the 0.5 offset or add non-square uv's to mimic what we used to do but keep the same aspect ratio. I've opted to try out the first option after playing around with it. I'm not seeing any negative with my testing.

the second option

      Point uv_origin =
          (atlas_glyph_bounds.GetLeftTop() - Point(0.5, 0.5)) / atlas_size;
      // Since we are translating the UVs to cover the center of texels we will
      // expand the uv's to cover the last pixels, we don't add square pixels
      // though to maintain the same aspect ratio.
      Scalar inv_aspect_ratio = atlas_glyph_bounds.GetSize().height /
                                atlas_glyph_bounds.GetSize().width;
      Point uv_size =
          (atlas_glyph_bounds.GetSize() + Point(1, inv_aspect_ratio)) /
          atlas_size;

jonahwilliams

LGTM

justinmc · 2025-01-30T22:59:49Z

I didn't realize that Impeller was doing this kind of text stuff (thought it was still Skia), or is that a new thing?

gaaclarke · 2025-01-30T23:01:21Z

I didn't realize that Impeller was doing this kind of text stuff (thought it was still Skia), or is that a new thing?

Funny should ask! I have a doc for you: https://docs.google.com/document/d/1Rulw_noQi0G8Glb47vk17uBbb6sySDxlQe-l-0kHn14/edit?tab=t.0#heading=h.lje1se38wqjf

TLDR: We use skia to draw glyphs into a texture then we draw geometry that samples from it.

Roll Flutter from b007899 to 8e2a6fc (61 revisions) flutter/flutter@b007899...8e2a6fc 2025-02-03 [email protected] Implement hot reload using the DDC library bundle format (flutter/flutter#162498) 2025-02-01 [email protected] [Android] add lint ignores to Flutter JNI. (flutter/flutter#162527) 2025-02-01 [email protected] Fix `Linux docs_publish` running at head (flutter/flutter#162557) 2025-02-01 [email protected] [Flutter GPU] Breaking: Use exceptions for resource creation errors. (flutter/flutter#162104) 2025-02-01 [email protected] [Impeller] Increase conical gradient precision. (flutter/flutter#162543) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162542) 2025-01-31 [email protected] [web] Gracefully handle empty ui.Vertices (flutter/flutter#162461) 2025-01-31 [email protected] [web] Remove HTML build artifacts (flutter/flutter#162528) 2025-01-31 [email protected] [ Tool ] Remove use of globals from widget-preview commands (flutter/flutter#162522) 2025-01-31 [email protected] Add a special case for the Fuchsia SDK ftl.fidl file in the license script (flutter/flutter#162423) 2025-01-31 [email protected] [Impeller] Remove some unused methods from EntityPassClipStack (flutter/flutter#162478) 2025-01-31 [email protected] Reenable linux_web_engine mac tests on Mac-14 (flutter/flutter#162409) 2025-01-31 [email protected] Fix NavigationRail examples overflow alignment (flutter/flutter#159937) 2025-01-31 [email protected] Roll Skia from c1dc5033e7c9 to 4bdf90faf708 (1 revision) (flutter/flutter#162511) 2025-01-31 [email protected] Roll Skia from e0941791b86e to c1dc5033e7c9 (1 revision) (flutter/flutter#162504) 2025-01-31 [email protected] [Reland] Fix `Tab` linear and elastic animation blink (#162315) (flutter/flutter#162450) 2025-01-31 [email protected] fix syntax error in comment pseudocode (flutter/flutter#162453) 2025-01-31 [email protected] Roll Skia from ec8c632b8c7f to e0941791b86e (1 revision) (flutter/flutter#162502) 2025-01-31 [email protected] Roll Skia from a9af2a74c5ab to ec8c632b8c7f (2 revisions) (flutter/flutter#162496) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162476) 2025-01-31 [email protected] Document flutter/package deps version policy (flutter/flutter#162492) 2025-01-31 [email protected] Add iOS tool codeowner (flutter/flutter#162167) 2025-01-31 [email protected] Fixed the text aspect ratio (flutter/flutter#162415) 2025-01-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete `FlutterCommand.usageValues` (#162468)" (flutter/flutter#162494) 2025-01-31 [email protected] Add new web contributors to web triage doc. (flutter/flutter#162420) 2025-01-30 [email protected] Fix the build borked in flutter/flutter#162475. (flutter/flutter#162484) 2025-01-30 [email protected] Roll Skia from e6daf687b558 to a9af2a74c5ab (5 revisions) (flutter/flutter#162474) 2025-01-30 [email protected] Bump `Linux mac_clang_tidy" to 120m timeout (flutter/flutter#162475) 2025-01-30 [email protected] Delete `FlutterCommand.usageValues` (flutter/flutter#162468) 2025-01-30 [email protected] Fixed some floating point inaccuracies in TextContents (flutter/flutter#162351) 2025-01-30 [email protected] Limit number of retries when downloading the Dart SDK on Windows (flutter/flutter#162411) 2025-01-30 [email protected] Add FormField.errorBuilder (flutter/flutter#162255) 2025-01-30 [email protected] Fix `Checkbox` default visual density to meet Material 3 guidelines (flutter/flutter#159081) 2025-01-30 [email protected] [Android] add HC++ platform view class. (flutter/flutter#161829) 2025-01-30 [email protected] Add tests to confirm CupertinoSliverNavigationBar snaps when partially scrolled in .always bottom mode (flutter/flutter#162425) 2025-01-30 [email protected] [Impeller] Disable Vulkan on Emulators. (flutter/flutter#162454) 2025-01-30 [email protected] [FGP Kotlin conversion] Convert `Deeplink` and `IntentFilterCheck` (flutter/flutter#161835) 2025-01-30 [email protected] fix slider semantic label (flutter/flutter#162304) 2025-01-30 [email protected] Roll Skia from f22419dbed05 to e6daf687b558 (37 revisions) (flutter/flutter#162447) 2025-01-30 [email protected] Fix `flutter doctor` instructions displayed when `cmdline-tools` (Android SDK) cannot be found (flutter/flutter#162281) 2025-01-30 [email protected] remove more (simple) usage of package:usage (flutter/flutter#162354) 2025-01-30 [email protected] [Android] HC++ plumbing. (flutter/flutter#162407) 2025-01-30 [email protected] Removes dev dependencies from generated plugin registrant for non-Android platforms (flutter/flutter#161828) 2025-01-30 [email protected] Fix unexpected shown of Scrollbar (flutter/flutter#159386) 2025-01-30 [email protected] Roll package:vm_service to 15.0.0 and package:leak_tracker to 10.0.9 (flutter/flutter#162325) 2025-01-30 [email protected] Roll Fuchsia Test Scripts from r9Dc5VRF6sE3pJH20... to g6IlaYL1_wNmk3zNj... (flutter/flutter#162427) ...

flutteractionsbot · 2025-02-11T16:46:45Z

Failed to create CP due to merge conflicts.
You will need to create the PR manually. See the cherrypick wiki for more info.

This is a cherry-pick for all the changes that went into fixing #149652 It looks like a lot but most of it is testing and refactoring. ## PRs included - #161625 - #162351 - #162415 - #162555 - #162824 ## Impacted Users All users of Impeller. ## Impact Description Animating text with translations and scales can cause: - jitter between glyphs - jitter between glyphs and the baseline - artifacts when rendering glyphs at non integer scales ## Workaround Use skia. ## Risk Since this edits how text is rendered, the risk is pretty high. The actual changes are small and there are unit tests for them. Golden test coverage for cherry-picks is not complete and text rendering golden coverage for android is problematic. ## Test Coverage Yes. ## Validation Steps The reproduction code in #149652 is good.

This is a cherry-pick for all the changes that went into fixing flutter#149652 It looks like a lot but most of it is testing and refactoring. - flutter#161625 - flutter#162351 - flutter#162415 - flutter#162555 - flutter#162824 All users of Impeller. Animating text with translations and scales can cause: - jitter between glyphs - jitter between glyphs and the baseline - artifacts when rendering glyphs at non integer scales Use skia. Since this edits how text is rendered, the risk is pretty high. The actual changes are small and there are unit tests for them. Golden test coverage for cherry-picks is not complete and text rendering golden coverage for android is problematic. Yes. The reproduction code in flutter#149652 is good.

This is a cherry-pick for all the changes that went into fixing flutter/flutter#149652 It looks like a lot but most of it is testing and refactoring. ## PRs included - flutter/flutter#161625 - flutter/flutter#162351 - flutter/flutter#162415 - flutter/flutter#162555 - flutter/flutter#162824 ## Impacted Users All users of Impeller. ## Impact Description Animating text with translations and scales can cause: - jitter between glyphs - jitter between glyphs and the baseline - artifacts when rendering glyphs at non integer scales ## Workaround Use skia. ## Risk Since this edits how text is rendered, the risk is pretty high. The actual changes are small and there are unit tests for them. Golden test coverage for cherry-picks is not complete and text rendering golden coverage for android is problematic. ## Test Coverage Yes. ## Validation Steps The reproduction code in flutter/flutter#149652 is good.

Roll Flutter from b007899 to 8e2a6fc (61 revisions) flutter/flutter@b007899...8e2a6fc 2025-02-03 [email protected] Implement hot reload using the DDC library bundle format (flutter/flutter#162498) 2025-02-01 [email protected] [Android] add lint ignores to Flutter JNI. (flutter/flutter#162527) 2025-02-01 [email protected] Fix `Linux docs_publish` running at head (flutter/flutter#162557) 2025-02-01 [email protected] [Flutter GPU] Breaking: Use exceptions for resource creation errors. (flutter/flutter#162104) 2025-02-01 [email protected] [Impeller] Increase conical gradient precision. (flutter/flutter#162543) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162542) 2025-01-31 [email protected] [web] Gracefully handle empty ui.Vertices (flutter/flutter#162461) 2025-01-31 [email protected] [web] Remove HTML build artifacts (flutter/flutter#162528) 2025-01-31 [email protected] [ Tool ] Remove use of globals from widget-preview commands (flutter/flutter#162522) 2025-01-31 [email protected] Add a special case for the Fuchsia SDK ftl.fidl file in the license script (flutter/flutter#162423) 2025-01-31 [email protected] [Impeller] Remove some unused methods from EntityPassClipStack (flutter/flutter#162478) 2025-01-31 [email protected] Reenable linux_web_engine mac tests on Mac-14 (flutter/flutter#162409) 2025-01-31 [email protected] Fix NavigationRail examples overflow alignment (flutter/flutter#159937) 2025-01-31 [email protected] Roll Skia from c1dc5033e7c9 to 4bdf90faf708 (1 revision) (flutter/flutter#162511) 2025-01-31 [email protected] Roll Skia from e0941791b86e to c1dc5033e7c9 (1 revision) (flutter/flutter#162504) 2025-01-31 [email protected] [Reland] Fix `Tab` linear and elastic animation blink (#162315) (flutter/flutter#162450) 2025-01-31 [email protected] fix syntax error in comment pseudocode (flutter/flutter#162453) 2025-01-31 [email protected] Roll Skia from ec8c632b8c7f to e0941791b86e (1 revision) (flutter/flutter#162502) 2025-01-31 [email protected] Roll Skia from a9af2a74c5ab to ec8c632b8c7f (2 revisions) (flutter/flutter#162496) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162476) 2025-01-31 [email protected] Document flutter/package deps version policy (flutter/flutter#162492) 2025-01-31 [email protected] Add iOS tool codeowner (flutter/flutter#162167) 2025-01-31 [email protected] Fixed the text aspect ratio (flutter/flutter#162415) 2025-01-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete `FlutterCommand.usageValues` (#162468)" (flutter/flutter#162494) 2025-01-31 [email protected] Add new web contributors to web triage doc. (flutter/flutter#162420) 2025-01-30 [email protected] Fix the build borked in flutter/flutter#162475. (flutter/flutter#162484) 2025-01-30 [email protected] Roll Skia from e6daf687b558 to a9af2a74c5ab (5 revisions) (flutter/flutter#162474) 2025-01-30 [email protected] Bump `Linux mac_clang_tidy" to 120m timeout (flutter/flutter#162475) 2025-01-30 [email protected] Delete `FlutterCommand.usageValues` (flutter/flutter#162468) 2025-01-30 [email protected] Fixed some floating point inaccuracies in TextContents (flutter/flutter#162351) 2025-01-30 [email protected] Limit number of retries when downloading the Dart SDK on Windows (flutter/flutter#162411) 2025-01-30 [email protected] Add FormField.errorBuilder (flutter/flutter#162255) 2025-01-30 [email protected] Fix `Checkbox` default visual density to meet Material 3 guidelines (flutter/flutter#159081) 2025-01-30 [email protected] [Android] add HC++ platform view class. (flutter/flutter#161829) 2025-01-30 [email protected] Add tests to confirm CupertinoSliverNavigationBar snaps when partially scrolled in .always bottom mode (flutter/flutter#162425) 2025-01-30 [email protected] [Impeller] Disable Vulkan on Emulators. (flutter/flutter#162454) 2025-01-30 [email protected] [FGP Kotlin conversion] Convert `Deeplink` and `IntentFilterCheck` (flutter/flutter#161835) 2025-01-30 [email protected] fix slider semantic label (flutter/flutter#162304) 2025-01-30 [email protected] Roll Skia from f22419dbed05 to e6daf687b558 (37 revisions) (flutter/flutter#162447) 2025-01-30 [email protected] Fix `flutter doctor` instructions displayed when `cmdline-tools` (Android SDK) cannot be found (flutter/flutter#162281) 2025-01-30 [email protected] remove more (simple) usage of package:usage (flutter/flutter#162354) 2025-01-30 [email protected] [Android] HC++ plumbing. (flutter/flutter#162407) 2025-01-30 [email protected] Removes dev dependencies from generated plugin registrant for non-Android platforms (flutter/flutter#161828) 2025-01-30 [email protected] Fix unexpected shown of Scrollbar (flutter/flutter#159386) 2025-01-30 [email protected] Roll package:vm_service to 15.0.0 and package:leak_tracker to 10.0.9 (flutter/flutter#162325) 2025-01-30 [email protected] Roll Fuchsia Test Scripts from r9Dc5VRF6sE3pJH20... to g6IlaYL1_wNmk3zNj... (flutter/flutter#162427) ...

github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jan 29, 2025

gaaclarke mentioned this pull request Jan 29, 2025

[Impeller] glyphs sometimes have artifacts at certain scales #162394

Open

Fixed the text aspect ratio

c8c7b5b

gaaclarke force-pushed the fix-text-aspect-ratio branch from f0a8f9e to c8c7b5b Compare January 29, 2025 23:37

gaaclarke requested review from bdero and jonahwilliams January 29, 2025 23:38

jonahwilliams reviewed Jan 29, 2025

View reviewed changes

jonahwilliams approved these changes Jan 29, 2025

View reviewed changes

removed linux exception

ff0941d

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

jonahwilliams approved these changes Jan 30, 2025

View reviewed changes

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

gaaclarke mentioned this pull request Jan 30, 2025

[Impeller] Jittery glyphs when animating text transformation #149652

Closed

updated old tests to match new uv math

5df009f

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

gaaclarke added 2 commits January 30, 2025 14:12

I'm removing the 0.5 offset too

345869c

updated tests from 0.5 change

31f3dfc

jonahwilliams approved these changes Jan 30, 2025

View reviewed changes

engine-flutter-autoroll mentioned this pull request Jan 31, 2025

Roll Flutter from b007899d3a7a to 683096002da9 (48 revisions) flutter/packages#8541

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025

3c5ae1e Fixed the text aspect ratio (flutter/flutter#162415)

1361584

engine-flutter-autoroll mentioned this pull request Jan 31, 2025

Roll Flutter from b007899d3a7a to 1416381eccb3 (49 revisions) flutter/packages#8543

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025

3c5ae1e Fixed the text aspect ratio (flutter/flutter#162415)

6c0d36b

engine-flutter-autoroll mentioned this pull request Feb 1, 2025

Roll Flutter from b007899d3a7a to f56d5a98c1da (59 revisions) flutter/packages#8547

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025

3c5ae1e Fixed the text aspect ratio (flutter/flutter#162415)

52e8f68

engine-flutter-autoroll mentioned this pull request Feb 1, 2025

Roll Flutter from b007899d3a7a to f56d5a98c1da (59 revisions) flutter/packages#8548

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025

3c5ae1e Fixed the text aspect ratio (flutter/flutter#162415)

d249b2a

engine-flutter-autoroll mentioned this pull request Feb 2, 2025

Roll Flutter from b007899d3a7a to 4d08217f8dca (60 revisions) flutter/packages#8549

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025

3c5ae1e Fixed the text aspect ratio (flutter/flutter#162415)

612df50

engine-flutter-autoroll mentioned this pull request Feb 2, 2025

Roll Flutter from b007899d3a7a to 4d08217f8dca (60 revisions) flutter/packages#8550

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025

3c5ae1e Fixed the text aspect ratio (flutter/flutter#162415)

35e3064

engine-flutter-autoroll mentioned this pull request Feb 3, 2025

Roll Flutter from b007899d3a7a to 8e2a6fc3fd2c (61 revisions) flutter/packages#8554

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025

3c5ae1e Fixed the text aspect ratio (flutter/flutter#162415)

a1b67a0

engine-flutter-autoroll mentioned this pull request Feb 3, 2025

Roll Flutter from b007899d3a7a to 8e2a6fc3fd2c (61 revisions) flutter/packages#8556

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025

3c5ae1e Fixed the text aspect ratio (flutter/flutter#162415)

616d5c5

gaaclarke added the cp: beta cherry pick this pull request to beta release candidate branch label Feb 11, 2025

gaaclarke mentioned this pull request Feb 11, 2025

[CP] all jittery glyph fixes #163058

Merged

9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

3c5ae1e Fixed the text aspect ratio (flutter/flutter#162415)

e9d8af2

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

3c5ae1e Fixed the text aspect ratio (flutter/flutter#162415)

e878b9d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

3c5ae1e Fixed the text aspect ratio (flutter/flutter#162415)

1d2fc53

Fixed the text aspect ratio #162415

Fixed the text aspect ratio #162415

Uh oh!

Conversation

gaaclarke commented Jan 29, 2025

Pre-launch Checklist

Uh oh!

gaaclarke commented Jan 29, 2025

Uh oh!

gaaclarke commented Jan 29, 2025

Uh oh!

gaaclarke commented Jan 29, 2025

Uh oh!

jonahwilliams Jan 29, 2025

Choose a reason for hiding this comment

Uh oh!

gaaclarke Jan 30, 2025

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Jan 30, 2025

Choose a reason for hiding this comment

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 30, 2025

Uh oh!

auto-submit bot commented Jan 30, 2025

Uh oh!

gaaclarke commented Jan 30, 2025

roboto

ahem

Uh oh!

gaaclarke commented Jan 30, 2025

the second option

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc commented Jan 30, 2025

Uh oh!

gaaclarke commented Jan 30, 2025

Uh oh!

flutteractionsbot commented Feb 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants