-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Reverts "Started adjusting uvs to match pixel snapping. (#162049)" #162392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverts "Started adjusting uvs to match pixel snapping. (#162049)" #162392
Conversation
This reverts commit dc580af.
|
Hey @mdebbar, why was this removed from the merge queue? Looks like another PR got hung on CI. Am I free to put this back into the merge queue? |
Please wait for now. All PRs added to the Merge Queue are getting stuck. Something wrong with the windows bots. We are looking into it. |
…ter#162049)" (flutter#162392)" This reverts some of commit d048c77, just the testing parts.
Reverts: #162049
Initiated by: gaaclarke
Reason for reverting: Negatively affected Android rendering ( #162361)
Original PR Author: gaaclarke
Reviewed By: {jonahwilliams}
This change reverts the following previous change:
issue: #149652
doc: (currently google only) https://docs.google.com/document/d/1Rulw_noQi0G8Glb47vk17uBbb6sySDxlQe-l-0kHn14/edit?tab=t.0
This increases the RMSE value in the test in #161445 by a slight amount. I do believe this reduces the time where we get non uniform scalars and protects the integrity of relative spacing, thus being more what we expect. There is still a bug that has to do with pixel alignment that does give the illusion of stretching and shrinking though because of hard/soft lines.
Before
ondevice.mov
After
adjustuvs.mov
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.