Adds semantics role checks #162290
Merged
Adds semantics role checks #162290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
chunhtai
force-pushed
the
issues/161346
branch
from
232fabc to
8ea2a7d
Compare
hannah-hyj
approved these changes
Jan 28, 2025
Member
hannah-hyj
left a comment
hannah-hyj
left a comment
There was a problem hiding this comment.
LGTM with some comments on tests
| expect(SemanticsRole.values.toSet(), DebugSemanticsRoleChecks.kChecks.keys.toSet()); | ||
| }); | ||
|
|
||
| group('tab', () { |
| child: Semantics(role: SemanticsRole.tab, child: const Text('a tab')), | ||
| ), | ||
| ); | ||
| expect(tester.takeException(), isFlutterError); |
Member
There was a problem hiding this comment.
can you also expect the error string here, so it will be more clear
| }); | ||
| }); | ||
|
|
||
| group('tabBar', () { |
Member
There was a problem hiding this comment.
ditto, add a successful case too
| /// to [kChecks]. | ||
| @visibleForTesting | ||
| class DebugSemanticsRoleChecks { | ||
| DebugSemanticsRoleChecks._(); |
Contributor
There was a problem hiding this comment.
Drive-by comment: this can be a final class ? Then DebugSemanticsRoleChecks._(); is not needed.
Contributor
Author
There was a problem hiding this comment.
final class can still be instantiated I think? I use sealed instead
Contributor
There was a problem hiding this comment.
Yeah, you're right, I had to double check the class modifiers reference :)
But yeah, we should be able to eliminate the constructor anyway
chunhtai
force-pushed
the
issues/161346
branch
from
b5b9232 to
956fb4a
Compare
chunhtai
force-pushed
the
issues/161346
branch
from
956fb4a to
24ebf55
Compare
github-actions
bot
added
f: material design
chunhtai
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/162290, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
chunhtai
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 31, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 31, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test and error detection system for semantics roles.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.