Fix tests to prepare for `--explicit-package-dependencies` and a bug. #162289

matanlurey · 2025-01-27T23:44:46Z

@camsim99 discovered these would fail here: #161826 (comment).

This fixes in preparation for the flag flipping, and also fixes a bug in resolving synthetic-package I missed (it can't be true if --explicit-package-dependencies is set).

matanlurey · 2025-01-27T23:46:56Z

(My tests may fail unrelated to this PR as I'm dog-fooding a new CI optimization at the same time)

camsim99 · 2025-01-28T00:09:52Z

packages/flutter_tools/lib/src/commands/generate_localizations.dart

    argParser.addFlag(
      'synthetic-package',
-      defaultsTo: true,
+      defaultsTo: !featureFlags.isExplicitPackageDependenciesEnabled,


Can you explain at a high level why synthetic-package and --enable-explicit-dependencies conflict in this way? I can imagine it's something to do with the synthetic nature of synthetic packages and the explicit nature of explicit dependencies, but I assume you can answer this question faster than I can interpret the test changes without this context :)

Sure.

The simplest answer is "it was too hard", or rather, the flutter_gen-based path made assumptions of plugins that were difficult to change, and given the fact flutter_gen was a feature we generally regretted, it made sense to sunset the feature to unlock this one.

We could have deprecated synthetic packages first, but it would mean adding another quarter to the release process. I think if we had faster releases I would have probably kept the features totally separate and have already removed package:flutter_gen.

https://docs.flutter.dev/release/breaking-changes/flutter-generate-i10n-source for more.

camsim99

Gotcha. Thanks for looking into this!

auto-submit · 2025-01-28T17:48:57Z

autosubmit label was removed for flutter/flutter/162289, because - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-01-28T18:04:56Z

autosubmit label was removed for flutter/flutter/162289, because - The status or check suite Linux_android_emu_34 android views has failed. Please fix the issues identified (or deflake) before re-applying this label.

…d a bug. (flutter/flutter#162289)

Roll Flutter from c1ffaa9 to b007899 (43 revisions) flutter/flutter@c1ffaa9...b007899 2025-01-29 [email protected] Fix `Tab` linear and elastic animation blink (flutter/flutter#162315) 2025-01-29 [email protected] Pass-through `textInputAction` in `DropdownMenu` (flutter/flutter#162309) 2025-01-29 [email protected] Fix scrollUntilVisible in WidgetTester (flutter/flutter#159582) 2025-01-29 [email protected] Pass-through `maxLines` in `DropdownMenu` (flutter/flutter#161903) 2025-01-29 [email protected] fix: appbar leading width is not square for custom toolbar height (flutter/flutter#161880) 2025-01-29 [email protected] [DisplayList] Don't call Skia Ganesh methods when its not available. (flutter/flutter#162345) 2025-01-29 [email protected] Update README.md to include googler post verification steps (flutter/flutter#162272) 2025-01-29 [email protected] [engine, web] return switch expressions in many places (flutter/flutter#162336) 2025-01-29 [email protected] Update README.md to not have engine link for android (flutter/flutter#162330) 2025-01-29 [email protected] Reland "[ Widget Previews ] Add support for detecting previews and generating code (#161911)"" (flutter/flutter#162337) 2025-01-29 [email protected] Add instructions to download the Gradle wrapper to FGP readme, and add to gitignore (flutter/flutter#162332) 2025-01-29 [email protected] Fix tests to prepare for `--explicit-package-dependencies` and a bug. (flutter/flutter#162289) 2025-01-29 [email protected] Add a currently unused `runs_in_merge_queue` property to `Linux analyze`. (flutter/flutter#162335) 2025-01-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Widget Previews ] Add support for detecting previews and generating code (#161911)" (flutter/flutter#162327) 2025-01-28 [email protected] Support hot restart for DDC library bundle format (flutter/flutter#162123) 2025-01-28 [email protected] Started adjusting uvs to match pixel snapping. (flutter/flutter#162049) 2025-01-28 [email protected] Refactor code inside flutter.groovy (flutter/flutter#160250) 2025-01-28 [email protected] Table implements redepth (flutter/flutter#162282) 2025-01-28 [email protected] [ Widget Previews ] Add support for detecting previews and generating code (flutter/flutter#161911) 2025-01-28 [email protected] remove dependency on `Usage` from `Pub` class (flutter/flutter#162279) 2025-01-28 [email protected] Roll Packages from 258f6dc to 02c6fef (6 revisions) (flutter/flutter#162313) 2025-01-28 [email protected] Remove `scenario_app/android` and rename to `ios_scenario_app`. (flutter/flutter#160992) 2025-01-28 [email protected] Apparently it is illegal to use `stderr` in this project. (flutter/flutter#162294) 2025-01-28 [email protected] Fix update_engine_version_test in presence of FLUTTER_PREBUILT_ENGINE_VERSION env vars. (flutter/flutter#162270) 2025-01-28 [email protected] Add missing `properties: ...` and move to presubmit. (flutter/flutter#162170) 2025-01-27 [email protected] [Impeller] make swapchain related external fence/semaphore extensions optional. (flutter/flutter#162205) 2025-01-27 49699333+dependabot[bot]@users.noreply.github.com Bump the all-github-actions group with 2 updates (flutter/flutter#162277) 2025-01-27 [email protected] Don't depend on Dart from FML. (flutter/flutter#162271) 2025-01-27 [email protected] [DisplayList] Move nested canvas enums into their own TU. (flutter/flutter#162037) 2025-01-27 [email protected] Avoid iOS text selection crash by returning nil range (flutter/flutter#161996) 2025-01-27 [email protected] fix `felt` link to point to flutter repo instead of the engine repo (flutter/flutter#161423) 2025-01-27 [email protected] Enable the Android Engine OpenGLES/Vulkan suites. (flutter/flutter#162258) 2025-01-27 [email protected] [canvaskit] Fix debug build for CanvasKit (flutter/flutter#162198) 2025-01-27 [email protected] Roll Packages from 3d3ab7b to 258f6dc (19 revisions) (flutter/flutter#162254) 2025-01-25 [email protected] Pin `customer_testing` to the SHA specified in `tests.version` (flutter/flutter#162048) 2025-01-25 [email protected] Formalize `update_engine_version.{sh|ps1}`. (flutter/flutter#162118) 2025-01-25 [email protected] Rename 'SelectionChangedCause.scribble' to 'SelectionChangedCause.stylusHandwriting' (flutter/flutter#161518) 2025-01-25 [email protected] Don't install xcode when doing `local_engine` web builds on mac. (flutter/flutter#162164) 2025-01-25 [email protected] Force Impeller backend for `android_engine_test`, and test both OpenGLES and Vulkan (flutter/flutter#162089) 2025-01-24 [email protected] [Impeller] when a command pool has many unused buffers, reset with release resources flag. (flutter/flutter#162171) 2025-01-24 [email protected] [web] Remove HTML renderer from framework tests (flutter/flutter#162038) 2025-01-24 [email protected] [Impeller] Skip clip entity replay that cannot impact current clip. (flutter/flutter#162113) 2025-01-24 [email protected] Update Android integration test package for newer AGP (flutter/flutter#161856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ...

…d a bug. (flutter/flutter#162289)

Roll Flutter from c1ffaa9 to b007899 (43 revisions) flutter/flutter@c1ffaa9...b007899 2025-01-29 [email protected] Fix `Tab` linear and elastic animation blink (flutter/flutter#162315) 2025-01-29 [email protected] Pass-through `textInputAction` in `DropdownMenu` (flutter/flutter#162309) 2025-01-29 [email protected] Fix scrollUntilVisible in WidgetTester (flutter/flutter#159582) 2025-01-29 [email protected] Pass-through `maxLines` in `DropdownMenu` (flutter/flutter#161903) 2025-01-29 [email protected] fix: appbar leading width is not square for custom toolbar height (flutter/flutter#161880) 2025-01-29 [email protected] [DisplayList] Don't call Skia Ganesh methods when its not available. (flutter/flutter#162345) 2025-01-29 [email protected] Update README.md to include googler post verification steps (flutter/flutter#162272) 2025-01-29 [email protected] [engine, web] return switch expressions in many places (flutter/flutter#162336) 2025-01-29 [email protected] Update README.md to not have engine link for android (flutter/flutter#162330) 2025-01-29 [email protected] Reland "[ Widget Previews ] Add support for detecting previews and generating code (#161911)"" (flutter/flutter#162337) 2025-01-29 [email protected] Add instructions to download the Gradle wrapper to FGP readme, and add to gitignore (flutter/flutter#162332) 2025-01-29 [email protected] Fix tests to prepare for `--explicit-package-dependencies` and a bug. (flutter/flutter#162289) 2025-01-29 [email protected] Add a currently unused `runs_in_merge_queue` property to `Linux analyze`. (flutter/flutter#162335) 2025-01-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Widget Previews ] Add support for detecting previews and generating code (#161911)" (flutter/flutter#162327) 2025-01-28 [email protected] Support hot restart for DDC library bundle format (flutter/flutter#162123) 2025-01-28 [email protected] Started adjusting uvs to match pixel snapping. (flutter/flutter#162049) 2025-01-28 [email protected] Refactor code inside flutter.groovy (flutter/flutter#160250) 2025-01-28 [email protected] Table implements redepth (flutter/flutter#162282) 2025-01-28 [email protected] [ Widget Previews ] Add support for detecting previews and generating code (flutter/flutter#161911) 2025-01-28 [email protected] remove dependency on `Usage` from `Pub` class (flutter/flutter#162279) 2025-01-28 [email protected] Roll Packages from 258f6dc to 02c6fef (6 revisions) (flutter/flutter#162313) 2025-01-28 [email protected] Remove `scenario_app/android` and rename to `ios_scenario_app`. (flutter/flutter#160992) 2025-01-28 [email protected] Apparently it is illegal to use `stderr` in this project. (flutter/flutter#162294) 2025-01-28 [email protected] Fix update_engine_version_test in presence of FLUTTER_PREBUILT_ENGINE_VERSION env vars. (flutter/flutter#162270) 2025-01-28 [email protected] Add missing `properties: ...` and move to presubmit. (flutter/flutter#162170) 2025-01-27 [email protected] [Impeller] make swapchain related external fence/semaphore extensions optional. (flutter/flutter#162205) 2025-01-27 49699333+dependabot[bot]@users.noreply.github.com Bump the all-github-actions group with 2 updates (flutter/flutter#162277) 2025-01-27 [email protected] Don't depend on Dart from FML. (flutter/flutter#162271) 2025-01-27 [email protected] [DisplayList] Move nested canvas enums into their own TU. (flutter/flutter#162037) 2025-01-27 [email protected] Avoid iOS text selection crash by returning nil range (flutter/flutter#161996) 2025-01-27 [email protected] fix `felt` link to point to flutter repo instead of the engine repo (flutter/flutter#161423) 2025-01-27 [email protected] Enable the Android Engine OpenGLES/Vulkan suites. (flutter/flutter#162258) 2025-01-27 [email protected] [canvaskit] Fix debug build for CanvasKit (flutter/flutter#162198) 2025-01-27 [email protected] Roll Packages from 3d3ab7b to 258f6dc (19 revisions) (flutter/flutter#162254) 2025-01-25 [email protected] Pin `customer_testing` to the SHA specified in `tests.version` (flutter/flutter#162048) 2025-01-25 [email protected] Formalize `update_engine_version.{sh|ps1}`. (flutter/flutter#162118) 2025-01-25 [email protected] Rename 'SelectionChangedCause.scribble' to 'SelectionChangedCause.stylusHandwriting' (flutter/flutter#161518) 2025-01-25 [email protected] Don't install xcode when doing `local_engine` web builds on mac. (flutter/flutter#162164) 2025-01-25 [email protected] Force Impeller backend for `android_engine_test`, and test both OpenGLES and Vulkan (flutter/flutter#162089) 2025-01-24 [email protected] [Impeller] when a command pool has many unused buffers, reset with release resources flag. (flutter/flutter#162171) 2025-01-24 [email protected] [web] Remove HTML renderer from framework tests (flutter/flutter#162038) 2025-01-24 [email protected] [Impeller] Skip clip entity replay that cannot impact current clip. (flutter/flutter#162113) 2025-01-24 [email protected] Update Android integration test package for newer AGP (flutter/flutter#161856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ...

Fix tests to prepare for --explicit-package-dependencies and a bug.

8e1476a

matanlurey requested a review from camsim99 January 27, 2025 23:44

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 27, 2025

matanlurey mentioned this pull request Jan 27, 2025

[Android] Fix integration test to check if dev dependencies are removed from release builds + address no non-dev dependency plugin edge case #161826

Merged

9 tasks

camsim99 reviewed Jan 28, 2025

View reviewed changes

camsim99 approved these changes Jan 28, 2025

View reviewed changes

++

4fac9f2

matanlurey force-pushed the fix-tests-and-fix-bug branch from dc1afb0 to 4fac9f2 Compare January 28, 2025 00:31

This was referenced Jan 28, 2025

DO NOT SUBMIT (testing) #162284

Closed

Enable framework-only PR optimizations. flutter/cocoon#4190

Merged

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2025

++

478af92

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2025

Merge remote-tracking branch 'upstream/main' into fix-tests-and-fix-bug

6088cea

matanlurey force-pushed the fix-tests-and-fix-bug branch from 8cc4098 to 6088cea Compare January 28, 2025 17:53

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2025

Merge branch 'master' into fix-tests-and-fix-bug

93a40c8

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2025

auto-submit bot added this pull request to the merge queue Jan 29, 2025

Merged via the queue into flutter:master with commit 8b9b6a3 Jan 29, 2025
139 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 29, 2025

engine-flutter-autoroll mentioned this pull request Jan 29, 2025

Roll Flutter from c1ffaa9d9deb to b007899d3a7a (43 revisions) flutter/packages#8527

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2025

8b9b6a3 Fix tests to prepare for --explicit-package-dependencies an…

8cc9ec6

…d a bug. (flutter/flutter#162289)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

8b9b6a3 Fix tests to prepare for --explicit-package-dependencies an…

dbf8e3d

…d a bug. (flutter/flutter#162289)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

8b9b6a3 Fix tests to prepare for --explicit-package-dependencies an…

c96cb11

…d a bug. (flutter/flutter#162289)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

8b9b6a3 Fix tests to prepare for --explicit-package-dependencies an…

2854ca7

…d a bug. (flutter/flutter#162289)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix tests to prepare for `--explicit-package-dependencies` and a bug. #162289

Fix tests to prepare for `--explicit-package-dependencies` and a bug. #162289

Uh oh!

matanlurey commented Jan 27, 2025

Uh oh!

matanlurey commented Jan 27, 2025

Uh oh!

camsim99 Jan 28, 2025

Uh oh!

matanlurey Jan 28, 2025

Uh oh!

camsim99 left a comment

Uh oh!

auto-submit bot commented Jan 28, 2025

Uh oh!

auto-submit bot commented Jan 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix tests to prepare for --explicit-package-dependencies and a bug. #162289

Fix tests to prepare for --explicit-package-dependencies and a bug. #162289

Uh oh!

Conversation

matanlurey commented Jan 27, 2025

Uh oh!

matanlurey commented Jan 27, 2025

Uh oh!

camsim99 Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 28, 2025

Uh oh!

auto-submit bot commented Jan 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix tests to prepare for `--explicit-package-dependencies` and a bug. #162289

Fix tests to prepare for `--explicit-package-dependencies` and a bug. #162289