Add FormField.errorBuilder #162255

bleroux · 2025-01-27T15:09:14Z

Description

This PR adds the TextFormField.errorBuilderproperty which makes it possible to customize the widget used to display the error message.

Implementation based on #156275 (comment)

Related Issue

Fixes Unable to use validator along with error widget in TextFormField
Fixes #135292

Tests

Adds 1 tests.

nate-thegrate

Thanks so much for doing this!

I had a few random thoughts to share, but overall it looks phenomenal.

packages/flutter/lib/src/material/text_form_field.dart

packages/flutter/test/material/text_form_field_test.dart

packages/flutter/lib/src/material/text_form_field.dart

nate-thegrate

Just 1 small suggestion from me 😄

(and it looks like a couple of checks failed, hopefully debugging won't be too bad!)

packages/flutter/lib/src/material/text_form_field.dart

nate-thegrate · 2025-01-28T19:40:43Z

it looks like a couple of checks failed

Never mind, infra failure!

packages/flutter/lib/src/material/dropdown.dart

justinmc

Thanks for following up with this. After seeing this final PR I'm glad we're taking this approach instead of #156275.

Some questions but otherwise the code looks great.

packages/flutter/lib/src/widgets/form.dart

packages/flutter/test/material/dropdown_form_field_test.dart

packages/flutter/test/material/text_form_field_test.dart

nate-thegrate

LGTM, but I'll defer to Justin for an approval :)

justinmc

LGTM 👍

Roll Flutter from b007899 to 8e2a6fc (61 revisions) flutter/flutter@b007899...8e2a6fc 2025-02-03 [email protected] Implement hot reload using the DDC library bundle format (flutter/flutter#162498) 2025-02-01 [email protected] [Android] add lint ignores to Flutter JNI. (flutter/flutter#162527) 2025-02-01 [email protected] Fix `Linux docs_publish` running at head (flutter/flutter#162557) 2025-02-01 [email protected] [Flutter GPU] Breaking: Use exceptions for resource creation errors. (flutter/flutter#162104) 2025-02-01 [email protected] [Impeller] Increase conical gradient precision. (flutter/flutter#162543) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162542) 2025-01-31 [email protected] [web] Gracefully handle empty ui.Vertices (flutter/flutter#162461) 2025-01-31 [email protected] [web] Remove HTML build artifacts (flutter/flutter#162528) 2025-01-31 [email protected] [ Tool ] Remove use of globals from widget-preview commands (flutter/flutter#162522) 2025-01-31 [email protected] Add a special case for the Fuchsia SDK ftl.fidl file in the license script (flutter/flutter#162423) 2025-01-31 [email protected] [Impeller] Remove some unused methods from EntityPassClipStack (flutter/flutter#162478) 2025-01-31 [email protected] Reenable linux_web_engine mac tests on Mac-14 (flutter/flutter#162409) 2025-01-31 [email protected] Fix NavigationRail examples overflow alignment (flutter/flutter#159937) 2025-01-31 [email protected] Roll Skia from c1dc5033e7c9 to 4bdf90faf708 (1 revision) (flutter/flutter#162511) 2025-01-31 [email protected] Roll Skia from e0941791b86e to c1dc5033e7c9 (1 revision) (flutter/flutter#162504) 2025-01-31 [email protected] [Reland] Fix `Tab` linear and elastic animation blink (#162315) (flutter/flutter#162450) 2025-01-31 [email protected] fix syntax error in comment pseudocode (flutter/flutter#162453) 2025-01-31 [email protected] Roll Skia from ec8c632b8c7f to e0941791b86e (1 revision) (flutter/flutter#162502) 2025-01-31 [email protected] Roll Skia from a9af2a74c5ab to ec8c632b8c7f (2 revisions) (flutter/flutter#162496) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162476) 2025-01-31 [email protected] Document flutter/package deps version policy (flutter/flutter#162492) 2025-01-31 [email protected] Add iOS tool codeowner (flutter/flutter#162167) 2025-01-31 [email protected] Fixed the text aspect ratio (flutter/flutter#162415) 2025-01-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete `FlutterCommand.usageValues` (#162468)" (flutter/flutter#162494) 2025-01-31 [email protected] Add new web contributors to web triage doc. (flutter/flutter#162420) 2025-01-30 [email protected] Fix the build borked in flutter/flutter#162475. (flutter/flutter#162484) 2025-01-30 [email protected] Roll Skia from e6daf687b558 to a9af2a74c5ab (5 revisions) (flutter/flutter#162474) 2025-01-30 [email protected] Bump `Linux mac_clang_tidy" to 120m timeout (flutter/flutter#162475) 2025-01-30 [email protected] Delete `FlutterCommand.usageValues` (flutter/flutter#162468) 2025-01-30 [email protected] Fixed some floating point inaccuracies in TextContents (flutter/flutter#162351) 2025-01-30 [email protected] Limit number of retries when downloading the Dart SDK on Windows (flutter/flutter#162411) 2025-01-30 [email protected] Add FormField.errorBuilder (flutter/flutter#162255) 2025-01-30 [email protected] Fix `Checkbox` default visual density to meet Material 3 guidelines (flutter/flutter#159081) 2025-01-30 [email protected] [Android] add HC++ platform view class. (flutter/flutter#161829) 2025-01-30 [email protected] Add tests to confirm CupertinoSliverNavigationBar snaps when partially scrolled in .always bottom mode (flutter/flutter#162425) 2025-01-30 [email protected] [Impeller] Disable Vulkan on Emulators. (flutter/flutter#162454) 2025-01-30 [email protected] [FGP Kotlin conversion] Convert `Deeplink` and `IntentFilterCheck` (flutter/flutter#161835) 2025-01-30 [email protected] fix slider semantic label (flutter/flutter#162304) 2025-01-30 [email protected] Roll Skia from f22419dbed05 to e6daf687b558 (37 revisions) (flutter/flutter#162447) 2025-01-30 [email protected] Fix `flutter doctor` instructions displayed when `cmdline-tools` (Android SDK) cannot be found (flutter/flutter#162281) 2025-01-30 [email protected] remove more (simple) usage of package:usage (flutter/flutter#162354) 2025-01-30 [email protected] [Android] HC++ plumbing. (flutter/flutter#162407) 2025-01-30 [email protected] Removes dev dependencies from generated plugin registrant for non-Android platforms (flutter/flutter#161828) 2025-01-30 [email protected] Fix unexpected shown of Scrollbar (flutter/flutter#159386) 2025-01-30 [email protected] Roll package:vm_service to 15.0.0 and package:leak_tracker to 10.0.9 (flutter/flutter#162325) 2025-01-30 [email protected] Roll Fuchsia Test Scripts from r9Dc5VRF6sE3pJH20... to g6IlaYL1_wNmk3zNj... (flutter/flutter#162427) ...

github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jan 27, 2025

bleroux requested review from justinmc and nate-thegrate January 27, 2025 20:50

nate-thegrate reviewed Jan 27, 2025

View reviewed changes

bleroux force-pushed the add_TextFormField_errorBuillder branch from 79bf81a to 2fde563 Compare January 28, 2025 09:15

bleroux changed the title ~~Add TextFormField.errorBuilder~~ Add FormField.errorBuilder Jan 28, 2025

bleroux force-pushed the add_TextFormField_errorBuillder branch from 2fde563 to e0a49cc Compare January 28, 2025 11:47

nate-thegrate reviewed Jan 28, 2025

View reviewed changes

packages/flutter/lib/src/material/text_form_field.dart Outdated Show resolved Hide resolved

nate-thegrate reviewed Jan 28, 2025

View reviewed changes

packages/flutter/lib/src/material/dropdown.dart Show resolved Hide resolved

justinmc reviewed Jan 28, 2025

View reviewed changes

bleroux added 3 commits January 29, 2025 09:07

Add TextFormField.errorBuilder

94749bc

Define errorBuilder at FormField level

a742626

Add BuildContext to errorBuilder + nits

bbdd550

bleroux force-pushed the add_TextFormField_errorBuillder branch from e0a49cc to bbdd550 Compare January 29, 2025 08:24

bleroux requested review from justinmc and nate-thegrate January 29, 2025 13:04

nate-thegrate reviewed Jan 30, 2025

View reviewed changes

justinmc approved these changes Jan 30, 2025

View reviewed changes

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

auto-submit bot added this pull request to the merge queue Jan 30, 2025

Merged via the queue into flutter:master with commit 3b7c4aa Jan 30, 2025
77 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

bleroux deleted the add_TextFormField_errorBuillder branch January 30, 2025 21:59

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025

3b7c4aa Add FormField.errorBuilder (flutter/flutter#162255)

2ab7b18

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025

3b7c4aa Add FormField.errorBuilder (flutter/flutter#162255)

ed1922a

Piinks mentioned this pull request Jan 31, 2025

Flutter Notable Commits - 2025 #161460

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025

3b7c4aa Add FormField.errorBuilder (flutter/flutter#162255)

166691d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025

3b7c4aa Add FormField.errorBuilder (flutter/flutter#162255)

0da24a8

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025

3b7c4aa Add FormField.errorBuilder (flutter/flutter#162255)

8329864

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025

3b7c4aa Add FormField.errorBuilder (flutter/flutter#162255)

b52b5fa

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025

3b7c4aa Add FormField.errorBuilder (flutter/flutter#162255)

dadcc26

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025

3b7c4aa Add FormField.errorBuilder (flutter/flutter#162255)

f0891da

This was referenced Mar 15, 2025

FormBuilderFiled: Support errorBuilder flutter-form-builder-ecosystem/flutter_form_builder#1480

Closed

General: Support to errorBuilder flutter-form-builder-ecosystem/form_builder_cupertino_fields#28

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

3b7c4aa Add FormField.errorBuilder (flutter/flutter#162255)

2faf742

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

3b7c4aa Add FormField.errorBuilder (flutter/flutter#162255)

f25e6b0

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

3b7c4aa Add FormField.errorBuilder (flutter/flutter#162255)

1397b41

bleroux mentioned this pull request Dec 2, 2025

Add DropdownMenuFormField.errorBuilder #179345

Open

Add FormField.errorBuilder #162255

Add FormField.errorBuilder #162255

Uh oh!

Conversation

bleroux commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Tests

Uh oh!

nate-thegrate left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nate-thegrate left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nate-thegrate commented Jan 28, 2025

Uh oh!

Uh oh!

justinmc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nate-thegrate left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bleroux commented Jan 27, 2025 •

edited

Loading

justinmc left a comment •

edited

Loading