feat: Add selectionColor property to selectable text #162177

lucas-goldner · 2025-01-24T19:24:41Z

This PR aims to add a selectionColor property to the SelectableText widget. Below I have an image attached showing a SelectableText with a custom selectionColor

SelectableText(
    'Hello, world! (Selectable)',
    selectionColor: Colors.red,
)

Fixes #162165

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

P.S. This is my first PR to the Flutter repo, so if I can improve something, please let me know 🙇🏽

packages/flutter/lib/src/material/selectable_text.dart

Renzo-Olivares

Hi @lucas-goldner, thank you for your contribution! I left a few small comments but overall this looks good to me.

Renzo-Olivares · 2025-02-04T20:21:41Z

packages/flutter/lib/src/material/selectable_text.dart

        cursorOpacityAnimates = true;
        cursorColor =
            widget.cursorColor ?? selectionStyle.cursorColor ?? cupertinoTheme.primaryColor;
        selectionColor =


Instead of updating each switch case, your selectionColor: widget.selectionColor ?? selectionColor on EditableText is sufficient.

I adjusted it thank you! Does that mean cursorColor could also be shortened here? Or am I missing something

I think for this PR we can leave it as is.

packages/flutter/lib/src/material/selectable_text.dart

flutter-dashboard · 2025-02-11T17:21:00Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #162177 at sha 4c1ac74

Renzo-Olivares

LGTM, the goldens seem unrelated, maybe try doing a rebase?

justinmc

LGTM with nits 👍 . Thanks for adding this!

packages/flutter/lib/src/material/selectable_text.dart

justinmc

Renewing my LGTM and merging 👍

…/flutter#162177)

Manual roll Flutter from 39b4951 to 911aa75 (56 revisions) Manual roll requested by [email protected] flutter/flutter@39b4951...911aa75 2025-02-21 [email protected] Remove legacy scenec stuff from flutter_tool (flutter/flutter#163569) 2025-02-21 [email protected] [fuchsia] reorder tests in test_suites.yaml and update the comment (flutter/flutter#163799) 2025-02-21 [email protected] Roll Dart SDK from 7ceb3be8ed0a to c5e582f15b6c (2 revisions) (flutter/flutter#163844) 2025-02-21 [email protected] Roll Packages from a9b9172 to 5a721da (2 revisions) (flutter/flutter#163848) 2025-02-21 [email protected] Roll Dart SDK from ad642ee6f94b to 7ceb3be8ed0a (2 revisions) (flutter/flutter#163832) 2025-02-21 [email protected] Update how to use VSCode with `clangd` after the monorepo merge (flutter/flutter#163671) 2025-02-21 [email protected] Reland #163711 after #163780 (flutter/flutter#163812) 2025-02-21 [email protected] Fix incorrect function name in FlutterEngineRun documentation (flutter/flutter#163696) 2025-02-21 [email protected] Roll Dart SDK from 557cbf2c7da6 to ad642ee6f94b (5 revisions) (flutter/flutter#163794) 2025-02-21 [email protected] [canvaskit] Use `visualViewport.scale` to determine device pixel ratio. (flutter/flutter#163688) 2025-02-21 [email protected] [DisplayList] Migrate rendering tests and benchmarks to DL geometry (flutter/flutter#163766) 2025-02-21 [email protected] Make `releaseMode` explicit, inform `determineDevDependencies` entirely on the flag (flutter/flutter#163780) 2025-02-21 [email protected] Ensure `exclude_dev_dependencies_test` runs if `flutter_tools` changes. (flutter/flutter#163768) 2025-02-21 [email protected] WebKit should respect TextCapitalization.words (flutter/flutter#161027) 2025-02-21 [email protected] CupertinoSliverNavigationBar.search fidelity updates (flutter/flutter#163089) 2025-02-21 [email protected] feat: Add selectionColor property to selectable text (flutter/flutter#162177) 2025-02-20 [email protected] Restore `linux_android_emulator_tests` to CI. (flutter/flutter#163747) 2025-02-20 [email protected] introduce system color palette (flutter/flutter#163335) 2025-02-20 [email protected] [web] DRY up access to headers required for multi-threaded WebAssembly (flutter/flutter#163555) 2025-02-20 [email protected] fix(CupertinoDatePicker): font is inconsistent (flutter/flutter#162932) 2025-02-20 [email protected] Create Android-API-And-Related-Versions.md (flutter/flutter#163556) 2025-02-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Avoid implicitly setting `determineDevDependencies: true` (it's not a safe operation) (#163711)" (flutter/flutter#163762) 2025-02-20 [email protected] Revert "Create g3_bug.yml" (flutter/flutter#163757) 2025-02-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make Flutter version information accessible at runtime (#140783)" (flutter/flutter#163753) 2025-02-20 [email protected] Skip Xcode install on mac_mokey Android tests (flutter/flutter#163685) 2025-02-20 [email protected] Roll Dart SDK from 2cecb16348e4 to 557cbf2c7da6 (3 revisions) (flutter/flutter#163705) 2025-02-20 [email protected] Add `FlutterVersion.engineCommitDate`, helps signal engine artifact SHA issues (flutter/flutter#163652) 2025-02-20 [email protected] Avoid implicitly setting `determineDevDependencies: true` (it's not a safe operation) (flutter/flutter#163711) 2025-02-20 [email protected] It is now safe to call `getBuildMode().release` (flutter/flutter#163712) 2025-02-20 [email protected] [iOS] remove Skia interfaces from iOS platform code. (flutter/flutter#163505) 2025-02-20 [email protected] Make Flutter version information accessible at runtime (flutter/flutter#140783) 2025-02-20 [email protected] [windows] Implement merged UI and platform thread (flutter/flutter#162935) 2025-02-20 [email protected] `CircularProgressIndicator` throws null exception (flutter/flutter#163356) 2025-02-20 [email protected] Fix the issue where DropdownMenu does not gain focus when tapped. (flutter/flutter#162874) 2025-02-20 [email protected] Check for tracked engine.version before overriding (flutter/flutter#163672) 2025-02-20 [email protected] showDialogs adds a `requestFocus` parameter. (flutter/flutter#162928) 2025-02-20 [email protected] Create helper method to dispatch object creation and disposal. (flutter/flutter#163637) 2025-02-20 [email protected] Redistribute iOS TESTOWNERS (flutter/flutter#163653) 2025-02-20 [email protected] enclosingElement -> enclosingElement3 (flutter/flutter#163681) 2025-02-19 [email protected] [ Widget Preview ] Move `preview_detector_test.dart` from `general.shard` to `commands.shard` (flutter/flutter#163619) 2025-02-19 [email protected] [iOS] always post new task during gesture dispatch. (flutter/flutter#163646) 2025-02-19 [email protected] Allow flutter tools to detach a running Chrome session (flutter/flutter#163349) 2025-02-19 [email protected] Reland "[Impeller] add support for rational bezier conics to Path (#63282)" (flutter/flutter#163645) 2025-02-19 [email protected] [web:a11y] wheel events switch to pointer mode (flutter/flutter#163582) ...

…/flutter#162177)

) Manual roll Flutter from 39b4951 to 911aa75 (56 revisions) Manual roll requested by [email protected] flutter/flutter@39b4951...911aa75 2025-02-21 [email protected] Remove legacy scenec stuff from flutter_tool (flutter/flutter#163569) 2025-02-21 [email protected] [fuchsia] reorder tests in test_suites.yaml and update the comment (flutter/flutter#163799) 2025-02-21 [email protected] Roll Dart SDK from 7ceb3be8ed0a to c5e582f15b6c (2 revisions) (flutter/flutter#163844) 2025-02-21 [email protected] Roll Packages from a9b9172 to 5a721da (2 revisions) (flutter/flutter#163848) 2025-02-21 [email protected] Roll Dart SDK from ad642ee6f94b to 7ceb3be8ed0a (2 revisions) (flutter/flutter#163832) 2025-02-21 [email protected] Update how to use VSCode with `clangd` after the monorepo merge (flutter/flutter#163671) 2025-02-21 [email protected] Reland #163711 after #163780 (flutter/flutter#163812) 2025-02-21 [email protected] Fix incorrect function name in FlutterEngineRun documentation (flutter/flutter#163696) 2025-02-21 [email protected] Roll Dart SDK from 557cbf2c7da6 to ad642ee6f94b (5 revisions) (flutter/flutter#163794) 2025-02-21 [email protected] [canvaskit] Use `visualViewport.scale` to determine device pixel ratio. (flutter/flutter#163688) 2025-02-21 [email protected] [DisplayList] Migrate rendering tests and benchmarks to DL geometry (flutter/flutter#163766) 2025-02-21 [email protected] Make `releaseMode` explicit, inform `determineDevDependencies` entirely on the flag (flutter/flutter#163780) 2025-02-21 [email protected] Ensure `exclude_dev_dependencies_test` runs if `flutter_tools` changes. (flutter/flutter#163768) 2025-02-21 [email protected] WebKit should respect TextCapitalization.words (flutter/flutter#161027) 2025-02-21 [email protected] CupertinoSliverNavigationBar.search fidelity updates (flutter/flutter#163089) 2025-02-21 [email protected] feat: Add selectionColor property to selectable text (flutter/flutter#162177) 2025-02-20 [email protected] Restore `linux_android_emulator_tests` to CI. (flutter/flutter#163747) 2025-02-20 [email protected] introduce system color palette (flutter/flutter#163335) 2025-02-20 [email protected] [web] DRY up access to headers required for multi-threaded WebAssembly (flutter/flutter#163555) 2025-02-20 [email protected] fix(CupertinoDatePicker): font is inconsistent (flutter/flutter#162932) 2025-02-20 [email protected] Create Android-API-And-Related-Versions.md (flutter/flutter#163556) 2025-02-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Avoid implicitly setting `determineDevDependencies: true` (it's not a safe operation) (#163711)" (flutter/flutter#163762) 2025-02-20 [email protected] Revert "Create g3_bug.yml" (flutter/flutter#163757) 2025-02-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make Flutter version information accessible at runtime (#140783)" (flutter/flutter#163753) 2025-02-20 [email protected] Skip Xcode install on mac_mokey Android tests (flutter/flutter#163685) 2025-02-20 [email protected] Roll Dart SDK from 2cecb16348e4 to 557cbf2c7da6 (3 revisions) (flutter/flutter#163705) 2025-02-20 [email protected] Add `FlutterVersion.engineCommitDate`, helps signal engine artifact SHA issues (flutter/flutter#163652) 2025-02-20 [email protected] Avoid implicitly setting `determineDevDependencies: true` (it's not a safe operation) (flutter/flutter#163711) 2025-02-20 [email protected] It is now safe to call `getBuildMode().release` (flutter/flutter#163712) 2025-02-20 [email protected] [iOS] remove Skia interfaces from iOS platform code. (flutter/flutter#163505) 2025-02-20 [email protected] Make Flutter version information accessible at runtime (flutter/flutter#140783) 2025-02-20 [email protected] [windows] Implement merged UI and platform thread (flutter/flutter#162935) 2025-02-20 [email protected] `CircularProgressIndicator` throws null exception (flutter/flutter#163356) 2025-02-20 [email protected] Fix the issue where DropdownMenu does not gain focus when tapped. (flutter/flutter#162874) 2025-02-20 [email protected] Check for tracked engine.version before overriding (flutter/flutter#163672) 2025-02-20 [email protected] showDialogs adds a `requestFocus` parameter. (flutter/flutter#162928) 2025-02-20 [email protected] Create helper method to dispatch object creation and disposal. (flutter/flutter#163637) 2025-02-20 [email protected] Redistribute iOS TESTOWNERS (flutter/flutter#163653) 2025-02-20 [email protected] enclosingElement -> enclosingElement3 (flutter/flutter#163681) 2025-02-19 [email protected] [ Widget Preview ] Move `preview_detector_test.dart` from `general.shard` to `commands.shard` (flutter/flutter#163619) 2025-02-19 [email protected] [iOS] always post new task during gesture dispatch. (flutter/flutter#163646) 2025-02-19 [email protected] Allow flutter tools to detach a running Chrome session (flutter/flutter#163349) 2025-02-19 [email protected] Reland "[Impeller] add support for rational bezier conics to Path (#63282)" (flutter/flutter#163645) 2025-02-19 [email protected] [web:a11y] wheel events switch to pointer mode (flutter/flutter#163582) ...

github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jan 24, 2025

navaronbracke reviewed Jan 28, 2025

View reviewed changes

packages/flutter/lib/src/material/selectable_text.dart Show resolved Hide resolved

Piinks requested a review from Renzo-Olivares January 29, 2025 19:05

Renzo-Olivares reviewed Feb 4, 2025

View reviewed changes

lucas-goldner force-pushed the feat/add-selection-color-to-selectable-text branch from c143b51 to 2615ce5 Compare February 8, 2025 08:17

lucas-goldner requested a review from Renzo-Olivares February 9, 2025 07:33

Renzo-Olivares reviewed Feb 10, 2025

View reviewed changes

packages/flutter/lib/src/material/selectable_text.dart Outdated Show resolved Hide resolved

lucas-goldner force-pushed the feat/add-selection-color-to-selectable-text branch from 2615ce5 to 4c1ac74 Compare February 11, 2025 16:35

flutter-dashboard bot added the will affect goldens Changes to golden files label Feb 11, 2025

Renzo-Olivares approved these changes Feb 11, 2025

View reviewed changes

lucas-goldner force-pushed the feat/add-selection-color-to-selectable-text branch from 4c1ac74 to 8e00f49 Compare February 12, 2025 16:36

dkwingsmt requested a review from justinmc February 12, 2025 19:32

justinmc approved these changes Feb 12, 2025

View reviewed changes

packages/flutter/lib/src/material/selectable_text.dart Outdated Show resolved Hide resolved

lucas-goldner added 4 commits February 16, 2025 01:39

feat: Add selectionColor property to selectable text

31fd656

refactor: Set selection color only in editable text

094db64

docs: Fix docs of selection color in selectable text

49539ed

docs: Adjust comment styling on selectable texts selection color

644faf0

lucas-goldner force-pushed the feat/add-selection-color-to-selectable-text branch from 8e00f49 to 644faf0 Compare February 15, 2025 16:41

Merge branch 'master' into feat/add-selection-color-to-selectable-text

bc04dfb

justinmc approved these changes Feb 20, 2025

View reviewed changes

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2025

auto-submit bot added this pull request to the merge queue Feb 21, 2025

Merged via the queue into flutter:master with commit edc20ac Feb 21, 2025
75 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2025

lucas-goldner deleted the feat/add-selection-color-to-selectable-text branch February 21, 2025 01:22

engine-flutter-autoroll mentioned this pull request Feb 21, 2025

Roll Flutter from 39b4951f8f0b to b205b6b48a2e (52 revisions) flutter/packages#8670

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 21, 2025

edc20ac feat: Add selectionColor property to selectable text (flutter…

11ac209

…/flutter#162177)

Piinks mentioned this pull request Feb 21, 2025

Flutter Notable Commits - 2025 #161460

Open

engine-flutter-autoroll mentioned this pull request Feb 22, 2025

Roll Flutter from 39b4951f8f0b to 7f447ea98c1a (73 revisions) flutter/packages#8676

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025

edc20ac feat: Add selectionColor property to selectable text (flutter…

344f4bf

…/flutter#162177)

engine-flutter-autoroll mentioned this pull request Feb 22, 2025

Roll Flutter from 39b4951f8f0b to 7f447ea98c1a (73 revisions) flutter/packages#8677

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025

edc20ac feat: Add selectionColor property to selectable text (flutter…

9614dd7

…/flutter#162177)

engine-flutter-autoroll mentioned this pull request Feb 22, 2025

Roll Flutter from 39b4951f8f0b to ff3b708e0fc8 (74 revisions) flutter/packages#8678

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025

edc20ac feat: Add selectionColor property to selectable text (flutter…

b15e72a

…/flutter#162177)

engine-flutter-autoroll mentioned this pull request Feb 22, 2025

Manual roll Flutter from 39b4951f8f0b to ff3b708e0fc8 (74 revisions) flutter/packages#8679

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025

edc20ac feat: Add selectionColor property to selectable text (flutter…

ddb56c7

…/flutter#162177)

engine-flutter-autoroll mentioned this pull request Feb 23, 2025

Roll Flutter from 39b4951f8f0b to 10644396b824 (76 revisions) flutter/packages#8680

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2025

edc20ac feat: Add selectionColor property to selectable text (flutter…

8578c81

…/flutter#162177)

engine-flutter-autoroll mentioned this pull request Feb 23, 2025

Roll Flutter from 39b4951f8f0b to 10644396b824 (76 revisions) flutter/packages#8681

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2025

edc20ac feat: Add selectionColor property to selectable text (flutter…

0cdcb6a

…/flutter#162177)

engine-flutter-autoroll mentioned this pull request Feb 24, 2025

Roll Flutter from 39b4951f8f0b to 39dd5a0897cf (79 revisions) flutter/packages#8684

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025

edc20ac feat: Add selectionColor property to selectable text (flutter…

fe30e7a

…/flutter#162177)

engine-flutter-autoroll mentioned this pull request Feb 24, 2025

Roll Flutter from 39b4951f8f0b to 9a13fd785f2b (80 revisions) flutter/packages#8686

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025

edc20ac feat: Add selectionColor property to selectable text (flutter…

d007f09

…/flutter#162177)

engine-flutter-autoroll mentioned this pull request Feb 24, 2025

Manual roll Flutter from 39b4951f8f0b to 911aa7547ed7 (56 revisions) flutter/packages#8687

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025

edc20ac feat: Add selectionColor property to selectable text (flutter…

1110243

…/flutter#162177)

engine-flutter-autoroll mentioned this pull request Feb 24, 2025

Roll Flutter from 39b4951f8f0b to 0102da95cd20 (81 revisions) flutter/packages#8688

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025

edc20ac feat: Add selectionColor property to selectable text (flutter…

e9d71f1

…/flutter#162177)

engine-flutter-autoroll mentioned this pull request Feb 24, 2025

Roll Flutter from 39b4951f8f0b to e2c4ba31b83e (82 revisions) flutter/packages#8689

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025

edc20ac feat: Add selectionColor property to selectable text (flutter…

3d7c5fd

…/flutter#162177)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

edc20ac feat: Add selectionColor property to selectable text (flutter…

1e4193d

…/flutter#162177)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

edc20ac feat: Add selectionColor property to selectable text (flutter…

a87adae

…/flutter#162177)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

edc20ac feat: Add selectionColor property to selectable text (flutter…

d742bad

…/flutter#162177)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add selectionColor property to selectable text #162177

feat: Add selectionColor property to selectable text #162177

lucas-goldner commented Jan 24, 2025

Uh oh!

Uh oh!

Renzo-Olivares left a comment

Uh oh!

Renzo-Olivares Feb 4, 2025

Uh oh!

lucas-goldner Feb 8, 2025

Uh oh!

Renzo-Olivares Feb 10, 2025

Uh oh!

Uh oh!

Uh oh!

flutter-dashboard bot commented Feb 11, 2025

Uh oh!

Renzo-Olivares left a comment •

edited

Loading

Uh oh!

justinmc left a comment

Uh oh!

Uh oh!

justinmc left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat: Add selectionColor property to selectable text #162177

feat: Add selectionColor property to selectable text #162177

Conversation

lucas-goldner commented Jan 24, 2025

Pre-launch Checklist

Uh oh!

Uh oh!

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

lucas-goldner Feb 8, 2025

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

flutter-dashboard bot commented Feb 11, 2025

Uh oh!

Renzo-Olivares left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Renzo-Olivares left a comment •

edited

Loading