@justinmc This PR will probably break many Google tests. It goes several step further compared to #152069 which fixed the padding when there is a prefix/suffix icon.
Here label, input, helper, error and counter paddings are changed (16 pixels instead of 12 previously). The change is limited to M3.

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #162157 at sha c9eb71f

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #162157 at sha 90cb865

Goldens all look expected and I've approved them. Google tests are running.

I plan to finish verifying the Google test failures later today. At first glance everything looks as expected.

Sorry for the delay here, I'm seeing some tests where a reduced width causes text to wrap, which causes layout problems. The tests probably just need a slight tweak and I'm hoping this PR can still move forward.

I have at least one more Google customer that I need to contact about this. I will plan to look through the failing image diff tests and find which ones have layout problems in the next few days, then contact the customer.

@bleroux Sorry I'm struggling to find the time to look into this. I'll be out next week so likely I'll get back to it after that.

I've blocked out some time for myself to look at these failures on Monday.

I'm working with a team at Google to decide on a way forward for this.

Some fields with a placeholder might be wrapping onto two lines despite having enough space to fit on one? I'm trying to come up with a minimal repro for this. Not sure if that kind of overeager wrapping should be possible with the changes in this PR or not.

I finally was able to get a good repro here! Let me know what you think @bleroux.

master	this branch

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(title),
      ),
      body: Center(
        child: IntrinsicWidth(
          child: TextField(
            minLines: 1,
            maxLines: 80,
            decoration: InputDecoration(
              filled: true,
            ),
          ),
        ),
      ),
    );
  }
}

@justinmc Many thanks for this great repro! 🙏
I will investigate this soon.

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #162157 at sha c8c6aab

@justinmc I updated the PR and fixed intrinsic width calculation for InputDecorator.
There was one Golden change related to time picker, I approved it as it is expected (4 pixels added at the start of the input decoration).
Let see how it goes with Google testing (the check did not run after my update).

Thanks for updating this. The Google tests are running 🤞

Skimming through the failures, I don't see any of the breakage that I pointed out above, but I still need to look more closely.

I do see a layout overflow due to some fields wrapping that didn't previously, though. That's probably expected, but I need to inform the customer and see what they want to do about it.

I found no more unintended test failures after skimming all of the broken tests. I'm working on fixing the layout overflow in the customer's test.