Reland: Fix DropdownMenu rendered behind AppBar #162143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
Contributor
Author
|
cc @bleroux |
9 tasks
bleroux
approved these changes
Jan 24, 2025
Contributor
bleroux
left a comment
bleroux
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for the follow up.
In the future it will be interesting to give the option to choose if the root overlay should be use or not. From #161437 (comment), David is already planning to implement this.
Contributor
Author
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
…162132) Impacted Users: App developers who use `MenuAnchor` to build widgets. Impact Description: DropdownMenu's menuChildren might be placed somewhere far from menuAnchor. #159906 and #161437 Workaround: Not known Risk: Low. This CP reverts a PR, which is by itself a incorrect bug fix. Test Coverage: An additional test is added besides the revert, which is the same test used in the reland #162143. Validation Steps: #161437 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relands #155539 while fixing the bug it contains using the method proposed in #161437.
A 2nd test is added to avoid the regression in #161437.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.