Support hot restart for DDC library bundle format #162123

srujzs · 2025-01-23T23:46:36Z

dart-lang/webdev#2516
dart-lang/webdev#2561

Adds logic to emit newly compiled sources to a file that can be read by the bootstrapper.
Adds bootstrapping logic to reload scripts as needed. This involves implementing the necessary hot restart callback, fetching and processing the emitted file of newly compiled sources, cache busting, and loading the scripts onto the page. A lot of this logic is similar or identical to what we have for internal hot restart support.
Runs existing hot restart tests with the new bundle format.
Adds meta tag to run with utf-8 like in Set meta tag in default index #161493.
Uses DWDS 24.3.3.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

- Adds logic to emit newly compiled sources to a file that can be read by the bootstrapper. - Adds bootstrapping logic to reload scripts as needed. This involves implementing the necessary hot restart callback, fetching and processing the emitted file of newly compiled sources, cache busting, and loading the scripts onto the page. A lot of this logic is similar or identical to what we have for internal hot restart support. - Runs existing hot restart tests with the new bundle format. - Adds meta tag to run with utf-8 like in flutter#161493. - Uses DWDS 24.3.3.

nshahan · 2025-01-24T18:04:10Z

packages/flutter_tools/lib/src/web/bootstrap.dart

    ];

    let loadConfig = new window.\$dartLoader.LoadConfiguration();
+    // TODO(srujzs): Verify this is sufficient for Windows.


Question for @bkonyi (maybe?): Do the tests here run on various platforms in the Flutter CI? Windows?

Well, it turns out forbidden_imports_test.dart makes sure I don't import dart:io, so maybe I shouldn't go down that route. :) I'll keep a todo here to make this work for Windows if needed for now.

Hmm, it looks like I should access isWindows using some of the abstractions we have in Flutter instead. Updated to use that.

We definitely run the native targets using various platforms, but I'm not sure about web. Maybe @christopherfujino would know off the top of his head?

not sure off the top of my head.

packages/flutter_tools/lib/src/web/bootstrap.dart

The bootstrap test was testing for unused code that was deleted. The hot restart tests were timing out so they need to be forked.

bkonyi

LGTM overall!

packages/flutter_tools/lib/src/isolated/devfs_web.dart

… map to set

…utter#162123)

Roll Flutter from c1ffaa9 to b007899 (43 revisions) flutter/flutter@c1ffaa9...b007899 2025-01-29 [email protected] Fix `Tab` linear and elastic animation blink (flutter/flutter#162315) 2025-01-29 [email protected] Pass-through `textInputAction` in `DropdownMenu` (flutter/flutter#162309) 2025-01-29 [email protected] Fix scrollUntilVisible in WidgetTester (flutter/flutter#159582) 2025-01-29 [email protected] Pass-through `maxLines` in `DropdownMenu` (flutter/flutter#161903) 2025-01-29 [email protected] fix: appbar leading width is not square for custom toolbar height (flutter/flutter#161880) 2025-01-29 [email protected] [DisplayList] Don't call Skia Ganesh methods when its not available. (flutter/flutter#162345) 2025-01-29 [email protected] Update README.md to include googler post verification steps (flutter/flutter#162272) 2025-01-29 [email protected] [engine, web] return switch expressions in many places (flutter/flutter#162336) 2025-01-29 [email protected] Update README.md to not have engine link for android (flutter/flutter#162330) 2025-01-29 [email protected] Reland "[ Widget Previews ] Add support for detecting previews and generating code (#161911)"" (flutter/flutter#162337) 2025-01-29 [email protected] Add instructions to download the Gradle wrapper to FGP readme, and add to gitignore (flutter/flutter#162332) 2025-01-29 [email protected] Fix tests to prepare for `--explicit-package-dependencies` and a bug. (flutter/flutter#162289) 2025-01-29 [email protected] Add a currently unused `runs_in_merge_queue` property to `Linux analyze`. (flutter/flutter#162335) 2025-01-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Widget Previews ] Add support for detecting previews and generating code (#161911)" (flutter/flutter#162327) 2025-01-28 [email protected] Support hot restart for DDC library bundle format (flutter/flutter#162123) 2025-01-28 [email protected] Started adjusting uvs to match pixel snapping. (flutter/flutter#162049) 2025-01-28 [email protected] Refactor code inside flutter.groovy (flutter/flutter#160250) 2025-01-28 [email protected] Table implements redepth (flutter/flutter#162282) 2025-01-28 [email protected] [ Widget Previews ] Add support for detecting previews and generating code (flutter/flutter#161911) 2025-01-28 [email protected] remove dependency on `Usage` from `Pub` class (flutter/flutter#162279) 2025-01-28 [email protected] Roll Packages from 258f6dc to 02c6fef (6 revisions) (flutter/flutter#162313) 2025-01-28 [email protected] Remove `scenario_app/android` and rename to `ios_scenario_app`. (flutter/flutter#160992) 2025-01-28 [email protected] Apparently it is illegal to use `stderr` in this project. (flutter/flutter#162294) 2025-01-28 [email protected] Fix update_engine_version_test in presence of FLUTTER_PREBUILT_ENGINE_VERSION env vars. (flutter/flutter#162270) 2025-01-28 [email protected] Add missing `properties: ...` and move to presubmit. (flutter/flutter#162170) 2025-01-27 [email protected] [Impeller] make swapchain related external fence/semaphore extensions optional. (flutter/flutter#162205) 2025-01-27 49699333+dependabot[bot]@users.noreply.github.com Bump the all-github-actions group with 2 updates (flutter/flutter#162277) 2025-01-27 [email protected] Don't depend on Dart from FML. (flutter/flutter#162271) 2025-01-27 [email protected] [DisplayList] Move nested canvas enums into their own TU. (flutter/flutter#162037) 2025-01-27 [email protected] Avoid iOS text selection crash by returning nil range (flutter/flutter#161996) 2025-01-27 [email protected] fix `felt` link to point to flutter repo instead of the engine repo (flutter/flutter#161423) 2025-01-27 [email protected] Enable the Android Engine OpenGLES/Vulkan suites. (flutter/flutter#162258) 2025-01-27 [email protected] [canvaskit] Fix debug build for CanvasKit (flutter/flutter#162198) 2025-01-27 [email protected] Roll Packages from 3d3ab7b to 258f6dc (19 revisions) (flutter/flutter#162254) 2025-01-25 [email protected] Pin `customer_testing` to the SHA specified in `tests.version` (flutter/flutter#162048) 2025-01-25 [email protected] Formalize `update_engine_version.{sh|ps1}`. (flutter/flutter#162118) 2025-01-25 [email protected] Rename 'SelectionChangedCause.scribble' to 'SelectionChangedCause.stylusHandwriting' (flutter/flutter#161518) 2025-01-25 [email protected] Don't install xcode when doing `local_engine` web builds on mac. (flutter/flutter#162164) 2025-01-25 [email protected] Force Impeller backend for `android_engine_test`, and test both OpenGLES and Vulkan (flutter/flutter#162089) 2025-01-24 [email protected] [Impeller] when a command pool has many unused buffers, reset with release resources flag. (flutter/flutter#162171) 2025-01-24 [email protected] [web] Remove HTML renderer from framework tests (flutter/flutter#162038) 2025-01-24 [email protected] [Impeller] Skip clip entity replay that cannot impact current clip. (flutter/flutter#162113) 2025-01-24 [email protected] Update Android integration test package for newer AGP (flutter/flutter#161856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ...

…utter#162123)

Roll Flutter from c1ffaa9 to b007899 (43 revisions) flutter/flutter@c1ffaa9...b007899 2025-01-29 [email protected] Fix `Tab` linear and elastic animation blink (flutter/flutter#162315) 2025-01-29 [email protected] Pass-through `textInputAction` in `DropdownMenu` (flutter/flutter#162309) 2025-01-29 [email protected] Fix scrollUntilVisible in WidgetTester (flutter/flutter#159582) 2025-01-29 [email protected] Pass-through `maxLines` in `DropdownMenu` (flutter/flutter#161903) 2025-01-29 [email protected] fix: appbar leading width is not square for custom toolbar height (flutter/flutter#161880) 2025-01-29 [email protected] [DisplayList] Don't call Skia Ganesh methods when its not available. (flutter/flutter#162345) 2025-01-29 [email protected] Update README.md to include googler post verification steps (flutter/flutter#162272) 2025-01-29 [email protected] [engine, web] return switch expressions in many places (flutter/flutter#162336) 2025-01-29 [email protected] Update README.md to not have engine link for android (flutter/flutter#162330) 2025-01-29 [email protected] Reland "[ Widget Previews ] Add support for detecting previews and generating code (#161911)"" (flutter/flutter#162337) 2025-01-29 [email protected] Add instructions to download the Gradle wrapper to FGP readme, and add to gitignore (flutter/flutter#162332) 2025-01-29 [email protected] Fix tests to prepare for `--explicit-package-dependencies` and a bug. (flutter/flutter#162289) 2025-01-29 [email protected] Add a currently unused `runs_in_merge_queue` property to `Linux analyze`. (flutter/flutter#162335) 2025-01-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Widget Previews ] Add support for detecting previews and generating code (#161911)" (flutter/flutter#162327) 2025-01-28 [email protected] Support hot restart for DDC library bundle format (flutter/flutter#162123) 2025-01-28 [email protected] Started adjusting uvs to match pixel snapping. (flutter/flutter#162049) 2025-01-28 [email protected] Refactor code inside flutter.groovy (flutter/flutter#160250) 2025-01-28 [email protected] Table implements redepth (flutter/flutter#162282) 2025-01-28 [email protected] [ Widget Previews ] Add support for detecting previews and generating code (flutter/flutter#161911) 2025-01-28 [email protected] remove dependency on `Usage` from `Pub` class (flutter/flutter#162279) 2025-01-28 [email protected] Roll Packages from 258f6dc to 02c6fef (6 revisions) (flutter/flutter#162313) 2025-01-28 [email protected] Remove `scenario_app/android` and rename to `ios_scenario_app`. (flutter/flutter#160992) 2025-01-28 [email protected] Apparently it is illegal to use `stderr` in this project. (flutter/flutter#162294) 2025-01-28 [email protected] Fix update_engine_version_test in presence of FLUTTER_PREBUILT_ENGINE_VERSION env vars. (flutter/flutter#162270) 2025-01-28 [email protected] Add missing `properties: ...` and move to presubmit. (flutter/flutter#162170) 2025-01-27 [email protected] [Impeller] make swapchain related external fence/semaphore extensions optional. (flutter/flutter#162205) 2025-01-27 49699333+dependabot[bot]@users.noreply.github.com Bump the all-github-actions group with 2 updates (flutter/flutter#162277) 2025-01-27 [email protected] Don't depend on Dart from FML. (flutter/flutter#162271) 2025-01-27 [email protected] [DisplayList] Move nested canvas enums into their own TU. (flutter/flutter#162037) 2025-01-27 [email protected] Avoid iOS text selection crash by returning nil range (flutter/flutter#161996) 2025-01-27 [email protected] fix `felt` link to point to flutter repo instead of the engine repo (flutter/flutter#161423) 2025-01-27 [email protected] Enable the Android Engine OpenGLES/Vulkan suites. (flutter/flutter#162258) 2025-01-27 [email protected] [canvaskit] Fix debug build for CanvasKit (flutter/flutter#162198) 2025-01-27 [email protected] Roll Packages from 3d3ab7b to 258f6dc (19 revisions) (flutter/flutter#162254) 2025-01-25 [email protected] Pin `customer_testing` to the SHA specified in `tests.version` (flutter/flutter#162048) 2025-01-25 [email protected] Formalize `update_engine_version.{sh|ps1}`. (flutter/flutter#162118) 2025-01-25 [email protected] Rename 'SelectionChangedCause.scribble' to 'SelectionChangedCause.stylusHandwriting' (flutter/flutter#161518) 2025-01-25 [email protected] Don't install xcode when doing `local_engine` web builds on mac. (flutter/flutter#162164) 2025-01-25 [email protected] Force Impeller backend for `android_engine_test`, and test both OpenGLES and Vulkan (flutter/flutter#162089) 2025-01-24 [email protected] [Impeller] when a command pool has many unused buffers, reset with release resources flag. (flutter/flutter#162171) 2025-01-24 [email protected] [web] Remove HTML renderer from framework tests (flutter/flutter#162038) 2025-01-24 [email protected] [Impeller] Skip clip entity replay that cannot impact current clip. (flutter/flutter#162113) 2025-01-24 [email protected] Update Android integration test package for newer AGP (flutter/flutter#161856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ...

srujzs requested review from bkonyi and nshahan January 23, 2025 23:46

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 23, 2025

srujzs added 2 commits January 23, 2025 15:48

Merge remote-tracking branch 'upstream/main' into hotrestart

6019a6a

Update pubspec checksum

c568f59

nshahan approved these changes Jan 24, 2025

View reviewed changes

srujzs added 6 commits January 24, 2025 11:28

Merge remote-tracking branch 'upstream/main' into hotrestart

2084de5

Amend bootstrap_test and move restart test to utils

51b0ddf

The bootstrap test was testing for unused code that was deleted. The hot restart tests were timing out so they need to be forked.

Move additionalCommandArgs to _testProject instead

8c9dcef

Merge remote-tracking branch 'upstream/main' into hotrestart

65fb658

Remove dart:io import

7b06e47

Use globals.platform.isWindows to determine if Windows

c369c5c

bkonyi approved these changes Jan 27, 2025

View reviewed changes

packages/flutter_tools/lib/src/isolated/devfs_web.dart Outdated Show resolved Hide resolved

packages/flutter_tools/lib/src/isolated/devfs_web.dart Outdated Show resolved Hide resolved

srujzs added 5 commits January 27, 2025 09:52

Add isWindows to various tests, update copyright, remove TODO, change…

75be5ce

… map to set

Merge remote-tracking branch 'upstream/main' into hotrestart

677d29b

Remove test driver annotation on utils

d7f7fd8

Merge remote-tracking branch 'upstream/main' into hotrestart

5037a2f

Remove unnecessary set

3616f92

srujzs enabled auto-merge January 28, 2025 04:08

srujzs added 2 commits January 28, 2025 08:54

Merge remote-tracking branch 'upstream/main' into hotrestart

8629da7

Move utils to test_data to silence analysis

1dc42d3

srujzs added this pull request to the merge queue Jan 28, 2025

Merged via the queue into flutter:master with commit 6d2792d Jan 28, 2025
160 of 161 checks passed

srujzs deleted the hotrestart branch January 28, 2025 20:05

engine-flutter-autoroll mentioned this pull request Jan 29, 2025

Roll Flutter from c1ffaa9d9deb to b007899d3a7a (43 revisions) flutter/packages#8527

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2025

6d2792d Support hot restart for DDC library bundle format (flutter/fl…

dca6b54

…utter#162123)

harri35 mentioned this pull request Feb 5, 2025

Linux web_tool_tests is 2.11% flaky #162728

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

6d2792d Support hot restart for DDC library bundle format (flutter/fl…

5c06a87

…utter#162123)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

6d2792d Support hot restart for DDC library bundle format (flutter/fl…

ae6183e

…utter#162123)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

6d2792d Support hot restart for DDC library bundle format (flutter/fl…

f7314b8

…utter#162123)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support hot restart for DDC library bundle format #162123

Support hot restart for DDC library bundle format #162123

Uh oh!

srujzs commented Jan 23, 2025

Uh oh!

nshahan Jan 24, 2025

Uh oh!

srujzs Jan 24, 2025

Uh oh!

srujzs Jan 25, 2025

Uh oh!

bkonyi Jan 27, 2025

Uh oh!

christopherfujino Jan 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkonyi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Support hot restart for DDC library bundle format #162123

Support hot restart for DDC library bundle format #162123

Uh oh!

Conversation

srujzs commented Jan 23, 2025

Pre-launch Checklist

Uh oh!

nshahan Jan 24, 2025

Choose a reason for hiding this comment

Uh oh!

srujzs Jan 24, 2025

Choose a reason for hiding this comment

Uh oh!

srujzs Jan 25, 2025

Choose a reason for hiding this comment

Uh oh!

bkonyi Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

christopherfujino Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkonyi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants