Formalize `update_engine_version.{sh|ps1}`. #162118

matanlurey · 2025-01-23T22:52:34Z

NOTE: This renames the environment variable to FLUTTER_PREBUILT_ENGINE_VERSION.

We occasionally break ourselves, our users, and the Dart up (or is it down? side-ways) stream repos (i.e. HHH) when we change how the undocumented update_engine_version.sh script, and it's Windows counterpart update_engine_version.ps1 work, but have no way of knowing until N days/weeks later when someone tells us.

For example, https://flutter-review.googlesource.com/c/recipes/+/62400.

This is my attempt to encode "this is what you can guarantee by calling this script".

It still will be an internal only API that we might rev at any time, but at least we:

Can tell the Dart team "this is tested and how it works"
If we want to change it, the tests will keep us from changing it without informing folks it changed

These tests should (in theory) cover both Linux/MacOS and Windows.

/cc @a-siva

aam · 2025-01-23T22:56:17Z

dev/tools/test/update_engine_version_test.dart

+  });
+
+  tearDown(() {
+    // tmpDir.deleteSync(recursive: true);


Did you mean to leave it commented out?

No, I did not. Thank you!

aam · 2025-01-23T22:57:52Z

bin/internal/update_engine_version.ps1

+#
+# This is for systems, such as Github Actions, where we know ahead of time the
+# base-ref we want to use (to download the engine binaries and avoid trying
+# to compute one below), or for the Dart HHH bot, which wants to try the current


HH bot (only two heads are remaining)

aam

This looks good.
Note that from Dart-Flutter hh infra perspective, flutter recipe doesn't use update_engine_version script directly, instead it simply calls flutter update-packages and expects artifacts for particular engine hash downloaded(based on contents of engine.version or flutter_engine_version env variable). So if we are extra demanding that's the api surface that is worth covering.

jtmcdole · 2025-01-24T00:07:50Z

Note that from Dart-Flutter hh infra perspective, flutter recipe doesn't use update_engine_version

You might not be doing it directly, but we're doing it for you when you call the flutter tool.

jtmcdole

auto-submit · 2025-01-24T01:14:52Z

autosubmit label was removed for flutter/flutter/162118, because - The status or check suite Linux linux_web_engine_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-01-24T22:21:30Z

autosubmit label was removed for flutter/flutter/162118, because - The status or check suite Mac mac_ios_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-01-24T23:24:47Z

autosubmit label was removed for flutter/flutter/162118, because - The status or check suite Windows framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-01-25T18:51:25Z

autosubmit label was removed for flutter/flutter/162118, because - The status or check suite Mac framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.

…162118)

Roll Flutter from c1ffaa9 to b007899 (43 revisions) flutter/flutter@c1ffaa9...b007899 2025-01-29 [email protected] Fix `Tab` linear and elastic animation blink (flutter/flutter#162315) 2025-01-29 [email protected] Pass-through `textInputAction` in `DropdownMenu` (flutter/flutter#162309) 2025-01-29 [email protected] Fix scrollUntilVisible in WidgetTester (flutter/flutter#159582) 2025-01-29 [email protected] Pass-through `maxLines` in `DropdownMenu` (flutter/flutter#161903) 2025-01-29 [email protected] fix: appbar leading width is not square for custom toolbar height (flutter/flutter#161880) 2025-01-29 [email protected] [DisplayList] Don't call Skia Ganesh methods when its not available. (flutter/flutter#162345) 2025-01-29 [email protected] Update README.md to include googler post verification steps (flutter/flutter#162272) 2025-01-29 [email protected] [engine, web] return switch expressions in many places (flutter/flutter#162336) 2025-01-29 [email protected] Update README.md to not have engine link for android (flutter/flutter#162330) 2025-01-29 [email protected] Reland "[ Widget Previews ] Add support for detecting previews and generating code (#161911)"" (flutter/flutter#162337) 2025-01-29 [email protected] Add instructions to download the Gradle wrapper to FGP readme, and add to gitignore (flutter/flutter#162332) 2025-01-29 [email protected] Fix tests to prepare for `--explicit-package-dependencies` and a bug. (flutter/flutter#162289) 2025-01-29 [email protected] Add a currently unused `runs_in_merge_queue` property to `Linux analyze`. (flutter/flutter#162335) 2025-01-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Widget Previews ] Add support for detecting previews and generating code (#161911)" (flutter/flutter#162327) 2025-01-28 [email protected] Support hot restart for DDC library bundle format (flutter/flutter#162123) 2025-01-28 [email protected] Started adjusting uvs to match pixel snapping. (flutter/flutter#162049) 2025-01-28 [email protected] Refactor code inside flutter.groovy (flutter/flutter#160250) 2025-01-28 [email protected] Table implements redepth (flutter/flutter#162282) 2025-01-28 [email protected] [ Widget Previews ] Add support for detecting previews and generating code (flutter/flutter#161911) 2025-01-28 [email protected] remove dependency on `Usage` from `Pub` class (flutter/flutter#162279) 2025-01-28 [email protected] Roll Packages from 258f6dc to 02c6fef (6 revisions) (flutter/flutter#162313) 2025-01-28 [email protected] Remove `scenario_app/android` and rename to `ios_scenario_app`. (flutter/flutter#160992) 2025-01-28 [email protected] Apparently it is illegal to use `stderr` in this project. (flutter/flutter#162294) 2025-01-28 [email protected] Fix update_engine_version_test in presence of FLUTTER_PREBUILT_ENGINE_VERSION env vars. (flutter/flutter#162270) 2025-01-28 [email protected] Add missing `properties: ...` and move to presubmit. (flutter/flutter#162170) 2025-01-27 [email protected] [Impeller] make swapchain related external fence/semaphore extensions optional. (flutter/flutter#162205) 2025-01-27 49699333+dependabot[bot]@users.noreply.github.com Bump the all-github-actions group with 2 updates (flutter/flutter#162277) 2025-01-27 [email protected] Don't depend on Dart from FML. (flutter/flutter#162271) 2025-01-27 [email protected] [DisplayList] Move nested canvas enums into their own TU. (flutter/flutter#162037) 2025-01-27 [email protected] Avoid iOS text selection crash by returning nil range (flutter/flutter#161996) 2025-01-27 [email protected] fix `felt` link to point to flutter repo instead of the engine repo (flutter/flutter#161423) 2025-01-27 [email protected] Enable the Android Engine OpenGLES/Vulkan suites. (flutter/flutter#162258) 2025-01-27 [email protected] [canvaskit] Fix debug build for CanvasKit (flutter/flutter#162198) 2025-01-27 [email protected] Roll Packages from 3d3ab7b to 258f6dc (19 revisions) (flutter/flutter#162254) 2025-01-25 [email protected] Pin `customer_testing` to the SHA specified in `tests.version` (flutter/flutter#162048) 2025-01-25 [email protected] Formalize `update_engine_version.{sh|ps1}`. (flutter/flutter#162118) 2025-01-25 [email protected] Rename 'SelectionChangedCause.scribble' to 'SelectionChangedCause.stylusHandwriting' (flutter/flutter#161518) 2025-01-25 [email protected] Don't install xcode when doing `local_engine` web builds on mac. (flutter/flutter#162164) 2025-01-25 [email protected] Force Impeller backend for `android_engine_test`, and test both OpenGLES and Vulkan (flutter/flutter#162089) 2025-01-24 [email protected] [Impeller] when a command pool has many unused buffers, reset with release resources flag. (flutter/flutter#162171) 2025-01-24 [email protected] [web] Remove HTML renderer from framework tests (flutter/flutter#162038) 2025-01-24 [email protected] [Impeller] Skip clip entity replay that cannot impact current clip. (flutter/flutter#162113) 2025-01-24 [email protected] Update Android integration test package for newer AGP (flutter/flutter#161856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ...

…162118)

Roll Flutter from c1ffaa9 to b007899 (43 revisions) flutter/flutter@c1ffaa9...b007899 2025-01-29 [email protected] Fix `Tab` linear and elastic animation blink (flutter/flutter#162315) 2025-01-29 [email protected] Pass-through `textInputAction` in `DropdownMenu` (flutter/flutter#162309) 2025-01-29 [email protected] Fix scrollUntilVisible in WidgetTester (flutter/flutter#159582) 2025-01-29 [email protected] Pass-through `maxLines` in `DropdownMenu` (flutter/flutter#161903) 2025-01-29 [email protected] fix: appbar leading width is not square for custom toolbar height (flutter/flutter#161880) 2025-01-29 [email protected] [DisplayList] Don't call Skia Ganesh methods when its not available. (flutter/flutter#162345) 2025-01-29 [email protected] Update README.md to include googler post verification steps (flutter/flutter#162272) 2025-01-29 [email protected] [engine, web] return switch expressions in many places (flutter/flutter#162336) 2025-01-29 [email protected] Update README.md to not have engine link for android (flutter/flutter#162330) 2025-01-29 [email protected] Reland "[ Widget Previews ] Add support for detecting previews and generating code (#161911)"" (flutter/flutter#162337) 2025-01-29 [email protected] Add instructions to download the Gradle wrapper to FGP readme, and add to gitignore (flutter/flutter#162332) 2025-01-29 [email protected] Fix tests to prepare for `--explicit-package-dependencies` and a bug. (flutter/flutter#162289) 2025-01-29 [email protected] Add a currently unused `runs_in_merge_queue` property to `Linux analyze`. (flutter/flutter#162335) 2025-01-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Widget Previews ] Add support for detecting previews and generating code (#161911)" (flutter/flutter#162327) 2025-01-28 [email protected] Support hot restart for DDC library bundle format (flutter/flutter#162123) 2025-01-28 [email protected] Started adjusting uvs to match pixel snapping. (flutter/flutter#162049) 2025-01-28 [email protected] Refactor code inside flutter.groovy (flutter/flutter#160250) 2025-01-28 [email protected] Table implements redepth (flutter/flutter#162282) 2025-01-28 [email protected] [ Widget Previews ] Add support for detecting previews and generating code (flutter/flutter#161911) 2025-01-28 [email protected] remove dependency on `Usage` from `Pub` class (flutter/flutter#162279) 2025-01-28 [email protected] Roll Packages from 258f6dc to 02c6fef (6 revisions) (flutter/flutter#162313) 2025-01-28 [email protected] Remove `scenario_app/android` and rename to `ios_scenario_app`. (flutter/flutter#160992) 2025-01-28 [email protected] Apparently it is illegal to use `stderr` in this project. (flutter/flutter#162294) 2025-01-28 [email protected] Fix update_engine_version_test in presence of FLUTTER_PREBUILT_ENGINE_VERSION env vars. (flutter/flutter#162270) 2025-01-28 [email protected] Add missing `properties: ...` and move to presubmit. (flutter/flutter#162170) 2025-01-27 [email protected] [Impeller] make swapchain related external fence/semaphore extensions optional. (flutter/flutter#162205) 2025-01-27 49699333+dependabot[bot]@users.noreply.github.com Bump the all-github-actions group with 2 updates (flutter/flutter#162277) 2025-01-27 [email protected] Don't depend on Dart from FML. (flutter/flutter#162271) 2025-01-27 [email protected] [DisplayList] Move nested canvas enums into their own TU. (flutter/flutter#162037) 2025-01-27 [email protected] Avoid iOS text selection crash by returning nil range (flutter/flutter#161996) 2025-01-27 [email protected] fix `felt` link to point to flutter repo instead of the engine repo (flutter/flutter#161423) 2025-01-27 [email protected] Enable the Android Engine OpenGLES/Vulkan suites. (flutter/flutter#162258) 2025-01-27 [email protected] [canvaskit] Fix debug build for CanvasKit (flutter/flutter#162198) 2025-01-27 [email protected] Roll Packages from 3d3ab7b to 258f6dc (19 revisions) (flutter/flutter#162254) 2025-01-25 [email protected] Pin `customer_testing` to the SHA specified in `tests.version` (flutter/flutter#162048) 2025-01-25 [email protected] Formalize `update_engine_version.{sh|ps1}`. (flutter/flutter#162118) 2025-01-25 [email protected] Rename 'SelectionChangedCause.scribble' to 'SelectionChangedCause.stylusHandwriting' (flutter/flutter#161518) 2025-01-25 [email protected] Don't install xcode when doing `local_engine` web builds on mac. (flutter/flutter#162164) 2025-01-25 [email protected] Force Impeller backend for `android_engine_test`, and test both OpenGLES and Vulkan (flutter/flutter#162089) 2025-01-24 [email protected] [Impeller] when a command pool has many unused buffers, reset with release resources flag. (flutter/flutter#162171) 2025-01-24 [email protected] [web] Remove HTML renderer from framework tests (flutter/flutter#162038) 2025-01-24 [email protected] [Impeller] Skip clip entity replay that cannot impact current clip. (flutter/flutter#162113) 2025-01-24 [email protected] Update Android integration test package for newer AGP (flutter/flutter#161856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ...

Add test coverage for update_engine_version.script.

bb6fba9

matanlurey requested review from aam and jtmcdole January 23, 2025 22:52

aam reviewed Jan 23, 2025

View reviewed changes

++

77a1120

aam reviewed Jan 23, 2025

View reviewed changes

aam approved these changes Jan 23, 2025

View reviewed changes

matanlurey added 2 commits January 23, 2025 15:59

Fix pubspec.

f1b8cf6

Merge remote-tracking branch 'upstream/main' into update_engine_version

c777cbe

jtmcdole approved these changes Jan 24, 2025

View reviewed changes

flutter update-packages.

1144c99

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 24, 2025

matanlurey added autosubmit Merge PR when tree becomes green via auto submit App and removed tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 24, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2025

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 24, 2025

matanlurey added 2 commits January 24, 2025 10:06

Merge remote-tracking branch 'upstream/main' into update_engine_version

ff7440e

Fix powershell.

e4cb027

matanlurey force-pushed the update_engine_version branch from 6553ff0 to e4cb027 Compare January 24, 2025 18:12

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2025

matanlurey mentioned this pull request Jan 24, 2025

Conditionally skip the engine build phase #162201

Closed

4 tasks

matanlurey enabled auto-merge January 24, 2025 23:19

matanlurey disabled auto-merge January 24, 2025 23:19

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2025

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 25, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 25, 2025

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 25, 2025

auto-submit bot added this pull request to the merge queue Jan 25, 2025

Merged via the queue into flutter:master with commit a3f0704 Jan 25, 2025
170 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 25, 2025

engine-flutter-autoroll mentioned this pull request Jan 26, 2025

Roll Flutter from c1ffaa9d9deb to a16de734bd2d (9 revisions) flutter/packages#8506

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 26, 2025

a3f0704 Formalize update_engine_version.{sh|ps1}. (flutter/flutter#…

5f551a5

…162118)

engine-flutter-autoroll mentioned this pull request Jan 26, 2025

Roll Flutter from c1ffaa9d9deb to a16de734bd2d (9 revisions) flutter/packages#8507

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 26, 2025

a3f0704 Formalize update_engine_version.{sh|ps1}. (flutter/flutter#…

688cc59

…162118)

engine-flutter-autoroll mentioned this pull request Jan 27, 2025

Roll Flutter from c1ffaa9d9deb to a16de734bd2d (9 revisions) flutter/packages#8508

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 27, 2025

a3f0704 Formalize update_engine_version.{sh|ps1}. (flutter/flutter#…

26d0e86

…162118)

engine-flutter-autoroll mentioned this pull request Jan 27, 2025

Roll Flutter from c1ffaa9d9deb to a2c56f3d755a (10 revisions) flutter/packages#8511

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 27, 2025

a3f0704 Formalize update_engine_version.{sh|ps1}. (flutter/flutter#…

0b44a0c

…162118)

engine-flutter-autoroll mentioned this pull request Jan 28, 2025

Roll Flutter from c1ffaa9d9deb to 9e273d5e6e2e (22 revisions) flutter/packages#8520

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2025

a3f0704 Formalize update_engine_version.{sh|ps1}. (flutter/flutter#…

c5b22f5

…162118)

engine-flutter-autoroll mentioned this pull request Jan 28, 2025

Roll Flutter from c1ffaa9d9deb to 21f7283f5dfb (23 revisions) flutter/packages#8522

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2025

a3f0704 Formalize update_engine_version.{sh|ps1}. (flutter/flutter#…

28c9610

…162118)

engine-flutter-autoroll mentioned this pull request Jan 28, 2025

Roll Flutter from c1ffaa9d9deb to a9c50335c736 (24 revisions) flutter/packages#8523

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2025

a3f0704 Formalize update_engine_version.{sh|ps1}. (flutter/flutter#…

e8404fd

…162118)

engine-flutter-autoroll mentioned this pull request Jan 29, 2025

Roll Flutter from c1ffaa9d9deb to b007899d3a7a (43 revisions) flutter/packages#8527

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2025

a3f0704 Formalize update_engine_version.{sh|ps1}. (flutter/flutter#…

24cc572

…162118)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

a3f0704 Formalize update_engine_version.{sh|ps1}. (flutter/flutter#…

87004b2

…162118)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

a3f0704 Formalize update_engine_version.{sh|ps1}. (flutter/flutter#…

a2712c2

…162118)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

a3f0704 Formalize update_engine_version.{sh|ps1}. (flutter/flutter#…

6603603

…162118)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Formalize `update_engine_version.{sh|ps1}`. #162118

Formalize `update_engine_version.{sh|ps1}`. #162118

Uh oh!

matanlurey commented Jan 23, 2025 •

edited

Loading

Uh oh!

aam Jan 23, 2025

Uh oh!

matanlurey Jan 23, 2025

Uh oh!

aam Jan 23, 2025

Uh oh!

aam left a comment

Uh oh!

jtmcdole commented Jan 24, 2025

Uh oh!

jtmcdole left a comment

Uh oh!

auto-submit bot commented Jan 24, 2025

Uh oh!

auto-submit bot commented Jan 24, 2025

Uh oh!

auto-submit bot commented Jan 24, 2025

Uh oh!

auto-submit bot commented Jan 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Formalize update_engine_version.{sh|ps1}. #162118

Formalize update_engine_version.{sh|ps1}. #162118

Uh oh!

Conversation

matanlurey commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aam Jan 23, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey Jan 23, 2025

Choose a reason for hiding this comment

Uh oh!

aam Jan 23, 2025

Choose a reason for hiding this comment

Uh oh!

aam left a comment

Choose a reason for hiding this comment

Uh oh!

jtmcdole commented Jan 24, 2025

Uh oh!

jtmcdole left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 24, 2025

Uh oh!

auto-submit bot commented Jan 24, 2025

Uh oh!

auto-submit bot commented Jan 24, 2025

Uh oh!

auto-submit bot commented Jan 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Formalize `update_engine_version.{sh|ps1}`. #162118

Formalize `update_engine_version.{sh|ps1}`. #162118

matanlurey commented Jan 23, 2025 •

edited

Loading