Skip to content

Conversation

@polina-c
Copy link
Contributor

No description provided.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Jan 23, 2025
@polina-c polina-c requested a review from yjbanov January 23, 2025 21:00
@polina-c polina-c marked this pull request as ready for review January 23, 2025 21:03
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025
@polina-c polina-c enabled auto-merge January 23, 2025 21:10
@polina-c polina-c added this pull request to the merge queue Jan 23, 2025
auto-merge was automatically disabled January 23, 2025 21:37

Pull Request is not mergeable

Merged via the queue into flutter:master with commit 8d00bd9 Jan 23, 2025
171 of 173 checks passed
@polina-c polina-c deleted the test-pic branch January 23, 2025 22:27
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025
@harryterkelsen harryterkelsen added the revert Autorevert PR (with "Reason for revert:" comment) label Jan 23, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 23, 2025

A reason for requesting a revert of flutter/flutter/162106 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jan 23, 2025
@harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen added the revert Autorevert PR (with "Reason for revert:" comment) label Jan 23, 2025
auto-submit bot pushed a commit that referenced this pull request Jan 23, 2025
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jan 23, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 24, 2025
<!-- start_original_pr_link -->
Reverts: #162106
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: harryterkelsen
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: causing test breakage on web. See:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/270/infra
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: polina-c
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {yjbanov}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
No description provided.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025
Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull request Jan 24, 2025
Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull request Jan 24, 2025
<!-- start_original_pr_link -->
Reverts: flutter#162106
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: harryterkelsen
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: causing test breakage on web. See:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/270/infra
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: polina-c
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {yjbanov}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
No description provided.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025
auto-submit bot pushed a commit to flutter/cocoon that referenced this pull request Jan 24, 2025
This relands commit b9bd02b.

The previous attempt was reverted in #4175 because of the suspicion that it was landing PRs with failed checks. However, that suspicion seems to have been wrong. This is what actually happened:

* 12:25PM: @polina-c creates the [PR](flutter/flutter#162106); Cocoon starts testing it and unlocks the Merge Queue Guard after all engine builds are done (old behavior).
* 1:02PM: I deploy the new Cocoon with the new behavior.
* 1:10PM: @polina-c hits the "Merge When Ready" button, and GitHub allows the PR to enter the queue.

GitHub allowed that last action because the guard was already unlocked by the old behavior. It wasn't the new code misbehaving. In fact, this is exactly the problem that the new code is aiming to fix.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 24, 2025
Manual roll requested by [email protected]

flutter/flutter@c1561a4...c1ffaa9

2025-01-24 [email protected] Fix link to hotfix documentation best practices (flutter/flutter#162116)
2025-01-24 [email protected] Add integration test for cutout rotation evaluation (flutter/flutter#160354)
2025-01-24 [email protected] Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146)
2025-01-24 [email protected] Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235)
2025-01-24 [email protected] When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455)
2025-01-24 [email protected] [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052)
2025-01-24 [email protected] Add to Setup Path Example to Engine README (flutter/flutter#162115)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122)
2025-01-23 [email protected] feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424)
2025-01-23 [email protected] Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100)
2025-01-23 [email protected] Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493)
2025-01-23 [email protected] Unskip test. (flutter/flutter#162106)
2025-01-23 [email protected] Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076)
2025-01-23 [email protected] Roll pub packages (flutter/flutter#162095)
2025-01-23 [email protected] Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050)
2025-01-23 [email protected] Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)
2025-01-23 [email protected] flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047)
2025-01-23 [email protected] [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082)
2025-01-23 [email protected] Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459)
2025-01-23 [email protected] Show error on macOS if missing Local Network permissions (flutter/flutter#161846)
2025-01-23 [email protected] Autocomplete keyboard navigation (flutter/flutter#159455)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@polina-c
Copy link
Contributor Author

@yjbanov , couple questions:

  1. What runtime the tests target?
    I am trying to repro Picture.toImage fails for --web-renderer html #110599
    But flutter run does not support the option --web-renderer any more.
    I remember i heard html web rendering is discontinued.
    So, question: how to model runtime environment targeted by the tests under /engine/src/flutter/lib/web_ui/test?

  2. How to run the tests themselves?
    This is the failure:

image/image_test.dart: Image constructor invokes onCreate once [E]                                                                                                                  
  LateInitializationError: Field '' has not been initialized.
  org-dartlang-sdk:///lib/_internal/js_runtime/lib/js_helper.dart 1209:19  Object.wrapException
  org-dartlang-sdk:///lib/_internal/js_runtime/lib/late_helper.dart 79:34  _Cell._readField
  org-dartlang-sdk:///lib/_internal/js_runtime/lib/late_helper.dart 71:23  _Cell.readField
  org-dartlang-sdk:///lib/_internal/js_runtime/lib/late_helper.dart 71:5   _Cell.readField
  ../../lib/src/engine/canvaskit/canvaskit_api.dart 28:16                  Object.canvasKit
  ../../lib/src/engine/canvaskit/canvaskit_api.dart 650:3                  <fn>
  ../../lib/src/engine/canvaskit/canvaskit_api.dart 655:10                 Object.toSkClipOp
  ../../lib/src/engine/canvaskit/canvas.dart 56:39                         CkCanvas.clipRect
  ../../lib/src/engine/canvaskit/canvaskit_canvas.dart 120:5               CanvasKitCanvas._clipRect
  

To run this test again: /b/s/w/ir/cache/builder/engine/src/flutter/prebuilts/linux-x64/dart-sdk/bin/dart test image/image_test.dart -p chrome --plain-name 'Image constructor invokes onCreate once'

It is not obvious, but after some thinking I see that
I need to run dart test with flags for the test, from the folder /engine/src/flutter/lib/web_ui.
And this dart should be not one that is globally installed on my mac, but one built in engine/src/flutter/prebuilts.

Sounds correct?

I followed https://github.com/flutter/flutter/blob/master/engine/README.md#gclient-bootstrap and ran gclient sync.

I got this error: gclient sync /Users/polinach/_/platform/depot_tools/.cipd_bin WARNING: subprocess '"git" "-c" "core.deltaBaseCacheLimit=2g" "clone" "--no-checkout" "--progress" "https://dart.googlesource.com/sdk.git" "/Users/polinach/_/flutter_dev/engine/src/flutter/third_party/_gclient_dart_jrt8a_5f"' in /Users/polinach/_/flutter_dev failed; will retry after a short nap...

engine/src/flutter/third_party/dart (ERROR)

[0:01:24] Started.
[0:01:24]

________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout --progress https://dart.googlesource.com/sdk.git /Users/polinach/_/flutter_dev/engine/src/flutter/third_party/gclient_dart_jrt8a_5f' in '/Users/polinach//flutter_dev'

[0:01:24] Cloning into '/Users/polinach/_/flutter_dev/engine/src/flutter/third_party/gclient_dart_jrt8a_5f'...
[0:01:24] git-remote-sso: 2025/01/26 14:26:59 loading SSO cookie: CorpSSO login required. To log in, run glogin or gcert
[0:01:24] fatal: remote helper 'sso' aborted session
[0:01:26]
________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout --progress https://dart.googlesource.com/sdk.git /Users/polinach/
/flutter_dev/engine/src/flutter/third_party/gclient_dart_jrt8a_5f' in '/Users/polinach//flutter_dev' attempt 2 / 2

[0:01:26] Cloning into '/Users/polinach//flutter_dev/engine/src/flutter/third_party/gclient_dart_jrt8a_5f'...
[0:01:27] git-remote-sso: 2025/01/26 14:27:02 loading SSO cookie: CorpSSO login required. To log in, run glogin or gcert
[0:01:27] fatal: remote helper 'sso' aborted session
Traceback (most recent call last):
File "/Users/polinach/
/platform/depot_tools/gclient_scm.py", line 1398, in Clone
self.Run(clone_cmd,
File "/Users/polinach/
/platform/depot_tools/gclient_scm.py", line 1745, in Run
gclient_utils.CheckCallAndFilter(cmd, env=env, **kwargs)
File "/Users/polinach/
/platform/depot_tools/gclient_utils.py", line 733, in CheckCallAndFilter
raise subprocess2.CalledProcessError(rv, args, kwargs.get('cwd', None),
subprocess2.CalledProcessError: Command 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout --progress https://dart.googlesource.com/sdk.git /Users/polinach/
/flutter_dev/engine/src/flutter/third_party/gclient_dart_jrt8a_5f' returned non-zero exit status 128 in /Users/polinach//flutter_dev
[0:01:31] _____ Conflicting directory found in /Users/polinach/
/flutter_dev/engine/src/flutter/third_party/dart. Moving to /Users/polinach/_/flutter_dev/_bad_scm/engine/src/flutter/third_party/dartdsiot8rb.

Warnings:
Conflicting directory /Users/polinach//flutter_dev/engine/src/flutter/third_party/dart moved to /Users/polinach//flutter_dev/bad_scm/engine/src/flutter/third_party/dartdsiot8rb.
Traceback (most recent call last):
File "/Users/polinach/
/platform/depot_tools/gclient_scm.py", line 832, in update
self.current_revision = self.Clone(revision, url, options)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/polinach/
/platform/depot_tools/gclient_scm.py", line 1398, in Clone
self.Run(clone_cmd,
File "/Users/polinach/
/platform/depot_tools/gclient_scm.py", line 1745, in Run
gclient_utils.CheckCallAndFilter(cmd, env=env, **kwargs)
File "/Users/polinach/
/platform/depot_tools/gclient_utils.py", line 733, in CheckCallAndFilter
raise subprocess2.CalledProcessError(rv, args, kwargs.get('cwd', None),
subprocess2.CalledProcessError: Command 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout --progress https://dart.googlesource.com/sdk.git /Users/polinach/
/flutter_dev/engine/src/flutter/third_party/gclient_dart_jrt8a_5f' returned non-zero exit status 128 in /Users/polinach//flutter_dev

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/Users/polinach/Library/Caches/vpython-root.709663/store/cpython+b1ggcnevh3ekhef6bb2fgqn9eg/contents/lib/python3.11/shutil.py", line 853, in move
os.rename(src, real_dst)
FileNotFoundError: [Errno 2] No such file or directory: '/Users/polinach//flutter_dev/engine/src/flutter/third_party/dart' -> '/Users/polinach//flutter_dev/_bad_scm/engine/src/flutter/third_party/dartdsiot8rb/dart'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/Users/polinach//platform/depot_tools/metrics.py", line 302, in print_notice_and_exit
yield
File "/Users/polinach/
/platform/depot_tools/gclient.py", line 4670, in
sys.exit(main(sys.argv[1:]))
^^^^^^^^^^^^^^^^^^
File "/Users/polinach//platform/depot_tools/gclient.py", line 4656, in main
return dispatcher.execute(OptionParser(), argv)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/polinach/
/platform/depot_tools/subcommand.py", line 254, in execute
return command(parser, args[1:])
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/polinach//platform/depot_tools/metrics.py", line 283, in inner
return self.collect_metrics(func, command_name, *args,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/polinach/
/platform/depot_tools/metrics.py", line 268, in collect_metrics
gclient_utils.reraise(exception[0], exception[1], exception[2])
File "/Users/polinach/
/platform/depot_tools/gclient_utils.py", line 54, in reraise
raise value
File "/Users/polinach/
/platform/depot_tools/metrics.py", line 225, in collect_metrics
result = func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/Users/polinach/
/platform/depot_tools/gclient.py", line 4009, in CMDsync
ret = client.RunOnDeps('update', args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/polinach/
/platform/depot_tools/gclient.py", line 2449, in RunOnDeps
work_queue.flush(revision_overrides,
File "/Users/polinach//platform/depot_tools/gclient_utils.py", line 987, in flush
self.run_one_task(self.queued.pop(i), args,
File "/Users/polinach/
/platform/depot_tools/gclient_utils.py", line 1084, in run_one_task
task_item.run(*args, **kwargs)
File "/Users/polinach/
/platform/depot_tools/gclient.py", line 1251, in run
self.got_revision = self.used_scm.RunCommand(
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/polinach/
/platform/depot_tools/gclient_scm.py", line 137, in RunCommand
return getattr(self, command)(options, args, file_list)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/polinach/
/platform/depot_tools/gclient_scm.py", line 664, in wrapper
return_val = f(*args)
^^^^^^^^
File "/Users/polinach/
/platform/depot_tools/gclient_scm.py", line 835, in update
self.DeleteOrMove(options.force)
File "/Users/polinach/
/platform/depot_tools/gclient_scm.py", line 209, in DeleteOrMove
shutil.move(self.checkout_path, dest_path)
File "/Users/polinach/Library/Caches/vpython-root.709663/store/cpython+b1ggcnevh3ekhef6bb2fgqn9eg/contents/lib/python3.11/shutil.py", line 873, in move
copy_function(src, real_dst)
File "/Users/polinach/Library/Caches/vpython-root.709663/store/cpython+b1ggcnevh3ekhef6bb2fgqn9eg/contents/lib/python3.11/shutil.py", line 448, in copy2
copyfile(src, dst, follow_symlinks=follow_symlinks)
File "/Users/polinach/Library/Caches/vpython-root.709663/store/cpython+b1ggcnevh3ekhef6bb2fgqn9eg/contents/lib/python3.11/shutil.py", line 256, in copyfile
with open(src, 'rb') as fsrc:
^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/Users/polinach/
/flutter_dev/engine/src/flutter/third_party/dart'
+========================================================+
| WE ARE COLLECTING ADDITIONAL METRICS |
| |
| Please review the changes and opt-in again. |
| |
| We will start collecting metrics for experiment flags. |
| These are boolean or enum values that show whether |
| you have opted in to or out of experimental features |
+========================================================+
+===================================================+
| METRICS COLLECTION WILL START IN 10 EXECUTIONS |
| |
| To suppress this message opt in or out using: |
| $ gclient metrics [--opt-in] [--opt-out] |
| For more information please see metrics.README.md |
| in your depot_tools checkout or visit |
| https://bit.ly/3MpLAYM. |
+===================================================+
WARNING: subprocess '"git" "-c" "core.deltaBaseCacheLimit=2g" "clone" "--no-checkout" "--progress" "https://dart.googlesource.com/sdk.git" "/Users/polinach/_/flutter_dev/engine/src/flutter/third_party/gclient_dart_jrt8a_5f"' in /Users/polinach//flutter_dev failed; will retry after a short nap...

Should I file a bug or I just missed some important step and may be it should be just simple fix for the doc?

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
)

Manual roll requested by [email protected]

flutter/flutter@c1561a4...c1ffaa9

2025-01-24 [email protected] Fix link to hotfix documentation best practices (flutter/flutter#162116)
2025-01-24 [email protected] Add integration test for cutout rotation evaluation (flutter/flutter#160354)
2025-01-24 [email protected] Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146)
2025-01-24 [email protected] Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235)
2025-01-24 [email protected] When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455)
2025-01-24 [email protected] [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052)
2025-01-24 [email protected] Add to Setup Path Example to Engine README (flutter/flutter#162115)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122)
2025-01-23 [email protected] feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424)
2025-01-23 [email protected] Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100)
2025-01-23 [email protected] Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493)
2025-01-23 [email protected] Unskip test. (flutter/flutter#162106)
2025-01-23 [email protected] Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076)
2025-01-23 [email protected] Roll pub packages (flutter/flutter#162095)
2025-01-23 [email protected] Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050)
2025-01-23 [email protected] Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)
2025-01-23 [email protected] flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047)
2025-01-23 [email protected] [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082)
2025-01-23 [email protected] Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459)
2025-01-23 [email protected] Show error on macOS if missing Local Network permissions (flutter/flutter#161846)
2025-01-23 [email protected] Autocomplete keyboard navigation (flutter/flutter#159455)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
)

Manual roll requested by [email protected]

flutter/flutter@c1561a4...c1ffaa9

2025-01-24 [email protected] Fix link to hotfix documentation best practices (flutter/flutter#162116)
2025-01-24 [email protected] Add integration test for cutout rotation evaluation (flutter/flutter#160354)
2025-01-24 [email protected] Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146)
2025-01-24 [email protected] Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235)
2025-01-24 [email protected] When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455)
2025-01-24 [email protected] [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052)
2025-01-24 [email protected] Add to Setup Path Example to Engine README (flutter/flutter#162115)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122)
2025-01-23 [email protected] feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424)
2025-01-23 [email protected] Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100)
2025-01-23 [email protected] Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493)
2025-01-23 [email protected] Unskip test. (flutter/flutter#162106)
2025-01-23 [email protected] Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076)
2025-01-23 [email protected] Roll pub packages (flutter/flutter#162095)
2025-01-23 [email protected] Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050)
2025-01-23 [email protected] Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)
2025-01-23 [email protected] flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047)
2025-01-23 [email protected] [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082)
2025-01-23 [email protected] Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459)
2025-01-23 [email protected] Show error on macOS if missing Local Network permissions (flutter/flutter#161846)
2025-01-23 [email protected] Autocomplete keyboard navigation (flutter/flutter#159455)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels. platform-web Web applications specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants