Skip to content

Conversation

@dcharkes
Copy link
Contributor

Rolling in dart-lang/native#1933.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 23, 2025
@HosseinYousefi HosseinYousefi self-requested a review January 23, 2025 13:26
@dcharkes dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jan 23, 2025
Merged via the queue into master with commit 663d020 Jan 23, 2025
163 checks passed
@auto-submit auto-submit bot deleted the roll-native-2 branch January 23, 2025 14:13
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 23, 2025
Manual roll requested by [email protected]

flutter/flutter@b2f515f...c1561a4

2025-01-23 [email protected] Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032)
2025-01-23 [email protected] Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042)
2025-01-23 [email protected] [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043)
2025-01-23 [email protected] [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834)
2025-01-23 [email protected] Keyboard tidy ups (flutter/flutter#162054)
2025-01-23 [email protected] fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131)
2025-01-23 [email protected] fix: Call codec.dispose in `dev/` (flutter/flutter#161112)
2025-01-23 [email protected] Replace hacky code creating fake devices (flutter/flutter#162056)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162068)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162017)
2025-01-23 [email protected] Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975)
2025-01-23 [email protected] Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023)
2025-01-23 [email protected] Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822)
2025-01-23 [email protected] [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838)
2025-01-23 [email protected] Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull request Jan 24, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
)

Manual roll requested by [email protected]

flutter/flutter@b2f515f...c1561a4

2025-01-23 [email protected] Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032)
2025-01-23 [email protected] Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042)
2025-01-23 [email protected] [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043)
2025-01-23 [email protected] [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834)
2025-01-23 [email protected] Keyboard tidy ups (flutter/flutter#162054)
2025-01-23 [email protected] fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131)
2025-01-23 [email protected] fix: Call codec.dispose in `dev/` (flutter/flutter#161112)
2025-01-23 [email protected] Replace hacky code creating fake devices (flutter/flutter#162056)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162068)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162017)
2025-01-23 [email protected] Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975)
2025-01-23 [email protected] Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023)
2025-01-23 [email protected] Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822)
2025-01-23 [email protected] [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838)
2025-01-23 [email protected] Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
)

Manual roll requested by [email protected]

flutter/flutter@b2f515f...c1561a4

2025-01-23 [email protected] Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032)
2025-01-23 [email protected] Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042)
2025-01-23 [email protected] [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043)
2025-01-23 [email protected] [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834)
2025-01-23 [email protected] Keyboard tidy ups (flutter/flutter#162054)
2025-01-23 [email protected] fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131)
2025-01-23 [email protected] fix: Call codec.dispose in `dev/` (flutter/flutter#161112)
2025-01-23 [email protected] Replace hacky code creating fake devices (flutter/flutter#162056)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162068)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162017)
2025-01-23 [email protected] Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975)
2025-01-23 [email protected] Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023)
2025-01-23 [email protected] Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822)
2025-01-23 [email protected] [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838)
2025-01-23 [email protected] Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants