[DisplayList] Move nested canvas enums into their own TU. #162037

chinmaygarde · 2025-01-22T21:57:45Z

These cause ambiguous compiler reference errors on some GCC versions. And, the errors seem right. But, newer versions of clang seem to resolve that ambiguity by also checking if the references to the types are also references to identical types.

Per the chat with Jim, also added the Dl prefix to those types.

No change in functionality. Just a rename of the types and removal of the now unnecessary typedefs.

flar

RSLGTM

If there is anything in here that isn't a simple text substitution, point me at it for specific verification.

I have a PR in the merge queue that has 100s of changes to all of the impeller unit tests so ... heads up!

flar · 2025-01-22T22:27:08Z

And, the other PR just landed causing all of those file conflicts. Sowwy!

chinmaygarde · 2025-01-22T22:27:40Z

No. It's just simple substitution.

Sowwy!

lol. All good. Seems like a simple fix.

chinmaygarde · 2025-01-22T22:38:59Z

okie dokie, I've cleared the conflicts.

auto-submit · 2025-01-22T23:38:21Z

auto label is removed for flutter/flutter/162037, due to - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label.

chinmaygarde · 2025-01-23T19:00:49Z

@flar Looks like you backed out the change. I've patched it again but you may have amend your patch when you re-land.

flutter-dashboard · 2025-01-23T20:10:19Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #162037 at sha 367d9dc

flutter-dashboard · 2025-01-23T23:23:16Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #162037 at sha d0f512d

auto-submit · 2025-01-24T12:56:26Z

autosubmit label was removed for flutter/flutter/162037, because Pull request flutter/flutter/162037 is not in a mergeable state.

flar · 2025-01-25T21:23:23Z

The underlying change is back in, you likely just have to rebase to get this ready to land again...

These cause ambiguous compiler reference errors on some GCC versions. And, the errors seem right. But, newer versions of clang seem to resolve that ambiguity by also checking if the references to the types are also references to identical types. Per the chat with Jim, also added the Dl prefix to those types. No change in functionality. Just a rename of the types and removal of the now unnecessary typedefs.

…utter/flutter#162037)

Roll Flutter from c1ffaa9 to b007899 (43 revisions) flutter/flutter@c1ffaa9...b007899 2025-01-29 [email protected] Fix `Tab` linear and elastic animation blink (flutter/flutter#162315) 2025-01-29 [email protected] Pass-through `textInputAction` in `DropdownMenu` (flutter/flutter#162309) 2025-01-29 [email protected] Fix scrollUntilVisible in WidgetTester (flutter/flutter#159582) 2025-01-29 [email protected] Pass-through `maxLines` in `DropdownMenu` (flutter/flutter#161903) 2025-01-29 [email protected] fix: appbar leading width is not square for custom toolbar height (flutter/flutter#161880) 2025-01-29 [email protected] [DisplayList] Don't call Skia Ganesh methods when its not available. (flutter/flutter#162345) 2025-01-29 [email protected] Update README.md to include googler post verification steps (flutter/flutter#162272) 2025-01-29 [email protected] [engine, web] return switch expressions in many places (flutter/flutter#162336) 2025-01-29 [email protected] Update README.md to not have engine link for android (flutter/flutter#162330) 2025-01-29 [email protected] Reland "[ Widget Previews ] Add support for detecting previews and generating code (#161911)"" (flutter/flutter#162337) 2025-01-29 [email protected] Add instructions to download the Gradle wrapper to FGP readme, and add to gitignore (flutter/flutter#162332) 2025-01-29 [email protected] Fix tests to prepare for `--explicit-package-dependencies` and a bug. (flutter/flutter#162289) 2025-01-29 [email protected] Add a currently unused `runs_in_merge_queue` property to `Linux analyze`. (flutter/flutter#162335) 2025-01-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Widget Previews ] Add support for detecting previews and generating code (#161911)" (flutter/flutter#162327) 2025-01-28 [email protected] Support hot restart for DDC library bundle format (flutter/flutter#162123) 2025-01-28 [email protected] Started adjusting uvs to match pixel snapping. (flutter/flutter#162049) 2025-01-28 [email protected] Refactor code inside flutter.groovy (flutter/flutter#160250) 2025-01-28 [email protected] Table implements redepth (flutter/flutter#162282) 2025-01-28 [email protected] [ Widget Previews ] Add support for detecting previews and generating code (flutter/flutter#161911) 2025-01-28 [email protected] remove dependency on `Usage` from `Pub` class (flutter/flutter#162279) 2025-01-28 [email protected] Roll Packages from 258f6dc to 02c6fef (6 revisions) (flutter/flutter#162313) 2025-01-28 [email protected] Remove `scenario_app/android` and rename to `ios_scenario_app`. (flutter/flutter#160992) 2025-01-28 [email protected] Apparently it is illegal to use `stderr` in this project. (flutter/flutter#162294) 2025-01-28 [email protected] Fix update_engine_version_test in presence of FLUTTER_PREBUILT_ENGINE_VERSION env vars. (flutter/flutter#162270) 2025-01-28 [email protected] Add missing `properties: ...` and move to presubmit. (flutter/flutter#162170) 2025-01-27 [email protected] [Impeller] make swapchain related external fence/semaphore extensions optional. (flutter/flutter#162205) 2025-01-27 49699333+dependabot[bot]@users.noreply.github.com Bump the all-github-actions group with 2 updates (flutter/flutter#162277) 2025-01-27 [email protected] Don't depend on Dart from FML. (flutter/flutter#162271) 2025-01-27 [email protected] [DisplayList] Move nested canvas enums into their own TU. (flutter/flutter#162037) 2025-01-27 [email protected] Avoid iOS text selection crash by returning nil range (flutter/flutter#161996) 2025-01-27 [email protected] fix `felt` link to point to flutter repo instead of the engine repo (flutter/flutter#161423) 2025-01-27 [email protected] Enable the Android Engine OpenGLES/Vulkan suites. (flutter/flutter#162258) 2025-01-27 [email protected] [canvaskit] Fix debug build for CanvasKit (flutter/flutter#162198) 2025-01-27 [email protected] Roll Packages from 3d3ab7b to 258f6dc (19 revisions) (flutter/flutter#162254) 2025-01-25 [email protected] Pin `customer_testing` to the SHA specified in `tests.version` (flutter/flutter#162048) 2025-01-25 [email protected] Formalize `update_engine_version.{sh|ps1}`. (flutter/flutter#162118) 2025-01-25 [email protected] Rename 'SelectionChangedCause.scribble' to 'SelectionChangedCause.stylusHandwriting' (flutter/flutter#161518) 2025-01-25 [email protected] Don't install xcode when doing `local_engine` web builds on mac. (flutter/flutter#162164) 2025-01-25 [email protected] Force Impeller backend for `android_engine_test`, and test both OpenGLES and Vulkan (flutter/flutter#162089) 2025-01-24 [email protected] [Impeller] when a command pool has many unused buffers, reset with release resources flag. (flutter/flutter#162171) 2025-01-24 [email protected] [web] Remove HTML renderer from framework tests (flutter/flutter#162038) 2025-01-24 [email protected] [Impeller] Skip clip entity replay that cannot impact current clip. (flutter/flutter#162113) 2025-01-24 [email protected] Update Android integration test package for newer AGP (flutter/flutter#161856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ...

…utter/flutter#162037)

Roll Flutter from c1ffaa9 to b007899 (43 revisions) flutter/flutter@c1ffaa9...b007899 2025-01-29 [email protected] Fix `Tab` linear and elastic animation blink (flutter/flutter#162315) 2025-01-29 [email protected] Pass-through `textInputAction` in `DropdownMenu` (flutter/flutter#162309) 2025-01-29 [email protected] Fix scrollUntilVisible in WidgetTester (flutter/flutter#159582) 2025-01-29 [email protected] Pass-through `maxLines` in `DropdownMenu` (flutter/flutter#161903) 2025-01-29 [email protected] fix: appbar leading width is not square for custom toolbar height (flutter/flutter#161880) 2025-01-29 [email protected] [DisplayList] Don't call Skia Ganesh methods when its not available. (flutter/flutter#162345) 2025-01-29 [email protected] Update README.md to include googler post verification steps (flutter/flutter#162272) 2025-01-29 [email protected] [engine, web] return switch expressions in many places (flutter/flutter#162336) 2025-01-29 [email protected] Update README.md to not have engine link for android (flutter/flutter#162330) 2025-01-29 [email protected] Reland "[ Widget Previews ] Add support for detecting previews and generating code (#161911)"" (flutter/flutter#162337) 2025-01-29 [email protected] Add instructions to download the Gradle wrapper to FGP readme, and add to gitignore (flutter/flutter#162332) 2025-01-29 [email protected] Fix tests to prepare for `--explicit-package-dependencies` and a bug. (flutter/flutter#162289) 2025-01-29 [email protected] Add a currently unused `runs_in_merge_queue` property to `Linux analyze`. (flutter/flutter#162335) 2025-01-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Widget Previews ] Add support for detecting previews and generating code (#161911)" (flutter/flutter#162327) 2025-01-28 [email protected] Support hot restart for DDC library bundle format (flutter/flutter#162123) 2025-01-28 [email protected] Started adjusting uvs to match pixel snapping. (flutter/flutter#162049) 2025-01-28 [email protected] Refactor code inside flutter.groovy (flutter/flutter#160250) 2025-01-28 [email protected] Table implements redepth (flutter/flutter#162282) 2025-01-28 [email protected] [ Widget Previews ] Add support for detecting previews and generating code (flutter/flutter#161911) 2025-01-28 [email protected] remove dependency on `Usage` from `Pub` class (flutter/flutter#162279) 2025-01-28 [email protected] Roll Packages from 258f6dc to 02c6fef (6 revisions) (flutter/flutter#162313) 2025-01-28 [email protected] Remove `scenario_app/android` and rename to `ios_scenario_app`. (flutter/flutter#160992) 2025-01-28 [email protected] Apparently it is illegal to use `stderr` in this project. (flutter/flutter#162294) 2025-01-28 [email protected] Fix update_engine_version_test in presence of FLUTTER_PREBUILT_ENGINE_VERSION env vars. (flutter/flutter#162270) 2025-01-28 [email protected] Add missing `properties: ...` and move to presubmit. (flutter/flutter#162170) 2025-01-27 [email protected] [Impeller] make swapchain related external fence/semaphore extensions optional. (flutter/flutter#162205) 2025-01-27 49699333+dependabot[bot]@users.noreply.github.com Bump the all-github-actions group with 2 updates (flutter/flutter#162277) 2025-01-27 [email protected] Don't depend on Dart from FML. (flutter/flutter#162271) 2025-01-27 [email protected] [DisplayList] Move nested canvas enums into their own TU. (flutter/flutter#162037) 2025-01-27 [email protected] Avoid iOS text selection crash by returning nil range (flutter/flutter#161996) 2025-01-27 [email protected] fix `felt` link to point to flutter repo instead of the engine repo (flutter/flutter#161423) 2025-01-27 [email protected] Enable the Android Engine OpenGLES/Vulkan suites. (flutter/flutter#162258) 2025-01-27 [email protected] [canvaskit] Fix debug build for CanvasKit (flutter/flutter#162198) 2025-01-27 [email protected] Roll Packages from 3d3ab7b to 258f6dc (19 revisions) (flutter/flutter#162254) 2025-01-25 [email protected] Pin `customer_testing` to the SHA specified in `tests.version` (flutter/flutter#162048) 2025-01-25 [email protected] Formalize `update_engine_version.{sh|ps1}`. (flutter/flutter#162118) 2025-01-25 [email protected] Rename 'SelectionChangedCause.scribble' to 'SelectionChangedCause.stylusHandwriting' (flutter/flutter#161518) 2025-01-25 [email protected] Don't install xcode when doing `local_engine` web builds on mac. (flutter/flutter#162164) 2025-01-25 [email protected] Force Impeller backend for `android_engine_test`, and test both OpenGLES and Vulkan (flutter/flutter#162089) 2025-01-24 [email protected] [Impeller] when a command pool has many unused buffers, reset with release resources flag. (flutter/flutter#162171) 2025-01-24 [email protected] [web] Remove HTML renderer from framework tests (flutter/flutter#162038) 2025-01-24 [email protected] [Impeller] Skip clip entity replay that cannot impact current clip. (flutter/flutter#162113) 2025-01-24 [email protected] Update Android integration test package for newer AGP (flutter/flutter#161856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ...

chinmaygarde requested a review from flar January 22, 2025 21:57

github-actions bot added a: text input Entering text in a text field or keyboard related problems platform-android Android applications specifically engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jan 22, 2025

chinmaygarde force-pushed the ambig branch from 4917504 to bcc86f2 Compare January 22, 2025 21:59

flar approved these changes Jan 22, 2025

View reviewed changes

chinmaygarde force-pushed the ambig branch from bcc86f2 to 2609734 Compare January 22, 2025 22:38

chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

chinmaygarde force-pushed the ambig branch from 2609734 to 367d9dc Compare January 23, 2025 19:00

chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

flutter-dashboard bot added the will affect goldens Changes to golden files label Jan 23, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2025

chinmaygarde force-pushed the ambig branch from d0f512d to 9ed378d Compare January 27, 2025 19:54

chinmaygarde added 2 commits January 27, 2025 11:54

Ping.

33ada53

Pong.

f001f12

chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 27, 2025

chinmaygarde added this pull request to the merge queue Jan 27, 2025

Merged via the queue into flutter:master with commit cd586ee Jan 27, 2025
180 checks passed

chinmaygarde deleted the ambig branch January 27, 2025 22:35

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 27, 2025

engine-flutter-autoroll mentioned this pull request Jan 28, 2025

Roll Flutter from c1ffaa9d9deb to 9e273d5e6e2e (22 revisions) flutter/packages#8520

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2025

cd586ee [DisplayList] Move nested canvas enums into their own TU. (fl…

2e23e54

…utter/flutter#162037)

engine-flutter-autoroll mentioned this pull request Jan 28, 2025

Roll Flutter from c1ffaa9d9deb to 21f7283f5dfb (23 revisions) flutter/packages#8522

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2025

cd586ee [DisplayList] Move nested canvas enums into their own TU. (fl…

d1c6a4f

…utter/flutter#162037)

engine-flutter-autoroll mentioned this pull request Jan 28, 2025

Roll Flutter from c1ffaa9d9deb to a9c50335c736 (24 revisions) flutter/packages#8523

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2025

cd586ee [DisplayList] Move nested canvas enums into their own TU. (fl…

071fa43

…utter/flutter#162037)

engine-flutter-autoroll mentioned this pull request Jan 29, 2025

Roll Flutter from c1ffaa9d9deb to b007899d3a7a (43 revisions) flutter/packages#8527

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2025

cd586ee [DisplayList] Move nested canvas enums into their own TU. (fl…

1c0b174

…utter/flutter#162037)

jmagman mentioned this pull request Feb 19, 2025

"Golden file changes have been found for this pull request", no images found #163647

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

cd586ee [DisplayList] Move nested canvas enums into their own TU. (fl…

7c8e1f5

…utter/flutter#162037)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

cd586ee [DisplayList] Move nested canvas enums into their own TU. (fl…

9c389a6

…utter/flutter#162037)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

cd586ee [DisplayList] Move nested canvas enums into their own TU. (fl…

b542f7d

…utter/flutter#162037)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[DisplayList] Move nested canvas enums into their own TU. #162037

[DisplayList] Move nested canvas enums into their own TU. #162037

Uh oh!

chinmaygarde commented Jan 22, 2025

Uh oh!

flar left a comment

Uh oh!

flar commented Jan 22, 2025

Uh oh!

chinmaygarde commented Jan 22, 2025

Uh oh!

chinmaygarde commented Jan 22, 2025

Uh oh!

auto-submit bot commented Jan 22, 2025

Uh oh!

chinmaygarde commented Jan 23, 2025

Uh oh!

flutter-dashboard bot commented Jan 23, 2025

Uh oh!

flutter-dashboard bot commented Jan 23, 2025

Uh oh!

auto-submit bot commented Jan 24, 2025

Uh oh!

flar commented Jan 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[DisplayList] Move nested canvas enums into their own TU. #162037

[DisplayList] Move nested canvas enums into their own TU. #162037

Uh oh!

Conversation

chinmaygarde commented Jan 22, 2025

Uh oh!

flar left a comment

Choose a reason for hiding this comment

Uh oh!

flar commented Jan 22, 2025

Uh oh!

chinmaygarde commented Jan 22, 2025

Uh oh!

chinmaygarde commented Jan 22, 2025

Uh oh!

auto-submit bot commented Jan 22, 2025

Uh oh!

chinmaygarde commented Jan 23, 2025

Uh oh!

flutter-dashboard bot commented Jan 23, 2025

Uh oh!

flutter-dashboard bot commented Jan 23, 2025

Uh oh!

auto-submit bot commented Jan 24, 2025

Uh oh!

flar commented Jan 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants