Expand the `.ci.yaml` and `builder.json` linter #161991

matanlurey · 2025-01-22T02:14:25Z

Other than the integration test included, example output looks like this:

# Assuming you are in $ENGINE/src/flutter
% dart tools/pkg/engine_build_configs/bin/check.dart --help
-v, --verbose                                  Enable noisier diagnostic output
-h, --help                                     Output usage information.
    --engine-src-path=</path/to/engine/src>    (defaults to "/Users/matanl/Developer/flutter/engine/src")

% dart tools/pkg/engine_build_configs/bin/check.dart       
✅ Loaded build configs under ci/builders
✅ .ci.yaml at .ci.yaml is valid
✅ All configuration files are valid
✅ All builds within a builder are uniquely named
✅ All build names must have a conforming prefix
✅ All builder files conform to release_build standards

I allow-listed a single case that needs to be moved, but I think this provides value already.

…der-lint

zanderso

Seems reasonable. Just a couple small comments.

zanderso · 2025-01-22T16:15:38Z

engine/src/flutter/tools/pkg/engine_build_configs/bin/check.dart

+    }
+  }
+
+  final supportsEmojis = !platform.isWindows || platform.environment.containsKey('WT_SESSION');


Could you check how the emojis come through in the logs? If they're garbled or placeholders, maybe you can plumb stdout.hasTerminal through a boolean parameter to run().

Looks good!

zanderso · 2025-01-22T16:43:10Z

engine/src/flutter/tools/pkg/engine_build_configs/bin/check.dart

+
+    final configConventionErrors = <String>[];
+    if (target.properties.isReleaseBuilder) {
+      // If there is a global generators step, assume it is doing something unscrupulous.


maybe instead: assume artifacts are uploaded from the generators

auto-submit · 2025-01-22T17:42:27Z

auto label is removed for flutter/flutter/161991, due to - The status or check suite Linux mac_android_aot_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Merge Queue Guard has failed. Please fix the issues identified (or deflake) before re-applying this label.

…ter#161991)

Manual roll Flutter from b9e86a5 to b2f515f (42 revisions) Manual roll requested by [email protected] flutter/flutter@b9e86a5...b2f515f 2025-01-22 [email protected] Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035) 2025-01-22 [email protected] `const AnimationStyle` (flutter/flutter#160564) 2025-01-22 [email protected] Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020) 2025-01-22 [email protected] [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855) 2025-01-22 [email protected] Experiment with a `files-changed.json` per PR (flutter/flutter#161788) 2025-01-22 [email protected] Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925) 2025-01-22 [email protected] Roll Packages from e8f1f63 to 3d3ab7b (1 revision) (flutter/flutter#162019) 2025-01-22 [email protected] Adds cupertino picker semantics test (flutter/flutter#161768) 2025-01-22 [email protected] [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775) 2025-01-22 [email protected] fix: Add enabled property for search anchor named constructor (flutter/flutter#161468) 2025-01-22 [email protected] Roll pub packages (flutter/flutter#162015) 2025-01-22 [email protected] [web] Remove spam from test output (flutter/flutter#161774) 2025-01-22 [email protected] Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577) 2025-01-22 [email protected] Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016) 2025-01-22 [email protected] Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622) 2025-01-22 [email protected] [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537) 2025-01-22 [email protected] Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991) 2025-01-22 [email protected] Fix incorrect [enabled] documentation (flutter/flutter#161650) 2025-01-22 [email protected] Add `windows_host_engine_test`. (flutter/flutter#161992) 2025-01-22 [email protected] Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989) 2025-01-22 [email protected] Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024) 2025-01-22 [email protected] [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981) 2025-01-22 [email protected] Merge changelog for 3.27.3 release (flutter/flutter#161977) 2025-01-21 [email protected] Remove FlKeyboardViewDelegate (flutter/flutter#161705) 2025-01-21 [email protected] Fix documentation of Flow.clipBehavior (flutter/flutter#161863) 2025-01-21 [email protected] [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841) 2025-01-21 [email protected] [Impeller] backfilling TextContents unit tests (flutter/flutter#161625) 2025-01-21 [email protected] Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824) 2025-01-21 [email protected] fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301) 2025-01-21 [email protected] Get `et` working for local web engine builds. (flutter/flutter#161825) 2025-01-21 [email protected] Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994) 2025-01-21 [email protected] Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656) 2025-01-21 [email protected] Don't crash flutter tool if Chrome is not available (flutter/flutter#154941) 2025-01-21 [email protected] Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717) 2025-01-21 [email protected] [native assets] Cleanup dead code 2 (flutter/flutter#161916) 2025-01-21 [email protected] Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811) 2025-01-21 [email protected] Roll pub packages (flutter/flutter#161924) 2025-01-21 [email protected] Make `PipelineOwner` a `base` class (flutter/flutter#161789) 2025-01-20 [email protected] [native assets] Cleanup dead code (flutter/flutter#161913) 2025-01-20 [email protected] Roll Packages from f73cb00 to e8f1f63 (9 revisions) (flutter/flutter#161914) 2025-01-20 [email protected] [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917) 2025-01-19 [email protected] Update documentation on what display information is provided. (flutter/flutter#161785) If this roll has caused a breakage, revert this CL and stop the roller ...

Closes flutter#161823. Other than the integration test included, example output looks like this: ```dart # Assuming you are in $ENGINE/src/flutter % dart tools/pkg/engine_build_configs/bin/check.dart --help -v, --verbose Enable noisier diagnostic output -h, --help Output usage information. --engine-src-path=</path/to/engine/src> (defaults to "/Users/matanl/Developer/flutter/engine/src") % dart tools/pkg/engine_build_configs/bin/check.dart ✅ Loaded build configs under ci/builders ✅ .ci.yaml at .ci.yaml is valid ✅ All configuration files are valid ✅ All builds within a builder are uniquely named ✅ All build names must have a conforming prefix ✅ All builder files conform to release_build standards ``` I allow-listed a single case that needs to be moved, but I think this provides value already.

…ter#161991)

) Manual roll Flutter from b9e86a5 to b2f515f (42 revisions) Manual roll requested by [email protected] flutter/flutter@b9e86a5...b2f515f 2025-01-22 [email protected] Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035) 2025-01-22 [email protected] `const AnimationStyle` (flutter/flutter#160564) 2025-01-22 [email protected] Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020) 2025-01-22 [email protected] [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855) 2025-01-22 [email protected] Experiment with a `files-changed.json` per PR (flutter/flutter#161788) 2025-01-22 [email protected] Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925) 2025-01-22 [email protected] Roll Packages from e8f1f63 to 3d3ab7b (1 revision) (flutter/flutter#162019) 2025-01-22 [email protected] Adds cupertino picker semantics test (flutter/flutter#161768) 2025-01-22 [email protected] [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775) 2025-01-22 [email protected] fix: Add enabled property for search anchor named constructor (flutter/flutter#161468) 2025-01-22 [email protected] Roll pub packages (flutter/flutter#162015) 2025-01-22 [email protected] [web] Remove spam from test output (flutter/flutter#161774) 2025-01-22 [email protected] Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577) 2025-01-22 [email protected] Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016) 2025-01-22 [email protected] Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622) 2025-01-22 [email protected] [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537) 2025-01-22 [email protected] Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991) 2025-01-22 [email protected] Fix incorrect [enabled] documentation (flutter/flutter#161650) 2025-01-22 [email protected] Add `windows_host_engine_test`. (flutter/flutter#161992) 2025-01-22 [email protected] Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989) 2025-01-22 [email protected] Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024) 2025-01-22 [email protected] [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981) 2025-01-22 [email protected] Merge changelog for 3.27.3 release (flutter/flutter#161977) 2025-01-21 [email protected] Remove FlKeyboardViewDelegate (flutter/flutter#161705) 2025-01-21 [email protected] Fix documentation of Flow.clipBehavior (flutter/flutter#161863) 2025-01-21 [email protected] [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841) 2025-01-21 [email protected] [Impeller] backfilling TextContents unit tests (flutter/flutter#161625) 2025-01-21 [email protected] Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824) 2025-01-21 [email protected] fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301) 2025-01-21 [email protected] Get `et` working for local web engine builds. (flutter/flutter#161825) 2025-01-21 [email protected] Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994) 2025-01-21 [email protected] Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656) 2025-01-21 [email protected] Don't crash flutter tool if Chrome is not available (flutter/flutter#154941) 2025-01-21 [email protected] Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717) 2025-01-21 [email protected] [native assets] Cleanup dead code 2 (flutter/flutter#161916) 2025-01-21 [email protected] Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811) 2025-01-21 [email protected] Roll pub packages (flutter/flutter#161924) 2025-01-21 [email protected] Make `PipelineOwner` a `base` class (flutter/flutter#161789) 2025-01-20 [email protected] [native assets] Cleanup dead code (flutter/flutter#161913) 2025-01-20 [email protected] Roll Packages from f73cb00 to e8f1f63 (9 revisions) (flutter/flutter#161914) 2025-01-20 [email protected] [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917) 2025-01-19 [email protected] Update documentation on what display information is provided. (flutter/flutter#161785) If this roll has caused a breakage, revert this CL and stop the roller ...

matanlurey added 7 commits January 21, 2025 12:50

Expand and cleanup linting for .ci.yaml and engine builders.

f1dac8d

Merge remote-tracking branch 'upstream/main' into expand-ci-yaml-buil…

ec34f07

…der-lint

Finish encoding rules.

f72d897

++

2ed150e

More WIP: Check test.

8f548eb

Add an integration test, finish the check logic.

b04d89b

Update shell script.

9c8a707

matanlurey requested review from jtmcdole and zanderso January 22, 2025 02:14

github-actions bot added the engine flutter/engine related. See also e: labels. label Jan 22, 2025

zanderso reviewed Jan 22, 2025

View reviewed changes

Tweak comment.

f46cc0c

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

zanderso approved these changes Jan 22, 2025

View reviewed changes

jtmcdole approved these changes Jan 22, 2025

View reviewed changes

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

auto-submit bot added this pull request to the merge queue Jan 22, 2025

Merged via the queue into flutter:master with commit 74ab593 Jan 22, 2025
182 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

engine-flutter-autoroll mentioned this pull request Jan 22, 2025

Manual roll Flutter from b9e86a565f92 to b2f515f45ef5 (42 revisions) flutter/packages#8482

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2025

74ab593 Expand the .ci.yaml and builder.json linter (flutter/flut…

b69f3c8

…ter#161991)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

74ab593 Expand the .ci.yaml and builder.json linter (flutter/flut…

4e73b9c

…ter#161991)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

74ab593 Expand the .ci.yaml and builder.json linter (flutter/flut…

c90520e

…ter#161991)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

74ab593 Expand the .ci.yaml and builder.json linter (flutter/flut…

98f838c

…ter#161991)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Expand the `.ci.yaml` and `builder.json` linter #161991

Expand the `.ci.yaml` and `builder.json` linter #161991

Uh oh!

matanlurey commented Jan 22, 2025

Uh oh!

zanderso left a comment

Uh oh!

zanderso Jan 22, 2025

Uh oh!

matanlurey Jan 22, 2025

Uh oh!

zanderso Jan 22, 2025

Uh oh!

matanlurey Jan 22, 2025

Uh oh!

auto-submit bot commented Jan 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Expand the .ci.yaml and builder.json linter #161991

Expand the .ci.yaml and builder.json linter #161991

Uh oh!

Conversation

matanlurey commented Jan 22, 2025

Uh oh!

zanderso left a comment

Choose a reason for hiding this comment

Uh oh!

zanderso Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

zanderso Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Expand the `.ci.yaml` and `builder.json` linter #161991

Expand the `.ci.yaml` and `builder.json` linter #161991