Extract checking IntelliJ packages into a helper and use for Android Studio. #16198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
reviewed
Apr 4, 2018
Contributor
devoncarew
left a comment
devoncarew
left a comment
There was a problem hiding this comment.
Can you add tests for this - specifically IntelliJPlugins.validatepackage()? There are some tests in commands/doctor_test.dart which already test things in a similar way.
devoncarew
approved these changes
Apr 4, 2018
Contributor
devoncarew
left a comment
devoncarew
left a comment
There was a problem hiding this comment.
lgtm once the buildbots are happy
teriyakijack
pushed a commit
to teriyakijack/flutter
that referenced
this pull request
Apr 5, 2018
* upstream/master: Run test coverage in dart2 again (flutter#15932) Roll engine to 23c0b7b (flutter#16254) fix date/time picker borders (flutter#16240) Revert "Roll engine to version 58d6ea3 (flutter#16236)" (flutter#16252) Roll engine to version 58d6ea3 (flutter#16236) Add disable Cupertino Switch example (flutter#15853) Roll engine to ac40891 (flutter#16232) re-enable verify only test failure and update deps. (flutter#16090) Extract checking IntelliJ packages into a helper and use for Android Studio. (flutter#16198) Remove DevToolsSecurity check from initial flutter doctor (flutter#16007) export RawKeyEvent from RawKeyboardListener (flutter#15956) Revert "Adds Java EE module to SDK manager calls" (flutter#16227) update intellij metadata in template files (flutter#16211) Add _PointerState#toString (flutter#16197) add a period after xcode build done (flutter#16209)
tvolkert
reviewed
Apr 7, 2018
| void main() { | ||
| group('IntelliJ', () { | ||
| group('plugins', () { | ||
| testUsingContext('found', () async { |
Contributor
There was a problem hiding this comment.
This test isn't hermetic and is subject to flakiness. We try to ensure that all new tests are hermetic by using MemoryFileSystem, FakePlatform, and a mocked ProcessManager where need be (using context overrides).
Please update this test such that it is hermetic.
Thanks!
Contributor
There was a problem hiding this comment.
Note that this test also fails inside Google (which is how this surfaced) because hermeticity is required.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/flutter-intellij#1438