Skip to content

Add FGP Gradle wrapper to source control #161969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gmackall wants to merge 1 commit into from
Closed

Add FGP Gradle wrapper to source control #161969

gmackall wants to merge 1 commit into from

Conversation

@gmackall
Copy link
Member

@gmackall gmackall commented Jan 21, 2025

Adds the gradlew, gradlew.bat, and gradle/wrapper/gradle-wrapper.properties within packages/flutter_tools/gradle to source control.

These files are not binaries, so it doesn't run afoul of this policy

flutter/dev/bots/analyze.dart

Lines 1695 to 1700 in bd1ebf2

// DO NOT ADD ANY ENTRIES TO THIS LIST.
// We have a policy of not checking in binaries into this repository.
// If you are adding/changing template images, use the flutter_template_images
// package and a .img.tmpl placeholder instead.
// If you have other binaries to add, please consult Hixie for advice.
final Set<Hash256> _legacyBinaries = <Hash256>{

And it is the recommendation of Gradle, per https://docs.gradle.org/current/dsl/org.gradle.api.tasks.wrapper.Wrapper.html.

Also gitignores a local.properties file, which is output when opening Android Studio in the FGP root, and the gradle jar, which is a binary.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 21, 2025
This was referenced Jan 21, 2025
Closed
Merged
@gmackall
Copy link
Member Author

gmackall commented Jan 21, 2025

This actually won't work without the grade/wrapper/gradle-wrapper.jar:

mackall-macbookpro:gradle mackall$ rm gradle/wrapper/gradle-wrapper.jar 
mackall-macbookpro:gradle mackall$ ./gradlew
Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain
Caused by: java.lang.ClassNotFoundException: org.gradle.wrapper.GradleWrapperMain

Closing for now.

@gmackall gmackall closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gmackall