Skip to content

Drag handle semantic role #161941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hannah-hyj merged 3 commits into from
Jan 30, 2025
Merged

Drag handle semantic role #161941

hannah-hyj merged 3 commits into from
Jan 30, 2025

Conversation

@Wasmund1
Copy link
Contributor

@Wasmund1 Wasmund1 commented Jan 21, 2025

Adds semantic role button to ModalBottomSheet's DragHandle.

#161430

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jan 21, 2025
hannah-hyj
hannah-hyj approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@hannah-hyj hannah-hyj added the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Jan 21, 2025
nate-thegrate
nate-thegrate approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@nate-thegrate nate-thegrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this!

@github-actions github-actions bot removed the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Jan 23, 2025
@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025
@auto-submit

This comment was marked as outdated.

Sign in to view
@nate-thegrate
Copy link
Contributor

nate-thegrate commented Jan 23, 2025 •
edited
Loading

I believe Google Testing likely failed since it has a hard time interpreting merge commits. Hopefully a rebase will fix it!

Update: rebase did not fix it 🙁
My guess would be the failure is due to changes in this PR.

@nate-thegrate nate-thegrate force-pushed the drag_handle_semantic_role branch from 204776e to 0b97ba7 Compare January 23, 2025 22:37
@flutter-dashboard

This comment was marked as outdated.

Sign in to view
@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Jan 24, 2025
@nate-thegrate nate-thegrate force-pushed the drag_handle_semantic_role branch from 9a0f7ea to ea41326 Compare January 27, 2025 23:49
@nate-thegrate nate-thegrate added autosubmit Merge PR when tree becomes green via auto submit App and removed will affect goldens Changes to golden files labels Jan 27, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 28, 2025

autosubmit label was removed for flutter/flutter/161941, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks
Copy link
Contributor

Piinks commented Jan 29, 2025

From triage: @hannah-hyj will look into these Google testing failures 👍

@hannah-hyj
Copy link
Member

hannah-hyj commented Jan 29, 2025

re-running google testing with g3 fix added

@hannah-hyj hannah-hyj added this pull request to the merge queue Jan 30, 2025
Merged via the queue into flutter:master with commit 01a9aec Jan 30, 2025
100 checks passed
@kevmoo
Copy link
Contributor

kevmoo commented Jan 30, 2025 •
edited
Loading

Are we tracking to make sure the linked issue is closed? #161430

@hannah-hyj
Copy link
Member

hannah-hyj commented Jan 30, 2025

@kevmoo thank you for noticing it! i just closed it

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2025
@engine-flutter-autoroll
01a9aec Drag handle semantic role (flutter/flutter#161941)
8b4392c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2025
@engine-flutter-autoroll
01a9aec Drag handle semantic role (flutter/flutter#161941)
13177a2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2025
@engine-flutter-autoroll
01a9aec Drag handle semantic role (flutter/flutter#161941)
0bdf07f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2025
@engine-flutter-autoroll
01a9aec Drag handle semantic role (flutter/flutter#161941)
be61397
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025
@engine-flutter-autoroll
01a9aec Drag handle semantic role (flutter/flutter#161941)
a38bea0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025
@engine-flutter-autoroll
01a9aec Drag handle semantic role (flutter/flutter#161941)
d04d0df
@Piinks Piinks mentioned this pull request Jan 31, 2025
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025
@engine-flutter-autoroll
01a9aec Drag handle semantic role (flutter/flutter#161941)
891b85d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025
@engine-flutter-autoroll
01a9aec Drag handle semantic role (flutter/flutter#161941)
ec1344f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025
@engine-flutter-autoroll
01a9aec Drag handle semantic role (flutter/flutter#161941)
f42101e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025
@engine-flutter-autoroll
01a9aec Drag handle semantic role (flutter/flutter#161941)
3470f43
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025
@engine-flutter-autoroll
01a9aec Drag handle semantic role (flutter/flutter#161941)
f470ebf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025
@engine-flutter-autoroll
01a9aec Drag handle semantic role (flutter/flutter#161941)
41acd4b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
01a9aec Drag handle semantic role (flutter/flutter#161941)
3ff1a98
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
01a9aec Drag handle semantic role (flutter/flutter#161941)
8fd0051
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
01a9aec Drag handle semantic role (flutter/flutter#161941)
4544a2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannah-hyj hannah-hyj hannah-hyj approved these changes

+1 more reviewer

@nate-thegrate nate-thegrate nate-thegrate approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Wasmund1 @nate-thegrate @Piinks @hannah-hyj @kevmoo