Skip to content

Drag handle semantic role - #161941

Merged
hannah-hyj merged 3 commits into
flutter:masterfrom
Wasmund1:drag_handle_semantic_role
Jan 30, 2025
Merged

hannah-hyj merged 3 commits into
flutter:masterfrom
Wasmund1:drag_handle_semantic_role

Conversation

@Wasmund1

Copy link
Copy Markdown
Contributor

Adds semantic role button to ModalBottomSheet's DragHandle.

#161430

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla

This comment was marked as resolved.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Jan 21, 2025

@hannah-hyj hannah-hyj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@hannah-hyj hannah-hyj added the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Jan 21, 2025

@nate-thegrate nate-thegrate left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this!

@github-actions github-actions Bot removed the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Jan 23, 2025
@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025
@auto-submit

This comment was marked as outdated.

@nate-thegrate

nate-thegrate commented Jan 23, 2025 •

Copy link
Copy Markdown
Contributor

I believe Google Testing likely failed since it has a hard time interpreting merge commits. Hopefully a rebase will fix it!


Update: rebase did not fix it 🙁
My guess would be the failure is due to changes in this PR.

@nate-thegrate
nate-thegrate force-pushed the drag_handle_semantic_role branch from 204776e to 0b97ba7 Compare January 23, 2025 22:37
@flutter-dashboard

This comment was marked as outdated.

@flutter-dashboard flutter-dashboard Bot added the will affect goldens Changes to golden files label Jan 24, 2025
@nate-thegrate
nate-thegrate force-pushed the drag_handle_semantic_role branch from 9a0f7ea to ea41326 Compare January 27, 2025 23:49
@nate-thegrate nate-thegrate added autosubmit Merge PR when tree becomes green via auto submit App and removed will affect goldens Changes to golden files labels Jan 27, 2025
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2025
@auto-submit

auto-submit Bot commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/161941, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks

Piinks commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

From triage: @hannah-hyj will look into these Google testing failures 👍

@hannah-hyj

Copy link
Copy Markdown
Member

re-running google testing with g3 fix added

@hannah-hyj
hannah-hyj added this pull request to the merge queue Jan 30, 2025
Merged via the queue into flutter:master with commit 01a9aec Jan 30, 2025
@kevmoo

kevmoo commented Jan 30, 2025 •

Copy link
Copy Markdown
Contributor

Are we tracking to make sure the linked issue is closed? #161430

@hannah-hyj

Copy link
Copy Markdown
Member

@kevmoo thank you for noticing it! i just closed it

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants